From: Stephen Hemminger <stephen@networkplumber.org>
To: Quentin Armitage <quentin@armitage.org.uk>
Cc: Reshma Pattan <reshma.pattan@intel.com>,
Ray Kinsella <mdr@ashroe.eu>,
dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH] libpcapng: fix timestamp wrapping in output files
Date: Mon, 16 May 2022 06:26:06 -0700 [thread overview]
Message-ID: <20220516062606.3d4313b8@hermes.local> (raw)
In-Reply-To: <45bdbfad3857848faa2edc185db1ac639a901b23.camel@armitage.org.uk>
On Sat, 14 May 2022 18:14:48 +0100
Quentin Armitage <quentin@armitage.org.uk> wrote:
> The final statement of pcapng_tsc_to_ns() should be:
> return pcapng_time.ns + elapsed * TICK_SCALE;
>
> There is also a problem that rte_get_tsc_hz() returns eal_tsc_resolution_hz, but
> this is not initialized until rte_eal_init() is called, so rte_get_tsc_hz()
> cannot be called from a constructor function.
Better to do initialization on first use then.
It would be safer than the contstructor.
next prev parent reply other threads:[~2022-05-16 13:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-07 16:12 Quentin Armitage
2022-05-11 16:08 ` Stephen Hemminger
2022-05-11 16:46 ` Stephen Hemminger
2022-05-14 17:14 ` Quentin Armitage
2022-05-16 13:26 ` Stephen Hemminger [this message]
2022-05-17 10:01 ` [PATCH v2] " Quentin Armitage
2022-05-17 15:15 ` Stephen Hemminger
2022-06-01 14:38 ` Thomas Monjalon
2022-05-17 21:04 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220516062606.3d4313b8@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=mdr@ashroe.eu \
--cc=quentin@armitage.org.uk \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).