From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E5D9A0555 for ; Wed, 25 May 2022 18:29:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 58C27400EF; Wed, 25 May 2022 18:29:25 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 07B4F400EF for ; Wed, 25 May 2022 18:29:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653496163; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+++wLdoryVAAHcEBTOPKVvpDZ9WV/I86Qfj85gMZ2D0=; b=DRvumjGftst8T6vjEYmhIxntP7DxjgnLDjDXuBl6H/DAYAl5csqx+7IkYxVuaYjcwCFxyl 1ZajAAwArpGDNfgwxaIqSnmOcyZoUNj/14ttC0k2r4zd+Qel4rE7st2q87TLwOZZGxIUiD EAd4n4Bcf6kZhTbFTBw5hp1qifzYZXk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-404--mpDrb2CNMaisyO590HH_Q-1; Wed, 25 May 2022 12:29:18 -0400 X-MC-Unique: -mpDrb2CNMaisyO590HH_Q-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7AF258517C3; Wed, 25 May 2022 16:29:16 +0000 (UTC) Received: from rh.Home (unknown [10.39.193.216]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6F5AB2026D64; Wed, 25 May 2022 16:29:15 +0000 (UTC) From: Kevin Traynor To: Huisong Li Cc: Min Hu , dpdk stable Subject: patch 'net/bonding: fix slave stop and remove on port close' has been queued to stable release 21.11.2 Date: Wed, 25 May 2022 17:28:08 +0100 Message-Id: <20220525162847.711753-16-ktraynor@redhat.com> In-Reply-To: <20220525162847.711753-1-ktraynor@redhat.com> References: <20220525162847.711753-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/30/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/41c0ba64de669224f9b830a35b03966cc91d6a5e Thanks. Kevin --- >From 41c0ba64de669224f9b830a35b03966cc91d6a5e Mon Sep 17 00:00:00 2001 From: Huisong Li Date: Tue, 3 May 2022 18:02:14 +0800 Subject: [PATCH] net/bonding: fix slave stop and remove on port close [ upstream commit 1c5c6cd85f8cab2af92d265b6c7671df0b82e6fb ] All slaves will be stopped and removed when closing a bonded port. But the while loop can not end if both rte_eth_dev_stop and rte_eth_bond_slave_remove fails, runs infinitely. This is because the skipped slave port counted in both function failures but it should be counted only one. Fixing by not continue to process in the loop after first failure. Fixes: fb0379bc5db3 ("net/bonding: check stop call status") Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/bonding/rte_eth_bond_pmd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 121a6b3e4e..5257d4c07b 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -2157,4 +2157,5 @@ bond_ethdev_close(struct rte_eth_dev *dev) port_id); skipped++; + continue; } -- 2.34.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-05-25 17:26:58.988184905 +0100 +++ 0016-net-bonding-fix-slave-stop-and-remove-on-port-close.patch 2022-05-25 17:26:58.551828308 +0100 @@ -1 +1 @@ -From 1c5c6cd85f8cab2af92d265b6c7671df0b82e6fb Mon Sep 17 00:00:00 2001 +From 41c0ba64de669224f9b830a35b03966cc91d6a5e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 1c5c6cd85f8cab2af92d265b6c7671df0b82e6fb ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index 605fc2ffb5..f0668a636f 100644 +index 121a6b3e4e..5257d4c07b 100644