From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2CA06A0555 for ; Wed, 25 May 2022 18:29:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 27550400EF; Wed, 25 May 2022 18:29:41 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 67249400EF for ; Wed, 25 May 2022 18:29:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653496179; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mQM3uxgfOM0rZXDMSRbf6UzzJNsrVUzAK+NFh+Y9J+A=; b=eS0Y4zAFg5qpKZ3WWbpkpzkX/y42K5nc9KA/5dFOjumXPgEvBWJ+tW+JiqgnC7jHsqxjcd 4E8A7e9S+1I45lC/UFGCXO0+wLWKYx3o0VGuphLRv5xq7Jxb68JbWi3YWR7Qk1DLTw7/5G /lq6g+ZW1KCi85AECyaMOzu88ZhliC0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-277-QyaJNPauO-yoKJJBn5nmEw-1; Wed, 25 May 2022 12:29:36 -0400 X-MC-Unique: QyaJNPauO-yoKJJBn5nmEw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AF27A8A5213; Wed, 25 May 2022 16:29:24 +0000 (UTC) Received: from rh.Home (unknown [10.39.193.216]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5BE9F20296A2; Wed, 25 May 2022 16:29:23 +0000 (UTC) From: Kevin Traynor To: Huisong Li Cc: Min Hu , dpdk stable Subject: patch 'net/hns3: fix pseudo-sharing between threads' has been queued to stable release 21.11.2 Date: Wed, 25 May 2022 17:28:13 +0100 Message-Id: <20220525162847.711753-21-ktraynor@redhat.com> In-Reply-To: <20220525162847.711753-1-ktraynor@redhat.com> References: <20220525162847.711753-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/30/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/74089f471acd86f4267ed66e15a567feaf5f6576 Thanks. Kevin --- >From 74089f471acd86f4267ed66e15a567feaf5f6576 Mon Sep 17 00:00:00 2001 From: Huisong Li Date: Thu, 5 May 2022 20:27:03 +0800 Subject: [PATCH] net/hns3: fix pseudo-sharing between threads [ upstream commit ec0147b5690e6cae2cc4555f78b87defee59c946 ] Some fields in the end of 'struct hns3_rx_queue' and 'struct hns3_tx_queue' are not accessed in the I/O path. But these fields may be accessed in other threads, which may lead to the problem of cache pseudo-sharing of IO threads. This patch add a cacheline alignment to avoid it. Fixes: 9261fd3caf1f ("net/hns3: improve IO path data cache usage") Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_rxtx.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/hns3/hns3_rxtx.h b/drivers/net/hns3/hns3_rxtx.h index e202eb9c30..0e412d07b3 100644 --- a/drivers/net/hns3/hns3_rxtx.h +++ b/drivers/net/hns3/hns3_rxtx.h @@ -350,5 +350,5 @@ struct hns3_rx_queue { * placed at the end. */ - void *io_base; + void *io_base __rte_cache_aligned; struct hns3_adapter *hns; uint64_t rx_ring_phys_addr; /* RX ring DMA address */ @@ -524,5 +524,5 @@ struct hns3_tx_queue { * placed at the end. */ - void *io_base; + void *io_base __rte_cache_aligned; struct hns3_adapter *hns; uint64_t tx_ring_phys_addr; /* TX ring DMA address */ -- 2.34.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-05-25 17:26:59.099646534 +0100 +++ 0021-net-hns3-fix-pseudo-sharing-between-threads.patch 2022-05-25 17:26:58.569828334 +0100 @@ -1 +1 @@ -From ec0147b5690e6cae2cc4555f78b87defee59c946 Mon Sep 17 00:00:00 2001 +From 74089f471acd86f4267ed66e15a567feaf5f6576 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ec0147b5690e6cae2cc4555f78b87defee59c946 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index a000318357..62efc854e4 100644 +index e202eb9c30..0e412d07b3 100644 @@ -25 +26 @@ -@@ -349,5 +349,5 @@ struct hns3_rx_queue { +@@ -350,5 +350,5 @@ struct hns3_rx_queue { @@ -32 +33 @@ -@@ -522,5 +522,5 @@ struct hns3_tx_queue { +@@ -524,5 +524,5 @@ struct hns3_tx_queue {