From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09051A0555 for ; Wed, 25 May 2022 18:29:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 04431400EF; Wed, 25 May 2022 18:29:04 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 4FC80400EF for ; Wed, 25 May 2022 18:29:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653496142; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1ERmKdTFmgk81Bil6vfml++H4kSHHxOuV0cXmxxuuQI=; b=R1WT+HK+mI49deysg2nHDRoePWxTJbZHcfnZOIMdmmEGg3RFt144mW2xWPRuQYV3Xfyz2+ KkiL++k2aCSULX42WhOVLQWxL7mZVqvXY2g2Msa5AmiH0+VSntUjR9RS71y4nEliqjhl9X Y53nsApgM5XrjE8U5ZhOtmYjmFfGbco= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-456-TBV0r-BTOUyUw11KxI8rqg-1; Wed, 25 May 2022 12:29:01 -0400 X-MC-Unique: TBV0r-BTOUyUw11KxI8rqg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B00473817A77; Wed, 25 May 2022 16:29:00 +0000 (UTC) Received: from rh.Home (unknown [10.39.193.216]) by smtp.corp.redhat.com (Postfix) with ESMTP id AF61A2026D64; Wed, 25 May 2022 16:28:59 +0000 (UTC) From: Kevin Traynor To: Ke Zhang Cc: Min Hu , dpdk stable Subject: patch 'net/bonding: fix RSS key config with extended key length' has been queued to stable release 21.11.2 Date: Wed, 25 May 2022 17:27:56 +0100 Message-Id: <20220525162847.711753-4-ktraynor@redhat.com> In-Reply-To: <20220525162847.711753-1-ktraynor@redhat.com> References: <20220525162847.711753-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/30/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/8cf194f699b1476a8a2630cbf1e7e7a812e4dd0b Thanks. Kevin --- >From 8cf194f699b1476a8a2630cbf1e7e7a812e4dd0b Mon Sep 17 00:00:00 2001 From: Ke Zhang Date: Mon, 11 Apr 2022 05:40:03 +0000 Subject: [PATCH] net/bonding: fix RSS key config with extended key length [ upstream commit 94d9c7d45b43fd44af718b621fa52e556028aa3d ] When creating a bonding device, if the slave device's RSS key length = standard_rss_key length + extended_hash_key length, then bonding device will be same as slave, in function bond_ethdev_configure(), the default_rss_key length is 40, it is not matched, so it should calculate a new key for bonding device if the default key could not be used. Fixes: 6b1a001ec546 ("net/bonding: fix RSS key length") Signed-off-by: Ke Zhang Acked-by: Min Hu (Connor) --- drivers/net/bonding/rte_eth_bond_pmd.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 58dad0a0e3..e8a9341777 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -3617,11 +3617,16 @@ bond_ethdev_configure(struct rte_eth_dev *dev) } else { if (internals->rss_key_len > sizeof(default_rss_key)) { - RTE_BOND_LOG(ERR, - "There is no suitable default hash key"); - return -EINVAL; + /* + * If the rss_key includes standard_rss_key and + * extended_hash_key, the rss key length will be + * larger than default rss key length, so it should + * re-calculate the hash key. + */ + for (i = 0; i < internals->rss_key_len; i++) + internals->rss_key[i] = (uint8_t)rte_rand(); + } else { + memcpy(internals->rss_key, default_rss_key, + internals->rss_key_len); } - - memcpy(internals->rss_key, default_rss_key, - internals->rss_key_len); } -- 2.34.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-05-25 17:26:58.744395694 +0100 +++ 0004-net-bonding-fix-RSS-key-config-with-extended-key-len.patch 2022-05-25 17:26:58.534828283 +0100 @@ -1 +1 @@ -From 94d9c7d45b43fd44af718b621fa52e556028aa3d Mon Sep 17 00:00:00 2001 +From 8cf194f699b1476a8a2630cbf1e7e7a812e4dd0b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 94d9c7d45b43fd44af718b621fa52e556028aa3d ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index b305b6a35b..5cbe89031b 100644 +index 58dad0a0e3..e8a9341777 100644 @@ -26 +27 @@ -@@ -3618,11 +3618,16 @@ bond_ethdev_configure(struct rte_eth_dev *dev) +@@ -3617,11 +3617,16 @@ bond_ethdev_configure(struct rte_eth_dev *dev)