From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9665A0555 for ; Wed, 25 May 2022 18:30:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D1D20400EF; Wed, 25 May 2022 18:30:01 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id EF68D42B6C for ; Wed, 25 May 2022 18:29:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653496199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ugyYIw4fm7dfW04f1dBSVhdhy4S4FaN8RQgXPbvWncU=; b=RQYlHT9s2reZnDMivjMbnaZvkAcd4XobKZSvrdmIrdUpjkkE21q2T29M5kRbD2e5VcVjMZ 6LUasT3Dg7Uekbc+3j5cvaR716lxhbe6WEkYTrJpUG61cFzVyBe1qAyHBiZ02+z+OMox65 97Qfkyeb03RF7VOlfXl4IV9Igbt1OQA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-627-vZ7BF30jNqyzeBNTTXhSUQ-1; Wed, 25 May 2022 12:29:56 -0400 X-MC-Unique: vZ7BF30jNqyzeBNTTXhSUQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 06B0A803D5B; Wed, 25 May 2022 16:29:56 +0000 (UTC) Received: from rh.Home (unknown [10.39.193.216]) by smtp.corp.redhat.com (Postfix) with ESMTP id C676C2026D64; Wed, 25 May 2022 16:29:54 +0000 (UTC) From: Kevin Traynor To: Somnath Kotur Cc: Ajit Khaparde , Kalesh AP , dpdk stable Subject: patch 'net/bnxt: fix ring group on Rx restart' has been queued to stable release 21.11.2 Date: Wed, 25 May 2022 17:28:33 +0100 Message-Id: <20220525162847.711753-41-ktraynor@redhat.com> In-Reply-To: <20220525162847.711753-1-ktraynor@redhat.com> References: <20220525162847.711753-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/30/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/3f9914a7b32eb59a5c4286114e5dbe2b5b936338 Thanks. Kevin --- >From 3f9914a7b32eb59a5c4286114e5dbe2b5b936338 Mon Sep 17 00:00:00 2001 From: Somnath Kotur Date: Wed, 27 Apr 2022 20:28:12 +0530 Subject: [PATCH] net/bnxt: fix ring group on Rx restart [ upstream commit 1b27f8245eee1209d9ee27304fae3515e93ef5b0 ] When an Rx queue is stopped and restarted, as part of that workflow, for cards that have ring groups, we free and reallocate the ring group. This new ring group is not communicated to the VNIC though via HWRM_VNIC_CFG cmd. Fix to issue HWRM_VNIC_CFG cmd on all adapters now in this scenario. Fixes: ed0ae3502fc9 ("net/bnxt: update ring group after ring stop start") Signed-off-by: Somnath Kotur Reviewed-by: Ajit Khaparde Reviewed-by: Kalesh AP --- drivers/net/bnxt/bnxt_rxq.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c index 8977138012..43c81df014 100644 --- a/drivers/net/bnxt/bnxt_rxq.c +++ b/drivers/net/bnxt/bnxt_rxq.c @@ -488,8 +488,9 @@ int bnxt_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id) return rc; - if (BNXT_CHIP_P5(bp)) { - /* Reconfigure default receive ring and MRU. */ - bnxt_hwrm_vnic_cfg(bp, rxq->vnic); - } + if (BNXT_HAS_RING_GRPS(bp)) + rxq->vnic->dflt_ring_grp = bp->grp_info[rx_queue_id].fw_grp_id; + /* Reconfigure default receive ring and MRU. */ + bnxt_hwrm_vnic_cfg(bp, rxq->vnic); + PMD_DRV_LOG(INFO, "Rx queue started %d\n", rx_queue_id); -- 2.34.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-05-25 17:26:59.543763291 +0100 +++ 0041-net-bnxt-fix-ring-group-on-Rx-restart.patch 2022-05-25 17:26:58.627828420 +0100 @@ -1 +1 @@ -From 1b27f8245eee1209d9ee27304fae3515e93ef5b0 Mon Sep 17 00:00:00 2001 +From 3f9914a7b32eb59a5c4286114e5dbe2b5b936338 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 1b27f8245eee1209d9ee27304fae3515e93ef5b0 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index 8147404d9c..9b5ff4ce2d 100644 +index 8977138012..43c81df014 100644 @@ -26 +27 @@ -@@ -489,8 +489,9 @@ int bnxt_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id) +@@ -488,8 +488,9 @@ int bnxt_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id)