From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87B14A0555 for ; Wed, 25 May 2022 18:30:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 831C642B85; Wed, 25 May 2022 18:30:11 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id BE2D540151 for ; Wed, 25 May 2022 18:30:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653496209; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BqEXoAitepTJ4LDifUMF7ZCdnSTP09xWJzb7fwyZTBc=; b=gYG1nLGIWydsqV+99igqMV3kgi9AyCCVNNrIWkS4nOJ3qJJnxn62Wxp3/nHWl8dwlx3z5F CSNVsREOb1AbkIQLU/HoQZn62+SMICo8OeQPIw+IQEL9XHg1UJh9znE4TlaXH+UkUStIoG 5foZMYkgb3RKxI+hZBDvIsH4qnc/R1Q= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-649-k4LMxRowNnSLMkQyc21NFQ-1; Wed, 25 May 2022 12:30:07 -0400 X-MC-Unique: k4LMxRowNnSLMkQyc21NFQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 83CDE1C01B2F; Wed, 25 May 2022 16:30:07 +0000 (UTC) Received: from rh.Home (unknown [10.39.193.216]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9F4622026985; Wed, 25 May 2022 16:30:06 +0000 (UTC) From: Kevin Traynor To: Kalesh AP Cc: Ajit Khaparde , Somnath Kotur , dpdk stable Subject: patch 'net/bnxt: fix link status when port is stopped' has been queued to stable release 21.11.2 Date: Wed, 25 May 2022 17:28:39 +0100 Message-Id: <20220525162847.711753-47-ktraynor@redhat.com> In-Reply-To: <20220525162847.711753-1-ktraynor@redhat.com> References: <20220525162847.711753-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/30/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/2ff3768d20f30106ba2fec1bcc573abe1a163805 Thanks. Kevin --- >From 2ff3768d20f30106ba2fec1bcc573abe1a163805 Mon Sep 17 00:00:00 2001 From: Kalesh AP Date: Wed, 27 Apr 2022 20:28:18 +0530 Subject: [PATCH] net/bnxt: fix link status when port is stopped [ upstream commit 7b6eba8856ce3088a759d8e14bb0b73872f65526 ] Driver forces link down during port stop. But device is not obliged link down in certain scenarios, even when forced. In that case, subsequent link queries returns link as up. Fixed to return link status as down when port is stopped. Driver is already doing that for VF/NPAR/MH functions. Fixes: c09f57b49c13 ("net/bnxt: add start/stop/link update operations") Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_ethdev.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 89506e9ef1..9b3b7b76df 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -1828,4 +1828,12 @@ int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int wait_to_complete) goto out; + /* Only single function PF can bring the phy down. + * In certain scenarios, device is not obliged link down even when forced. + * When port is stopped, report link down in those cases. + */ + if (!eth_dev->data->dev_started && + (!BNXT_SINGLE_PF(bp) || bnxt_force_link_config(bp))) + goto out; + do { /* Retrieve link info from hardware */ @@ -1845,10 +1853,4 @@ int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int wait_to_complete) } while (cnt--); - /* Only single function PF can bring phy down. - * When port is stopped, report link down for VF/MH/NPAR functions. - */ - if (!BNXT_SINGLE_PF(bp) && !eth_dev->data->dev_started) - memset(&new, 0, sizeof(new)); - out: /* Timed out or success */ -- 2.34.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-05-25 17:26:59.672293116 +0100 +++ 0047-net-bnxt-fix-link-status-when-port-is-stopped.patch 2022-05-25 17:26:58.645828446 +0100 @@ -1 +1 @@ -From 7b6eba8856ce3088a759d8e14bb0b73872f65526 Mon Sep 17 00:00:00 2001 +From 2ff3768d20f30106ba2fec1bcc573abe1a163805 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 7b6eba8856ce3088a759d8e14bb0b73872f65526 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index 1904db93c4..69f1117ffa 100644 +index 89506e9ef1..9b3b7b76df 100644 @@ -26 +27 @@ -@@ -1827,4 +1827,12 @@ int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int wait_to_complete) +@@ -1828,4 +1828,12 @@ int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int wait_to_complete) @@ -39 +40 @@ -@@ -1844,10 +1852,4 @@ int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int wait_to_complete) +@@ -1845,10 +1853,4 @@ int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int wait_to_complete)