From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BFD24A0555 for ; Wed, 25 May 2022 18:30:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB55B42B7C; Wed, 25 May 2022 18:30:13 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C6A4C42B7C for ; Wed, 25 May 2022 18:30:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653496212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Betvx1IOyB/uCz/XvtoavTfPgcTZqKJsgAyb3CtzJhc=; b=WnZZcYJ7fZ9hJ54WfMwFMIHUjc4hwHHpnLQWZ4OcCeSXLxG92pha78850efpho9eWD20Zh g+h7N1wX7kzKTfm9BLLBeOMkol4pIh0ui4/c9/wxNenjSx38emLfxkhgx/afXckT2gXzZC D/qyEILZ+6C/2nXqR0bl0wJAY8WWA2Y= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-341-1UPaYN-hNEKDjMrIPzmVFQ-1; Wed, 25 May 2022 12:30:10 -0400 X-MC-Unique: 1UPaYN-hNEKDjMrIPzmVFQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 88259185A7A4; Wed, 25 May 2022 16:30:10 +0000 (UTC) Received: from rh.Home (unknown [10.39.193.216]) by smtp.corp.redhat.com (Postfix) with ESMTP id 66B9A2026D64; Wed, 25 May 2022 16:30:09 +0000 (UTC) From: Kevin Traynor To: Somnath Kotur Cc: Kalesh AP , Ajit Khaparde , dpdk stable Subject: patch 'net/bnxt: fix freeing VNIC filters' has been queued to stable release 21.11.2 Date: Wed, 25 May 2022 17:28:41 +0100 Message-Id: <20220525162847.711753-49-ktraynor@redhat.com> In-Reply-To: <20220525162847.711753-1-ktraynor@redhat.com> References: <20220525162847.711753-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/30/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/68576536257d4240faea38b7fe253bddd0fef869 Thanks. Kevin --- >From 68576536257d4240faea38b7fe253bddd0fef869 Mon Sep 17 00:00:00 2001 From: Somnath Kotur Date: Wed, 27 Apr 2022 20:28:20 +0530 Subject: [PATCH] net/bnxt: fix freeing VNIC filters [ upstream commit 2df7dfffe3dc5d6b65c77a7fbe155e38a9e3dc24 ] In bnxt_free_all_filters(), all the filters attached to a vnic are removed. But each of these filters hold a backreference ptr to the vnic and they need to be reset to NULL now. Otherwise, during a normal testpmd quit, as part of dev_close_op(), first bnxt_free_all_filters() is invoked in dev_stop, followed by bnxt_free_filter_mem() from bnxt_uninit_resources(), which finds a filter with a vnic back reference ptr and now bnxt_hwrm_clean_up_l2_filter() also tries to remove the filter from the vnic's filter list which was already done as part of bnxt_free_all_filters(). Fixes: f0f6b5e6cf94 ("net/bnxt: fix reusing L2 filter") Signed-off-by: Somnath Kotur Reviewed-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_filter.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/bnxt/bnxt_filter.c b/drivers/net/bnxt/bnxt_filter.c index 1d08e03b2f..b0c3bbd1b2 100644 --- a/drivers/net/bnxt/bnxt_filter.c +++ b/drivers/net/bnxt/bnxt_filter.c @@ -100,4 +100,6 @@ void bnxt_free_all_filters(struct bnxt *bp) STAILQ_INSERT_TAIL(&bp->free_filter_list, filter, next); + if (filter->vnic) + filter->vnic = NULL; filter = temp_filter; } -- 2.34.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-05-25 17:26:59.717515917 +0100 +++ 0049-net-bnxt-fix-freeing-VNIC-filters.patch 2022-05-25 17:26:58.649828452 +0100 @@ -1 +1 @@ -From 2df7dfffe3dc5d6b65c77a7fbe155e38a9e3dc24 Mon Sep 17 00:00:00 2001 +From 68576536257d4240faea38b7fe253bddd0fef869 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 2df7dfffe3dc5d6b65c77a7fbe155e38a9e3dc24 ] + @@ -17 +18,0 @@ -Cc: stable@dpdk.org