From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59BBCA04FD for ; Mon, 30 May 2022 11:22:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 51DFA42B85; Mon, 30 May 2022 11:22:14 +0200 (CEST) Received: from smtpbgeu2.qq.com (smtpbgeu2.qq.com [18.194.254.142]) by mails.dpdk.org (Postfix) with ESMTP id 392C042B75 for ; Mon, 30 May 2022 11:22:13 +0200 (CEST) X-QQ-mid: bizesmtp87t1653902527tenqef49 Received: from wxdbg.localdomain.com ( [183.129.236.74]) by bizesmtp.qq.com (ESMTP) with id ; Mon, 30 May 2022 17:22:07 +0800 (CST) X-QQ-SSF: 01400000000000F0P000000A0000000 X-QQ-FEAT: eTtJes0duVvyi9EXH2qCOAOWX+JEZZsrtYqFd5Bdk7Mk6peZssQGm4vtNUWHC BHFOH1al7fvnAaO1w5KGZyJxtqR8Q+HhIJOEfXTqbFQrGzgF5ohpDhC62q2ETg6q+yPMRwN gPLmjwylpKdcdufqQnneGMy0jQI7PAKqElM8sW/9oIbmOIeaw8MZdvmOO75j4pxu+uTeIQ+ szqCi9/CrENKte1OwqILifZGxVPJlilqL0IXA0TggoM9ngy1115QS/DQ9TIA0jZ4hwcSRmm ejLWvkzFL7906qmTh4qdtO1etXifVT0nfwIlEzKNo/LSk0bajHrowFF6G9wYqjRVcUjN1RY MSEoCGFU5c2MnYFV6+uGqHUJ4h6Xh2JDo/29iwN X-QQ-GoodBg: 2 From: Jiawen Wu To: dev@dpdk.org Cc: Jiawen Wu , stable@dpdk.org Subject: [PATCH 1/9] net/ngbe: fix to set force speed Date: Mon, 30 May 2022 17:30:08 +0800 Message-Id: <20220530093016.16326-2-jiawenwu@trustnetic.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220530093016.16326-1-jiawenwu@trustnetic.com> References: <20220530093016.16326-1-jiawenwu@trustnetic.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign4 X-QQ-Bgrelay: 1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Since the bit of ETH_LINK_SPEED_FIXED was set for the force link speed, it conflicts with '~allowed_speeds'. Fixes: 3518df5774c7 ("net/ngbe: support device start/stop") Cc: stable@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c index 4a2a9dde10..c7301a9616 100644 --- a/drivers/net/ngbe/ngbe_ethdev.c +++ b/drivers/net/ngbe/ngbe_ethdev.c @@ -1048,7 +1048,7 @@ ngbe_dev_start(struct rte_eth_dev *dev) if (hw->mac.default_speeds & NGBE_LINK_SPEED_10M_FULL) allowed_speeds |= RTE_ETH_LINK_SPEED_10M; - if (*link_speeds & ~allowed_speeds) { + if (((*link_speeds) >> 1) & ~(allowed_speeds >> 1)) { PMD_INIT_LOG(ERR, "Invalid link setting"); goto error; } -- 2.27.0