From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Wenxuan Wu <wenxuanx.wu@intel.com>,
bruce.richardson@intel.com, dev@dpdk.org, stable@dpdk.org,
david.marchand@redhat.com
Subject: Re: [PATCH] build: fix meson build when gcc >= 10.0
Date: Tue, 7 Jun 2022 08:09:53 -0700 [thread overview]
Message-ID: <20220607080953.1f35df17@hermes.local> (raw)
In-Reply-To: <26640576.6Emhk5qWAg@thomas>
On Tue, 07 Jun 2022 12:52:32 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:
> 07/06/2022 04:56, wenxuanx.wu@intel.com:
> > From: Wenxuan Wu <wenxuanx.wu@intel.com>
> >
> > GCC version greater than 10.0, with compile option -O2, several warnings info would appear,
> > this fix omitted these warnings.
> [...]
> > # FIXME: Bugzilla 396
> > - warning_flags += '-Wno-zero-length-bounds'
> > + warning_flags += [
> > + '-Wno-zero-length-bounds',
> > + '-Wno-stringop-overflow',
> > + '-Wno-array-bounds',
> > + '-Wno-format-overflow',
>
> The compilers are reported warnings to help us having a better code.
> We should try to resolve the warnings, not hiding them.
>
>
Agree with Thomas. This not how to address this.
There are fixes already for the zero-length-bounds that are being merged.
Patches accepted to fix the rest.
next prev parent reply other threads:[~2022-06-07 15:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 2:56 wenxuanx.wu
2022-06-07 10:52 ` Thomas Monjalon
2022-06-07 15:09 ` Stephen Hemminger [this message]
2022-06-07 15:13 ` David Marchand
2022-06-07 15:25 ` Stephen Hemminger
2022-06-08 3:27 ` Wu, WenxuanX
-- strict thread matches above, loose matches on Subject: below --
2022-06-07 2:55 wenxuanx.wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220607080953.1f35df17@hermes.local \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=wenxuanx.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).