From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8336A054D for ; Tue, 7 Jun 2022 17:25:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B4F2640156; Tue, 7 Jun 2022 17:25:33 +0200 (CEST) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 4E45C40156 for ; Tue, 7 Jun 2022 17:25:32 +0200 (CEST) Received: by mail-pl1-f174.google.com with SMTP id d22so15073819plr.9 for ; Tue, 07 Jun 2022 08:25:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hn2SwmGDMWTNXTkXf+nIASjG7iCvKTui2j1fxCphnTY=; b=JnEQdFFAz+L4BYqlm/NSG5n1QgcUS/o1n9s2WhqQYsZBKj2AuFTUoIdcWjHy3uIFAk E/8cZHf07H9PvB66gAyih7+8TGi0YS7UJSbKeu81+QWNS69/iqbM/rcHhiH51gHuSqqV AxwfXK1QbdmxqlG0YTzpCsRZ9sKjclBs5O0aqYZvauIwRTqpcUlTXaDRHVe6lNxAbSn+ qxNdNjwNETXwgrxPOsA6c4yjm3UFQg69RyhxOwfkc06cUUxBCEBYDOC7TobtiLhtOEeN ZdEmXPKIFnSoV8SsVg+xl9pnVpRsHh40tqIm/wnYQ68DgAae3ttpLOidsazloQMqFYmO m6TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hn2SwmGDMWTNXTkXf+nIASjG7iCvKTui2j1fxCphnTY=; b=O2I4KXO80Dm8T6wpiwXjWvEOdOJ2GJDr9JKV7nPcUmAxDO6yWtDE50V9+jy8IUGJxl ZO13AQtWUwFECCw87ONzY7KQqD8mqPfTP1iu/Xio8rPDqS4G3CdHqgmXwMu6apcbWLFM hYIlSmfNkdNWyf8AFeoqURTQlWHlGxvOexKIpCMBG8HsTsADvHki2cL8QgfbI4YL30bC /p+dFkvuwL+yEWAiKDpNQRc87kcuFK8pWAVSzSP719nymhmvzEcJrFbWvzLVt7jJZhH0 cna8YVjtRYNG7c4mxCC3dcQKCes7sJqRe9Oybks908oL+VnPkjuVxyaZkWEzOftAplgh BO/g== X-Gm-Message-State: AOAM532M6sRdaIOuF+c3XJivhbVc4IVlCh0mArokwreEMTy+pA+Xt9NO Tn1TYw/BWssJEAf106D7Z7Ae6w== X-Google-Smtp-Source: ABdhPJzRAGovumRJ96QXoPkoEcYnyAXZ5p3q/qcyfYvo4CLzE91FrkIGliFxQ/Uc2fxYpy1sbA5WfA== X-Received: by 2002:a17:902:e5d2:b0:164:1958:c858 with SMTP id u18-20020a170902e5d200b001641958c858mr29991583plf.62.1654615531533; Tue, 07 Jun 2022 08:25:31 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id 185-20020a6216c2000000b005183434ec84sm9222984pfw.145.2022.06.07.08.25.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jun 2022 08:25:31 -0700 (PDT) Date: Tue, 7 Jun 2022 08:25:26 -0700 From: Stephen Hemminger To: David Marchand Cc: Thomas Monjalon , Wenxuan Wu , Bruce Richardson , dev , dpdk stable Subject: Re: [PATCH] build: fix meson build when gcc >= 10.0 Message-ID: <20220607082526.4067c3c8@hermes.local> In-Reply-To: References: <20220607025652.1114683-1-wenxuanx.wu@intel.com> <26640576.6Emhk5qWAg@thomas> <20220607080953.1f35df17@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, 7 Jun 2022 17:13:07 +0200 David Marchand wrote: > On Tue, Jun 7, 2022 at 5:10 PM Stephen Hemminger > wrote: > > On Tue, 07 Jun 2022 12:52:32 +0200 > > Thomas Monjalon wrote: > > > 07/06/2022 04:56, wenxuanx.wu@intel.com: > > > > From: Wenxuan Wu > > > > > > > > GCC version greater than 10.0, with compile option -O2, several warnings info would appear, > > > > this fix omitted these warnings. > > > [...] > > > > # FIXME: Bugzilla 396 > > > > - warning_flags += '-Wno-zero-length-bounds' > > > > + warning_flags += [ > > > > + '-Wno-zero-length-bounds', > > > > + '-Wno-stringop-overflow', > > > > + '-Wno-array-bounds', > > > > + '-Wno-format-overflow', > > > > > > The compilers are reported warnings to help us having a better code. > > > We should try to resolve the warnings, not hiding them. > > > > > > > > > > Agree with Thomas. This not how to address this. > > There are fixes already for the zero-length-bounds that are being merged. > > I just merged them, though, afaics, they fix none of the compilation > issues reported with gcc 12. > > I noticed that several of the gcc 12 issues are because rte_memcpy can access past the end of the input array in some cases. Since most of these are small arrays like RSS keys. The simplest fix would be skip using rte_memcpy (and just use memcpy) for all these trivial places which are not performance sensitive.