From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00524A0555 for ; Thu, 9 Jun 2022 13:37:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EE30F40220; Thu, 9 Jun 2022 13:37:32 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 9EEF840220 for ; Thu, 9 Jun 2022 13:37:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654774649; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nrJULl8xwoJ9Gm7MAiiFFyjRetnImWYiefiSeCInwEg=; b=QuDRyFLHMI8Bp3llGur/wO1oz3b3mbRXCTr/epYWom77EwzsW4rtYG6pc+xmXN6PsocJga 8Pe/5DQ1AFJo1hPECzjCMi5lEa0IJmbsNCMUSiQCKS6wAjitFzCJ3mv5C4RYMwJOcc7jyI 4W17aj0It+j8yY+B9sMCrnZWVJW4F84= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-595-Ug3mcn7ZNrSp_Pk68fuwbQ-1; Thu, 09 Jun 2022 07:37:26 -0400 X-MC-Unique: Ug3mcn7ZNrSp_Pk68fuwbQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 76AFC1DC2427; Thu, 9 Jun 2022 11:37:26 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.195.82]) by smtp.corp.redhat.com (Postfix) with ESMTP id 46EC31730C; Thu, 9 Jun 2022 11:37:25 +0000 (UTC) From: Kevin Traynor To: Volodymyr Fialko Cc: Anoob Joseph , Akhil Goyal , dpdk stable Subject: patch 'examples/ipsec-secgw: fix uninitialized memory access' has been queued to stable release 21.11.2 Date: Thu, 9 Jun 2022 12:35:59 +0100 Message-Id: <20220609113701.386938-12-ktraynor@redhat.com> In-Reply-To: <20220609113701.386938-1-ktraynor@redhat.com> References: <20220609113701.386938-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/13/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/51952c8f0ca75186b972dcef5e2627221157180d Thanks. Kevin --- >From 51952c8f0ca75186b972dcef5e2627221157180d Mon Sep 17 00:00:00 2001 From: Volodymyr Fialko Date: Fri, 25 Mar 2022 12:29:42 +0100 Subject: [PATCH] examples/ipsec-secgw: fix uninitialized memory access [ upstream commit 0b512a92b77009ab6e4291382b18f0e0ac74645f ] rte_flow_validate and rte_flow_create not always initialize flow error. Using error.message in some error cases will cause read from uninitialized memory. Fixes: 6738c0a9569 ("examples/ipsec-secgw: support flow director") Signed-off-by: Volodymyr Fialko Acked-by: Anoob Joseph Acked-by: Akhil Goyal --- examples/ipsec-secgw/flow.c | 2 +- examples/ipsec-secgw/ipsec.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/ipsec-secgw/flow.c b/examples/ipsec-secgw/flow.c index 1a1ec7861c..c217b9e475 100644 --- a/examples/ipsec-secgw/flow.c +++ b/examples/ipsec-secgw/flow.c @@ -215,5 +215,5 @@ flow_init_single(struct flow_rule_entry *rule) struct rte_flow_action action[MAX_RTE_FLOW_ACTIONS] = {}; struct rte_flow_attr attr = {}; - struct rte_flow_error err; + struct rte_flow_error err = {}; int ret; diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c index 2d4a26c962..b66ff2b650 100644 --- a/examples/ipsec-secgw/ipsec.c +++ b/examples/ipsec-secgw/ipsec.c @@ -497,5 +497,5 @@ create_ipsec_esp_flow(struct ipsec_sa *sa) { int ret = 0; - struct rte_flow_error err; + struct rte_flow_error err = {}; if (sa->direction == RTE_SECURITY_IPSEC_SA_DIR_EGRESS) { RTE_LOG(ERR, IPSEC, -- 2.34.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-06-09 12:34:30.055204563 +0100 +++ 0012-examples-ipsec-secgw-fix-uninitialized-memory-access.patch 2022-06-09 12:34:29.619980426 +0100 @@ -1 +1 @@ -From 0b512a92b77009ab6e4291382b18f0e0ac74645f Mon Sep 17 00:00:00 2001 +From 51952c8f0ca75186b972dcef5e2627221157180d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 0b512a92b77009ab6e4291382b18f0e0ac74645f ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org