From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8595A0555 for ; Thu, 9 Jun 2022 13:37:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A286C40689; Thu, 9 Jun 2022 13:37:41 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id DB0F940220 for ; Thu, 9 Jun 2022 13:37:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654774659; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z91HEGo45YA51Y5C2RWi6991qQRU7srxT7IsyZpNgA8=; b=aQyyQUOvl6RmMozHrbysyAlfz6vHxMFdpxCg9D1K5mpXE+4GkrCQ+AosA9yTryZu6FYRwX c9BAAEaA8yav3/L7X4/hAIdS/0nKB9pTKmm0328Zf9t3HP32JgMcW7eiaC/qoZifpMBMJr SerQ3D9W+Br8RhACxUmRCHbtxw33I3M= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-544-U7HBiJkHP7yMUAsfZpUkJg-1; Thu, 09 Jun 2022 07:37:38 -0400 X-MC-Unique: U7HBiJkHP7yMUAsfZpUkJg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 384AE85A580 for ; Thu, 9 Jun 2022 11:37:38 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.195.82]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5D87E18EA6; Thu, 9 Jun 2022 11:37:37 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: dpdk stable Subject: patch 'app/testpmd: remove useless pointer checks' has been queued to stable release 21.11.2 Date: Thu, 9 Jun 2022 12:36:07 +0100 Message-Id: <20220609113701.386938-20-ktraynor@redhat.com> In-Reply-To: <20220609113701.386938-1-ktraynor@redhat.com> References: <20220609113701.386938-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/13/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/f84770f8fcc62e7a3e2e2c8c32dff99e0a2c2b31 Thanks. Kevin --- >From f84770f8fcc62e7a3e2e2c8c32dff99e0a2c2b31 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Thu, 24 Mar 2022 17:15:03 +0100 Subject: [PATCH] app/testpmd: remove useless pointer checks [ upstream commit 2d8699ebb2a0638e8ae18fc0a83c56f984d0b270 ] Parameters to this static helper can't be NULL. str has already been dereferenced in caller. dst and size point to variable in stack. Fixes: 169a9fed1f4c ("app/testpmd: fix hex string parser support for flow API") Signed-off-by: David Marchand --- app/test-pmd/cmdline_flow.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index a8140eda92..ce57e409df 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -7706,9 +7706,5 @@ parse_hex_string(const char *src, uint8_t *dst, uint32_t *size) uint32_t left; - /* Check input parameters */ - if ((src == NULL) || - (dst == NULL) || - (size == NULL) || - (*size == 0)) + if (*size == 0) return -1; -- 2.34.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-06-09 12:34:30.252371780 +0100 +++ 0020-app-testpmd-remove-useless-pointer-checks.patch 2022-06-09 12:34:29.673980518 +0100 @@ -1 +1 @@ -From 2d8699ebb2a0638e8ae18fc0a83c56f984d0b270 Mon Sep 17 00:00:00 2001 +From f84770f8fcc62e7a3e2e2c8c32dff99e0a2c2b31 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 2d8699ebb2a0638e8ae18fc0a83c56f984d0b270 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index fc4a6d9cca..e3269e278d 100644 +index a8140eda92..ce57e409df 100644 @@ -22 +23 @@ -@@ -9339,9 +9339,5 @@ parse_hex_string(const char *src, uint8_t *dst, uint32_t *size) +@@ -7706,9 +7706,5 @@ parse_hex_string(const char *src, uint8_t *dst, uint32_t *size)