From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3F98A0555 for ; Thu, 9 Jun 2022 13:38:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BAF5F427E9; Thu, 9 Jun 2022 13:38:04 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 05CBF40220 for ; Thu, 9 Jun 2022 13:38:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654774682; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iOGjWXutuyW6qg3V6TsssP30YFO4aXdF6r+DU5eYlRQ=; b=fiTWCPMVU4L1g6MTC/P+N50hdoOtAJI29zXswXXbJrtxBd3rdgAZH6v/1kNMfB4jslYfRf MZcUAwhXtBIk0c4haDUy9r8Ynuoe2E/aCE6fKGq2NZobt2oSdccj9ED4SE8zFN1IohOJFN hA3yIevbF7siLBGhtVhV5dXhC4emHL0= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-349-U9YKjnQLO_KCejev01ExxQ-1; Thu, 09 Jun 2022 07:37:59 -0400 X-MC-Unique: U9YKjnQLO_KCejev01ExxQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0992038041D6; Thu, 9 Jun 2022 11:37:59 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.195.82]) by smtp.corp.redhat.com (Postfix) with ESMTP id D1D9818EA3; Thu, 9 Jun 2022 11:37:57 +0000 (UTC) From: Kevin Traynor To: "Min Hu (Connor)" Cc: Thomas Monjalon , Ferruh Yigit , dpdk stable Subject: patch 'ethdev: fix port state when stop' has been queued to stable release 21.11.2 Date: Thu, 9 Jun 2022 12:36:22 +0100 Message-Id: <20220609113701.386938-35-ktraynor@redhat.com> In-Reply-To: <20220609113701.386938-1-ktraynor@redhat.com> References: <20220609113701.386938-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/13/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/b6db13dcd97679cfa54eecff1328dabcdff4b475 Thanks. Kevin --- >From b6db13dcd97679cfa54eecff1328dabcdff4b475 Mon Sep 17 00:00:00 2001 From: "Min Hu (Connor)" Date: Tue, 3 May 2022 18:02:17 +0800 Subject: [PATCH] ethdev: fix port state when stop [ upstream commit 74b74269978c2790bc49238029e00b7c6e81c450 ] Currently, 'dev_started' is always set to be 0 when dev stop, whether it succeeded or failed. This is unreasonable and this patch fixed it. Fixes: 62024eb82756 ("ethdev: change stop operation callback to return int") Signed-off-by: Min Hu (Connor) Acked-by: Thomas Monjalon Acked-by: Ferruh Yigit --- lib/ethdev/rte_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index 1704e852b5..98f3f03885 100644 --- a/lib/ethdev/rte_ethdev.c +++ b/lib/ethdev/rte_ethdev.c @@ -1891,6 +1891,7 @@ rte_eth_dev_stop(uint16_t port_id) eth_dev_fp_ops_reset(rte_eth_fp_ops + port_id); - dev->data->dev_started = 0; ret = (*dev->dev_ops->dev_stop)(dev); + if (ret == 0) + dev->data->dev_started = 0; rte_ethdev_trace_stop(port_id, ret); -- 2.34.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-06-09 12:34:30.605857631 +0100 +++ 0035-ethdev-fix-port-state-when-stop.patch 2022-06-09 12:34:29.739980630 +0100 @@ -1 +1 @@ -From 74b74269978c2790bc49238029e00b7c6e81c450 Mon Sep 17 00:00:00 2001 +From b6db13dcd97679cfa54eecff1328dabcdff4b475 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 74b74269978c2790bc49238029e00b7c6e81c450 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index a175867651..fe64f8d39d 100644 +index 1704e852b5..98f3f03885 100644 @@ -23 +24 @@ -@@ -1534,6 +1534,7 @@ rte_eth_dev_stop(uint16_t port_id) +@@ -1891,6 +1891,7 @@ rte_eth_dev_stop(uint16_t port_id)