From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC8B8A0555 for ; Thu, 9 Jun 2022 13:38:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6D0640220; Thu, 9 Jun 2022 13:38:17 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 00C6240220 for ; Thu, 9 Jun 2022 13:38:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654774695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/MhkgklOH0YVqIr8xVfDE4S/rXUWHZIIFpPe9V0xL7w=; b=d7v2rDhT+1NifQ2PbWeqZQtI8XrRx1IkoYSrUHAQrAc2avhc4I2D9h9hBG04QTku1ZRRax JugdiwKjVuonoqUW9UYXhCUuUSueozmN9m8gkDdZl/8JH4tl3NuT0+j0tL+4TfZD1ZTWhT sHKK2axPECnjORvg7s+SWpMjWbHlkEg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-655-dATZkiumPFunDc6iCYLMNQ-1; Thu, 09 Jun 2022 07:38:12 -0400 X-MC-Unique: dATZkiumPFunDc6iCYLMNQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5767F1DC2424; Thu, 9 Jun 2022 11:38:12 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.195.82]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8C3201730C; Thu, 9 Jun 2022 11:38:11 +0000 (UTC) From: Kevin Traynor To: "Min Hu (Connor)" Cc: Andrew Rybchenko , dpdk stable Subject: patch 'ethdev: fix port close in secondary process' has been queued to stable release 21.11.2 Date: Thu, 9 Jun 2022 12:36:32 +0100 Message-Id: <20220609113701.386938-45-ktraynor@redhat.com> In-Reply-To: <20220609113701.386938-1-ktraynor@redhat.com> References: <20220609113701.386938-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/13/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/7c2df6be1edcc59f8e969d37f602c49cda793bc6 Thanks. Kevin --- >From 7c2df6be1edcc59f8e969d37f602c49cda793bc6 Mon Sep 17 00:00:00 2001 From: "Min Hu (Connor)" Date: Wed, 1 Jun 2022 11:15:13 +0800 Subject: [PATCH] ethdev: fix port close in secondary process [ upstream commit ea6101a8e483f3b6ec505c91b7e72ab1628dab1f ] Secondary process needs to close device to release process private resources. But secondary process should not be obliged to wait for device stop before closing ethdev. Fixes: febc855b358e ("ethdev: forbid closing started device") Signed-off-by: Min Hu (Connor) Reviewed-by: Andrew Rybchenko --- lib/ethdev/rte_ethdev.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index 98f3f03885..62e67f006d 100644 --- a/lib/ethdev/rte_ethdev.c +++ b/lib/ethdev/rte_ethdev.c @@ -1933,5 +1933,11 @@ rte_eth_dev_close(uint16_t port_id) dev = &rte_eth_devices[port_id]; - if (dev->data->dev_started) { + /* + * Secondary process needs to close device to release process private + * resources. But secondary process should not be obliged to wait + * for device stop before closing ethdev. + */ + if (rte_eal_process_type() == RTE_PROC_PRIMARY && + dev->data->dev_started) { RTE_ETHDEV_LOG(ERR, "Cannot close started device (port %u)\n", port_id); -- 2.34.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-06-09 12:34:30.815526507 +0100 +++ 0045-ethdev-fix-port-close-in-secondary-process.patch 2022-06-09 12:34:29.757980661 +0100 @@ -1 +1 @@ -From ea6101a8e483f3b6ec505c91b7e72ab1628dab1f Mon Sep 17 00:00:00 2001 +From 7c2df6be1edcc59f8e969d37f602c49cda793bc6 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ea6101a8e483f3b6ec505c91b7e72ab1628dab1f ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 46c088dc88..b9c5dea09f 100644 +index 98f3f03885..62e67f006d 100644 @@ -23 +24 @@ -@@ -1577,5 +1577,11 @@ rte_eth_dev_close(uint16_t port_id) +@@ -1933,5 +1933,11 @@ rte_eth_dev_close(uint16_t port_id)