From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F847A0555 for ; Thu, 9 Jun 2022 13:38:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A7B940220; Thu, 9 Jun 2022 13:38:20 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 7A0FC427EC for ; Thu, 9 Jun 2022 13:38:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654774698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l3DUIrgFmbqr40Lc4vFOvzco8xXKa4rLl3Aw/MnBbdE=; b=EsLD/K8HovtVKVaqzQ3AX7L0NSdhFfE4Ktq5ic1TuJWJBI2mRFVHgjrYDSHxINoIhuEo9/ grN9z9C4CMz35mD6w7EsuYjkINUot2iahP8SGaSq78YPA6GNgI2kDz0yqMxgj9lZrabDAj I7KkCXgW47F3Zf1Lodq7GNpgLCHClQ0= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-221-NMPnih7jOPeSST3EPKV0EA-1; Thu, 09 Jun 2022 07:38:13 -0400 X-MC-Unique: NMPnih7jOPeSST3EPKV0EA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 845EE3803906; Thu, 9 Jun 2022 11:38:13 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.195.82]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9B88E1730C; Thu, 9 Jun 2022 11:38:12 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: Ajit Khaparde , dpdk stable Subject: patch 'net/bnxt: fix compatibility with some old firmwares' has been queued to stable release 21.11.2 Date: Thu, 9 Jun 2022 12:36:33 +0100 Message-Id: <20220609113701.386938-46-ktraynor@redhat.com> In-Reply-To: <20220609113701.386938-1-ktraynor@redhat.com> References: <20220609113701.386938-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/13/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/df8b0db584a99a49fe422549b03d1c5f20c802d9 Thanks. Kevin --- >From df8b0db584a99a49fe422549b03d1c5f20c802d9 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Fri, 18 Mar 2022 16:03:31 +0100 Subject: [PATCH] net/bnxt: fix compatibility with some old firmwares [ upstream commit a43d0129579034af06314b6603d92a866d809eeb ] This reverts commit 3972281f47b2cc0cf844698885f0e6b4228c0975. Reported by Red Hat QE: with older firmware versions (at least versions 20.6.112.0 and 20.6.143.0), initialisation never succeeds following this change. Revert it for now, waiting for a more complete fix. Fixes: 3972281f47b2 ("net/bnxt: fix device readiness check") Signed-off-by: David Marchand Acked-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 7f2ac2c72a..6e87242992 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -1245,9 +1245,4 @@ int bnxt_hwrm_ver_get(struct bnxt *bp, uint32_t timeout) HWRM_CHECK_RESULT(); - if (resp->flags & HWRM_VER_GET_OUTPUT_FLAGS_DEV_NOT_RDY) { - rc = -EAGAIN; - goto error; - } - PMD_DRV_LOG(INFO, "%d.%d.%d:%d.%d.%d.%d\n", resp->hwrm_intf_maj_8b, resp->hwrm_intf_min_8b, @@ -6150,8 +6145,4 @@ int bnxt_hwrm_poll_ver_get(struct bnxt *bp) HWRM_CHECK_RESULT_SILENT(); - - if (resp->flags & HWRM_VER_GET_OUTPUT_FLAGS_DEV_NOT_RDY) - rc = -EAGAIN; - HWRM_UNLOCK(); -- 2.34.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-06-09 12:34:30.838182444 +0100 +++ 0046-net-bnxt-fix-compatibility-with-some-old-firmwares.patch 2022-06-09 12:34:29.761980668 +0100 @@ -1 +1 @@ -From a43d0129579034af06314b6603d92a866d809eeb Mon Sep 17 00:00:00 2001 +From df8b0db584a99a49fe422549b03d1c5f20c802d9 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit a43d0129579034af06314b6603d92a866d809eeb ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index 6e4753c508..9eb8b8d56d 100644 +index 7f2ac2c72a..6e87242992 100644 @@ -26 +27 @@ -@@ -1250,9 +1250,4 @@ int bnxt_hwrm_ver_get(struct bnxt *bp, uint32_t timeout) +@@ -1245,9 +1245,4 @@ int bnxt_hwrm_ver_get(struct bnxt *bp, uint32_t timeout) @@ -36 +37 @@ -@@ -6155,8 +6150,4 @@ int bnxt_hwrm_poll_ver_get(struct bnxt *bp) +@@ -6150,8 +6145,4 @@ int bnxt_hwrm_poll_ver_get(struct bnxt *bp)