From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76371A054A for ; Wed, 15 Jun 2022 12:14:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6CD334282C; Wed, 15 Jun 2022 12:14:43 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2098.outbound.protection.outlook.com [40.107.93.98]) by mails.dpdk.org (Postfix) with ESMTP id 3C9D540040; Wed, 15 Jun 2022 12:14:41 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U3OPX2bQIsw/+S+19vA4ourknrXGjAtHB0F0Yb199zzqbWdgKYXORwS8X9wQ5Wj6CZKOILLGXTQ59euG1xQmV4nyPC5Nt6sdaozi76+YHo3fIYcODbr6wpVhhCMKIPe/fR1Hgggy/oKZJiy6xj8RhNk8Zvj2QaCzhgktTKvpoCi7kAYMr1uW5nk80fRUBxs4FZK4P8VxvDXhY+DmhE6k5bJMASYvp8yiW3d86XdIKMwH87RvxUdoMhS9EmAQv6Eh+zpPk1x/gQjQj0OMZmrDvnfn1O9PQacPBvDE9BRF8vLD/M6XeEqATMbegHLpXSVZ2q2nOKoUXESFoHsKJ8xIMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6Lsnp+syeQcoPS2wIydGJ6uefEaUr+yifR+RZxeLiO8=; b=W9OzqKwCoetL0SRtX0Z5PpumnlydTLnoQBZ/gj4G1iK5xDzpJPzZV3wnNgQOLQ4aTmgguCaPMR69CQYm9OBBnydXQLzH1L7nwA+D+2aT6bRd+f2UFUp4nahwGYjPVudp5BzBB4jO3EDO/eTVoNa1vDiSekK9S3BuZETBQKG0ou8Nb1iE/a5Y0svfULpCjd+bWhkjMJsH0SHLaZqDio6K8nP4KPPNn+c2S2bRDdxrEyEJCEdRWartwZlUwqzJKDipzCcd/Qj/R1D8VQt+Ly1N27YkdzlcY9WAB6qmb6xSfrEwJk0mLnt7gZGSDTWOh4PnF97AtauhiOUz7QInHpyLtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6Lsnp+syeQcoPS2wIydGJ6uefEaUr+yifR+RZxeLiO8=; b=VkorzL+2+qZEaxMHWWMWP9dY3hKKsOu1iTTvPxu4a3dC95IVY/q1WK0/JS7XbBj+eG+vDR/oEk8VfTX8/CEk6ODtdpyoRnngZSaMMHxlhzeKtW4ejpFGGhcozuilUR/GeeBr5hR3Cn6Zu18UDCfb1LWy7nJ9DuJHcNRO7rCtBXk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from DM5PR1301MB1994.namprd13.prod.outlook.com (2603:10b6:4:2d::36) by SA1PR13MB5490.namprd13.prod.outlook.com (2603:10b6:806:231::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.11; Wed, 15 Jun 2022 10:14:39 +0000 Received: from DM5PR1301MB1994.namprd13.prod.outlook.com ([fe80::f58c:7e18:b902:e23]) by DM5PR1301MB1994.namprd13.prod.outlook.com ([fe80::f58c:7e18:b902:e23%6]) with mapi id 15.20.5353.005; Wed, 15 Jun 2022 10:14:39 +0000 From: Peng Zhang To: dev@dpdk.org Cc: niklas.soderlund@corigine.com, Peng Zhang , stable@dpdk.org, Chaoyong He Subject: [PATCH v2] net/nfp: initialize the flbufsz Date: Wed, 15 Jun 2022 12:14:17 +0200 Message-Id: <20220615101417.3139606-1-peng.zhang@corigine.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220614144737.2646823-1-peng.zhang@corigine.com> References: <20220614144737.2646823-1-peng.zhang@corigine.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: LO4P123CA0126.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:192::23) To DM5PR1301MB1994.namprd13.prod.outlook.com (2603:10b6:4:2d::36) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8344204d-b20c-4135-0a27-08da4eb7db1f X-MS-TrafficTypeDiagnostic: SA1PR13MB5490:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XnbhndbUoBw8TPClb3XtR/kKnw4ME0YHFuxQamE9wnkfwM6GfVHdUnxHubbL/f5V6aQ28E9cZu9UNha1S6je/h6xhQah7IBd+hT+ytgnPhoi5+yWwBzH8gxOHkE9OMndLCSX3d2B/dwR82u8bL1GffM04P9FtRgrvhwqZoFqncqV7IB8GYF1c/cawtjSF0phrwZqy+t6O5qqBbRG/LqRaHePyECfT5MZcHRJJDo8PySVJdbakww16pN1CFDZhwFdkZzhrGutp8syhU4vCkvTxOznBDSBh7tc9bd+uatRTJEymkS6n77goePwd+JxHOiPx/R6ohswwD3REpt5hAeFKIwJYmMc1zc8MpSK2PquOYMVvCLJ21PA8ne6JOZMuVzzBX7R/hJQM3HGAvX6KaL7Qhg9MRx1CMGScclvHJJCCO6cTS+KyGWbgp+/rtjDjVCpNYfzoW9gY18+lcVT8aofJsPrgcf+2E01KyYbWX/2JrtcHoO7DeXT7jVbXLrtaPrqpXBAfNNvD4C/LBZ8f2ZuIEtaNWF2/PFlBX6Pr/UAlGHsZI/A6WoK17AQT4nkA8yeJPHlxbVkRexs80r+sYjT+hc9hJUnNaCFClo6sm8M5pkNruB63NlZbTz/OadVkU/4DgNrbKsH2LHBBJQvsSYNfVyHAxHXlnq5TXioKS7NdLq23WLpidBkCJO9kDMpbyQ+Nh4Zxdg9x/HN3mLHH/cFCQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1301MB1994.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(346002)(136003)(39830400003)(366004)(396003)(36756003)(2906002)(316002)(8936002)(6512007)(54906003)(52116002)(186003)(5660300002)(26005)(6506007)(38100700002)(38350700002)(86362001)(44832011)(66556008)(4326008)(508600001)(41300700001)(450100002)(2616005)(6666004)(107886003)(66476007)(8676002)(6916009)(6486002)(1076003)(66946007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YbiiEXuoIKmz5eQkhHu+yGMQ1oH6N9PkbcgW/SxRNh8dciqhm7TPSn/qntHI?= =?us-ascii?Q?mMdZQrb51AJ+6fZ1e6Aht24iBnBnIKTUJhuoKE01mdHFP2nOeA7pStDP00Or?= =?us-ascii?Q?5r8BQjoKRDDz+4dt4UPpMm/rTZeNmayG6jaUjnGdDuV+QRjMPjWwRNFDpNoz?= =?us-ascii?Q?VDZPNPALhBcV4fqf7qsNjqFr9NjK6la9ZoQHL5FHTmA3xiJh5rTqB/4L7BhF?= =?us-ascii?Q?ekVQkpj4hf1FxxnhfpWWnxxMXuktJ3vVThVzaxm0PaDepNsQkmX8G0MDtucP?= =?us-ascii?Q?q0Mnr8jB/CMb3P6ccShm0LXE7OZAvAqBDkCkyAZG3JJEFGsmC8sGFW0A4plY?= =?us-ascii?Q?Mo1jGEKwG37sXNUJLDVxXn7hpgRslVu/U57xZ8ESaKWRxYLOWjy+uwkGLIil?= =?us-ascii?Q?VdaujuRI3k9VBSBga8M3yzpHH3JnE70xMjQjYOy7VLzhzaOpHtBpB1BWfsN3?= =?us-ascii?Q?Ns2e8H28EBO8QRtVkJlA86Vug/LWA37iqvtcfvYer29hua0ucp/Im4Y67BY5?= =?us-ascii?Q?QBX7Hm2sdCyQJzo0KB+J/7uENRI2pTCecmi2aINZvZU7uCbbMi+lVUaWu5Hu?= =?us-ascii?Q?VpyNN9jUwgQgXCdAxX1pzT0VPmTeHxwqjSuR3nAaDTcaG+2+LiKY0k0SKsv5?= =?us-ascii?Q?+lyvzul8WrAy5w8gxU4hfCD6agXnyuYDoXAop8aZIiDXMj990D7wtlj3/duy?= =?us-ascii?Q?lKgBgh+G+Autkxcbefpxdp9tCecJWnIQ61+uOqO68l/4dpAkLJM+m+F0jxe9?= =?us-ascii?Q?gfY9/F0FtjGjqvhpGvnlZFK3zhjkToK3/WlAXBOaoDl2FXDUv5UDpN9fyhPj?= =?us-ascii?Q?PiVpv1n/feZMK/RLlwPyEimHhN6NRa+PzE8RWNxOgbr1cChJUIXLMJTLJ1tv?= =?us-ascii?Q?A5heSeI8qIXnFT4K8z4GXlIbPBTzneWBQH8pbw808yBXR/+Tr8drQAvbudy1?= =?us-ascii?Q?/Lbn6q3d23wPoAxc3ZpvIOyGsIbvmWpgpi5anF2jqotUTOwfY5A3YzYa1cx6?= =?us-ascii?Q?/VnQwoXpZRvUV9fMq/5YI64fl3fRukZEACjsLM61mkh3umLCgLnf3QZzyixk?= =?us-ascii?Q?DqVl0DjQKSQm2LrXVNr+RpOsPuUvfUwyBUP2KdYHfqgZqG28hYDdQNffvmfZ?= =?us-ascii?Q?3CQw+pxVMEi9eBEJcsi1YtM4g2EzsgVCq7UDA5ENxhG+B1eNUvFsgNqIU+V7?= =?us-ascii?Q?kKygA2xjcjsAGG8Kh/jSKbkznZgDSrjeHNJy8gY07Qz+O8WyJyK3cnV9ul3c?= =?us-ascii?Q?oK75chb/KUYoCCEdEBshC61KhQNN4+FinzzO1OWcnHyWdt0GFCSlx2E/a555?= =?us-ascii?Q?Au7TwQ9CEOWYlgIfKEW+GU5MW7dGI8nGKZxrIYXo/akjCt6qYbpG/CGVCay7?= =?us-ascii?Q?sTKStjbppFq+ZYLx+0OzvYSU1MdQ4XaRJUvkkRgzY3umNL8iBho0eAt6xDHn?= =?us-ascii?Q?pvO4KtjICRSnf2lKfOMCrvsmAjfCND6teOPuV+/0p7Lzeahg8xgZ2srr6TNV?= =?us-ascii?Q?hbXTCMJtEeMD1By92cZlZxLfOF7SeYX5ivRx9XbImkIB5Em62pRfe6kdkn/r?= =?us-ascii?Q?zYRBpD7/BN1hzOjP8j4MUcJTbaZPWxun8NmMiV3EGnbUSa4ZeIHveckKLNx9?= =?us-ascii?Q?JUq/Vv5QEBCFH70AJqyA4zkE4Ww9hIRdV5jKwsucqQsAPHo6h2aMeQDsC0/Z?= =?us-ascii?Q?HPfglLp6YBsLDlW/MtIQfaaXj4pD+vDA84mYb7vJvwmt9LmfQGu0Fyj38mkc?= =?us-ascii?Q?tDTBLIRIgiz8YOFaBGuzekmVl7qHQ3c=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8344204d-b20c-4135-0a27-08da4eb7db1f X-MS-Exchange-CrossTenant-AuthSource: DM5PR1301MB1994.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2022 10:14:39.1853 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pOVmeI3HdsgIEqoR664XGcO0UEP95h7dezmWN/jo91MPWLXdTZi1hy3ya0/GsBsqbclcDVzlFoxJZkiAz7sp3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR13MB5490 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org When the testpmd start-up, it will check MTU range, if MTU > flubfsz, it will lead testpmd start fail. Because the hw->flbufsz doesn't have the initialized value, so it will lead the bug. Fixes: 97a30c4d4c7b ("net/nfp: make sure MTU is never larger than mbuf size") Cc: stable@dpdk.org Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He --- drivers/net/nfp/nfp_ethdev.c | 1 + drivers/net/nfp/nfp_ethdev_vf.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c index 9166f65da3..1a9f7581a7 100644 --- a/drivers/net/nfp/nfp_ethdev.c +++ b/drivers/net/nfp/nfp_ethdev.c @@ -502,6 +502,7 @@ nfp_net_init(struct rte_eth_dev *eth_dev) hw->cap = nn_cfg_readl(hw, NFP_NET_CFG_CAP); hw->max_mtu = nn_cfg_readl(hw, NFP_NET_CFG_MAX_MTU); hw->mtu = RTE_ETHER_MTU; + hw->flbufsz = RTE_ETHER_MTU; /* VLAN insertion is incompatible with LSOv2 */ if (hw->cap & NFP_NET_CFG_CTRL_LSO2) diff --git a/drivers/net/nfp/nfp_ethdev_vf.c b/drivers/net/nfp/nfp_ethdev_vf.c index 0034d68ea6..0781f34764 100644 --- a/drivers/net/nfp/nfp_ethdev_vf.c +++ b/drivers/net/nfp/nfp_ethdev_vf.c @@ -369,6 +369,7 @@ nfp_netvf_init(struct rte_eth_dev *eth_dev) hw->cap = nn_cfg_readl(hw, NFP_NET_CFG_CAP); hw->max_mtu = nn_cfg_readl(hw, NFP_NET_CFG_MAX_MTU); hw->mtu = RTE_ETHER_MTU; + hw->flbufsz = RTE_ETHER_MTU; /* VLAN insertion is incompatible with LSOv2 */ if (hw->cap & NFP_NET_CFG_CTRL_LSO2) -- 2.27.0