From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E0A9A0545 for ; Mon, 20 Jun 2022 11:48:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9332340150; Mon, 20 Jun 2022 11:48:09 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C8F5340150 for ; Mon, 20 Jun 2022 11:48:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655718485; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SMfKXB3oU5nCCl4rpOctYB9bXOxK6AyUZJx/ku5xrkQ=; b=ZNy4p/3F0feFBWAO8RtN1C6g+GTX1v5+cOG3FWrZE1WBUMngHe4USDn/lyw9bhiT3Jyfhp FEb9DbUtS8YWtm8M5Xytc0wpEdfQnbhiflsr6mfou+ZzTK+hdfVdkXGdoZAkisDAi75OOe 7luID7pH68Nxu9eYgqq3ggnnEElsEtI= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-398-3oIaGejmMzS6aCKMdS0rFQ-1; Mon, 20 Jun 2022 05:48:04 -0400 X-MC-Unique: 3oIaGejmMzS6aCKMdS0rFQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D7F811C04B41; Mon, 20 Jun 2022 09:48:03 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.194.217]) by smtp.corp.redhat.com (Postfix) with ESMTP id E7ABD400F3FF; Mon, 20 Jun 2022 09:48:02 +0000 (UTC) From: Kevin Traynor To: Kevin Laatz Cc: Conor Walsh , dpdk stable Subject: patch 'dma/idxd: fix error code for PCI device commands' has been queued to stable release 21.11.2 Date: Mon, 20 Jun 2022 10:47:38 +0100 Message-Id: <20220620094752.1027299-5-ktraynor@redhat.com> In-Reply-To: <20220620094752.1027299-1-ktraynor@redhat.com> References: <20220620094752.1027299-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/23/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/8bb9213bbceaef634a7f54cb5775211efdbbaff5 Thanks. Kevin --- >From 8bb9213bbceaef634a7f54cb5775211efdbbaff5 Mon Sep 17 00:00:00 2001 From: Kevin Laatz Date: Fri, 8 Apr 2022 15:16:55 +0100 Subject: [PATCH] dma/idxd: fix error code for PCI device commands [ upstream commit f217dbff20603b51a51e226be77593ea06122ab5 ] When sending a command to an idxd device via PCI BAR, the response from HW is checked to ensure it was successful. The response was incorrectly being negated before being returned by the function, meaning error codes cannot be checked against the HW specification. This patch fixes the return values of the function by removing the negation. Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe") Fixes: 452c1916b0db ("dma/idxd: fix truncated error code in status check") Signed-off-by: Kevin Laatz Acked-by: Conor Walsh --- drivers/dma/idxd/idxd_pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/idxd/idxd_pci.c b/drivers/dma/idxd/idxd_pci.c index 9ca1ec64e9..65c6bbf4c1 100644 --- a/drivers/dma/idxd/idxd_pci.c +++ b/drivers/dma/idxd/idxd_pci.c @@ -39,5 +39,5 @@ idxd_pci_dev_command(struct idxd_dmadev *idxd, enum rte_idxd_cmds command) rte_spinlock_unlock(&idxd->u.pci->lk); err_code &= CMDSTATUS_ERR_MASK; - return -err_code; + return err_code; } } while (err_code & CMDSTATUS_ACTIVE_MASK); @@ -45,5 +45,5 @@ idxd_pci_dev_command(struct idxd_dmadev *idxd, enum rte_idxd_cmds command) err_code &= CMDSTATUS_ERR_MASK; - return -err_code; + return err_code; } -- 2.34.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-06-20 10:46:27.898144895 +0100 +++ 0005-dma-idxd-fix-error-code-for-PCI-device-commands.patch 2022-06-20 10:46:27.766146797 +0100 @@ -1 +1 @@ -From f217dbff20603b51a51e226be77593ea06122ab5 Mon Sep 17 00:00:00 2001 +From 8bb9213bbceaef634a7f54cb5775211efdbbaff5 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit f217dbff20603b51a51e226be77593ea06122ab5 ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org