From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5914A0545 for ; Mon, 20 Jun 2022 11:48:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B130C427F3; Mon, 20 Jun 2022 11:48:09 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4CF2741132 for ; Mon, 20 Jun 2022 11:48:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655718486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BliO/NX/3aBwOHlgKCLyGllm5j3QzXTYd0zb3SoSJ8g=; b=LB3eg8XxQWYOKRMiHCa1EA6hdcD65Rl86nv8fCtxXVNZ6pMO4v4qyzfG8R5Wj9pPHXoeNf l38Kb8NyfFJpjrJG9iyGpKnN1VvYc8T1wI9CibTxyEf5trhVZ+L1qiS6WbjZQjOuzvGeW5 d/sTgLWOP62VQ/FO26MkH8yG6RMHes4= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-223-C3yhLb37OHedjD3ziDpyww-1; Mon, 20 Jun 2022 05:48:05 -0400 X-MC-Unique: C3yhLb37OHedjD3ziDpyww-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 351661C04B71; Mon, 20 Jun 2022 09:48:05 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.194.217]) by smtp.corp.redhat.com (Postfix) with ESMTP id 44780400F3FF; Mon, 20 Jun 2022 09:48:04 +0000 (UTC) From: Kevin Traynor To: Raja Zidane Cc: Matan Azrad , dpdk stable Subject: patch 'app/testpmd: fix packet segment allocation' has been queued to stable release 21.11.2 Date: Mon, 20 Jun 2022 10:47:39 +0100 Message-Id: <20220620094752.1027299-6-ktraynor@redhat.com> In-Reply-To: <20220620094752.1027299-1-ktraynor@redhat.com> References: <20220620094752.1027299-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/23/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/c18ad5cc3eec4b56421f4bd200aa1ba819044e9c Thanks. Kevin --- >From c18ad5cc3eec4b56421f4bd200aa1ba819044e9c Mon Sep 17 00:00:00 2001 From: Raja Zidane Date: Thu, 2 Jun 2022 15:59:47 +0300 Subject: [PATCH] app/testpmd: fix packet segment allocation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 1108c33e743f8be81e765165c8b3cf27d57a7220 ] When --mbuf-size cmdline parameter is specified, the segments to scatter packets on are allocated sequentially from these extra memory pools (the mbuf for the first segment is allocated from the first pool, the second one from the second pool, and so on, if segment number is greater then pool’s the mbuf for remaining segments will be allocated from the last valid pool). A bug in comparing segment index with mbuf index caused wrong mapping of one of the segments. Fix the comparison. Fixes: 2befc67ff679 ("app/testpmd: add extended Rx queue setup") Signed-off-by: Raja Zidane Acked-by: Matan Azrad --- app/test-pmd/testpmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index fa449183c1..1c415b0209 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2673,5 +2673,5 @@ rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id, * exceeding the pool index. */ - mp_n = (i > mbuf_data_size_n) ? mbuf_data_size_n - 1 : i; + mp_n = (i >= mbuf_data_size_n) ? mbuf_data_size_n - 1 : i; mpx = mbuf_pool_find(socket_id, mp_n); /* Handle zero as mbuf data buffer size. */ -- 2.34.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-06-20 10:46:27.917728197 +0100 +++ 0006-app-testpmd-fix-packet-segment-allocation.patch 2022-06-20 10:46:27.771146807 +0100 @@ -1 +1 @@ -From 1108c33e743f8be81e765165c8b3cf27d57a7220 Mon Sep 17 00:00:00 2001 +From c18ad5cc3eec4b56421f4bd200aa1ba819044e9c Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit 1108c33e743f8be81e765165c8b3cf27d57a7220 ] + @@ -21 +22,0 @@ -Cc: stable@dpdk.org @@ -30 +31 @@ -index fc1b64b60d..4d51eb9576 100644 +index fa449183c1..1c415b0209 100644 @@ -33 +34 @@ -@@ -2672,5 +2672,5 @@ rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id, +@@ -2673,5 +2673,5 @@ rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id,