From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF640A0543 for ; Tue, 21 Jun 2022 10:12:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6198342BAC; Tue, 21 Jun 2022 10:12:14 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2073.outbound.protection.outlook.com [40.107.243.73]) by mails.dpdk.org (Postfix) with ESMTP id CEA9342B91 for ; Tue, 21 Jun 2022 10:12:12 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lizuBd9iFOiQ1wUfsoN9ay41hapKeaL48QTqXStlzvF31W4Gz/ZPiobSMSDwZ5QSz2TlfebxuaBU8y1kUuqDtyuq1JiaKTPtt18MrGSkJFRFr1lHKMb+u3vFbjebMZBvhqaCAhzy+4YDxN0bm1dt/tRjyYXIgjASN3+FS9MJvr3Z8cvpJGdNbFWGwIhQ4jSYGxEWrN8Osz6EzOJN01uy2iP6sPFJZ8ILrJIFc2YI3wQu2ve140wtgwpCnkVB9Sb7Gi/AC2wgIam1nEQ1fgtiw+TlrX0V0ESrz21xGeoxrdSiW0yLRSKpGJ+ebuGKa9bKQulH2us8tZtzLEvrvTW7VQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2Uoc0CXxhhiu354YgkwtWRdBM5+Oj0iYyeJDORl1eJw=; b=k6MwJqxioBT1AtPQ6EOrsG/j1X9y5hB3jFKaARSvC3qcfU4kPy3YSXtsk5IDOv6XMHZ9NDP5fAhLP5oh1e6quRIzTDRSG4vLZ7r/gI9oQFp+lBthK1lqk4bWI1k9UEmKok95+ibcwaN+XeqhnAC9P7HSBAxagAIASb0WWFOpdlFlZ5vjvxDHHgumstRuzbhVeFn4OXOkW1Jdn7cdJDfUU3nt7eDjh1ONgj0UFvS8nokLIg+McRcFljVYLmkSc0LRBzqwq4ZVurGiX75etcQLfmxDLEqbXWCYioTX0nzAQ2Y+sQMqnVLLCyOSR6HqXUX3ruzl9CnFc02eQRcwsAgvMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.236) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2Uoc0CXxhhiu354YgkwtWRdBM5+Oj0iYyeJDORl1eJw=; b=PmA7Jb89kOS0Wm49haI75EiIh0cPzW20E+ExGGycTumaB0IQgSLuWnnrIiZtp8O65t1Pkrs4CHWfGIO4ibBcNSzZcgCpVgDAxBNWXuMD/tey4SX5UyZku5mHFNZpmz7UiflbiZg5dUnzzTBpiwlYcXEc/QjsADfAucgpeMDo2DaS0jA/cdLEyUtJ328kK3Qm4w0XH/fHahbB55aE9Gy8Can7O1/LM7l83ML+KihRRfyWEpKHDDAirsqT8Y6bnIgi4GxlJWmc1mKTkmSaESvTak3ZUtrBAjqQBa5IUGmP5dYm968eTmlaW4UUVWhAYkIfvP2/RN27N7LDVUa/qkBkUA== Received: from BN1PR13CA0008.namprd13.prod.outlook.com (2603:10b6:408:e2::13) by BYAPR12MB4792.namprd12.prod.outlook.com (2603:10b6:a03:108::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.18; Tue, 21 Jun 2022 08:12:11 +0000 Received: from BN8NAM11FT068.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e2:cafe::d3) by BN1PR13CA0008.outlook.office365.com (2603:10b6:408:e2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15 via Frontend Transport; Tue, 21 Jun 2022 08:12:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.236) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.236 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.236; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (12.22.5.236) by BN8NAM11FT068.mail.protection.outlook.com (10.13.177.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5353.14 via Frontend Transport; Tue, 21 Jun 2022 08:12:10 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL109.nvidia.com (10.27.9.19) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Tue, 21 Jun 2022 08:12:02 +0000 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 21 Jun 2022 01:12:00 -0700 From: Xueming Li To: Ke Zhang CC: Qi Zhang , dpdk stable Subject: patch 'net/iavf: fix Rx queue interrupt setting' has been queued to stable release 20.11.6 Date: Tue, 21 Jun 2022 11:02:46 +0300 Message-ID: <20220621080301.2315720-101-xuemingl@nvidia.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220621080301.2315720-1-xuemingl@nvidia.com> References: <20220621080301.2315720-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c58c914e-2b06-410e-331c-08da535dbd89 X-MS-TrafficTypeDiagnostic: BYAPR12MB4792:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XUa12UT8770AvhWra2pGzKX/W0Xfld/7kPOIJTFMXqebzzlWs9Ksj/lrt4cnHkj4ZZSXURWvFrX0aWG8tywP6SKF5YwOe0rOh9QEj3Mw1Yf27zQuOJ0mBG16n5sros0rI5P7E4Bug8BpR2Rc0as1ezSeHnPv9U0ibjiioTc3i/E4Xy4dHYJIQ43MnuqZtqJzKlsOIjkyfdkVZ982e4kxq2PkJaOm7BnAUVudXAs5ic/8JOcQM4MHeaRw+gANXvU2KaoctBWhE/xvA+dtX2esKrGwLGc7bC+PbvWEanXNfe4+NeUkV+H/IcY/Hhb9QNsX79KacHcw7rQuLvkygHiDPJjMduxXUyVrRdlw6b7Nk/TXHeauQon7asLx80nniGT86Ac32EcMVtfMrwr32+pghFyQ74ma6j1sJXCaoUtWomzV3b3EIbNWS07VLl4SVdaW2oQCIo+X87Euoh2n2HUsFfy7TDcdEoC814LJajucHFYZ5tzVZqsPerbhqzSe3D1dRAM5jJUfYeRuxE855Ah/GGXATFArqQn/+hTFarNKhs6PAbg4Kbj94WACeWa+fkkG7/a0T1z9+qVZufYqRRJgzfykC79BrGzfz2+5GM3poDiRzcAFa30PPquPaBkiUeel4o7uGiUeEnaxlHykMy6/JxHepkaxKO9CiQPLy0IwjQncnZx1X+SwVh4QS0v8Md+AOI+gBtk9VTYRZRpIwzI0s7vCqQpLE92NzRSgfiKl08Bza8BQB+am4OiI3gR2O23j6Nf6lHvlnaR8jbSA6tzxblP3nuUv78/DGWueT47SmiGKQ9xlT3SbjVbFqDnmYYJQ2Y0r3Vg1OXb8UnzvfLJXLQA2w3sUf9C3r2YHTNUfBVY= X-Forefront-Antispam-Report: CIP:12.22.5.236; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230016)(4636009)(396003)(136003)(39860400002)(376002)(346002)(40470700004)(36840700001)(46966006)(83380400001)(47076005)(336012)(81166007)(426003)(40460700003)(82740400003)(6666004)(55016003)(186003)(36860700001)(40480700001)(1076003)(16526019)(82310400005)(7696005)(54906003)(6286002)(356005)(8936002)(36756003)(316002)(6916009)(26005)(53546011)(4326008)(2906002)(478600001)(966005)(41300700001)(70206006)(2616005)(5660300002)(8676002)(70586007)(86362001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2022 08:12:10.1577 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c58c914e-2b06-410e-331c-08da535dbd89 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.236]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT068.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB4792 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/23/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/789223ef41ebf4a8b9efecf516cb415f2bf48cf0 Thanks. Xueming Li --- >From 789223ef41ebf4a8b9efecf516cb415f2bf48cf0 Mon Sep 17 00:00:00 2001 From: Ke Zhang Date: Fri, 20 May 2022 03:00:23 +0000 Subject: [PATCH] net/iavf: fix Rx queue interrupt setting Cc: Xueming Li [ upstream commit a08f9cb698c3d4687765860e328dca727f7a516b ] For Rx-Queue Interrupt Setting, when VF Rx interrupt disable (INTENA=0), there are two ways to write back descriptor to host memory: 1) Set WB_ON_ITR bit 0 to Interrupt Dynamic Control Register: Completed descriptors are posted to host memory according to the internal descriptor cache policy (in other words when a full cache line is available for write-back). A internal descriptor size is 16 bytes or 32 bytes, a cache line size is 64 bytes or 128 bytes from datasheet : PCIe Global Config 2 - GLPCI_CNF2 (0x000BE004; RO) so the full cache line could contains 4 packets, it means Network card will send 4 packets to host when a full cache line is available. 2) Set WB_ON_ITR bit 1 to Interrupt Dynamic Control Register: Completed descriptors also trigger the ITR. Following ITR expiration, all leftover completed descriptors are posted to host memory. Network card will send packet to host even if only one descriptor is completed. Changing 1) to 2) to make sure VF send the packet to host even if there is only one Rx packet is ready in hardware. Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt") Signed-off-by: Ke Zhang Acked-by: Qi Zhang --- drivers/net/iavf/iavf_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index bbbd7e84a4..060b3e3707 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/iavf/iavf_ethdev.c @@ -1431,7 +1431,7 @@ iavf_dev_rx_queue_intr_disable(struct rte_eth_dev *dev, uint16_t queue_id) IAVF_WRITE_REG(hw, IAVF_VFINT_DYN_CTLN1(msix_intr - IAVF_RX_VEC_START), - 0); + IAVF_VFINT_DYN_CTLN1_WB_ON_ITR_MASK); IAVF_WRITE_FLUSH(hw); return 0; -- 2.35.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-06-21 15:37:53.696163186 +0800 +++ 0100-net-iavf-fix-Rx-queue-interrupt-setting.patch 2022-06-21 15:37:49.214451878 +0800 @@ -1 +1 @@ -From a08f9cb698c3d4687765860e328dca727f7a516b Mon Sep 17 00:00:00 2001 +From 789223ef41ebf4a8b9efecf516cb415f2bf48cf0 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit a08f9cb698c3d4687765860e328dca727f7a516b ] @@ -34 +36,0 @@ -Cc: stable@dpdk.org @@ -43 +45 @@ -index 315ab15aad..a74056f0f1 100644 +index bbbd7e84a4..060b3e3707 100644 @@ -46 +48 @@ -@@ -1925,7 +1925,7 @@ iavf_dev_rx_queue_intr_disable(struct rte_eth_dev *dev, uint16_t queue_id) +@@ -1431,7 +1431,7 @@ iavf_dev_rx_queue_intr_disable(struct rte_eth_dev *dev, uint16_t queue_id)