From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF97CA0543 for ; Tue, 21 Jun 2022 10:13:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EAA784281B; Tue, 21 Jun 2022 10:12:57 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2087.outbound.protection.outlook.com [40.107.101.87]) by mails.dpdk.org (Postfix) with ESMTP id 6A04C4281B for ; Tue, 21 Jun 2022 10:12:56 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hu2wnmQ6RdHRR5J8XK2kDFVsaMlOcAtv8f8Q7sA2vEkd8ffm4TqdinW3aTtfQsyiDybkDUr6rPL01Ot2SuBxJMUu7Ps4naoBNfz6fb9u4zcCwi0xpSDVaVHT5SqW3Yu+6Int9s6S1AYTCbK4SzSbDt56SnDsyay/5nshRZLLsoudrWGUVXQa15SsmGEks5IpQ2haw671GCknZ2jB9jV0NEWqTCFnCYtGjDTkFO7peRa9TWkEW4WiOyPvQHGzztccqnrNITI38VJEKgMIAIqCPkXyATWcShmTkNS88dKGaauTOopJ0e9ULb8hHrpvbEAis5Tio+CsXTfsljn6H9USDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ruaJDLJw6zhkVA2oxaMwHR8b/3dFfnRBF+9u+cOpLMs=; b=TUnlflzLZ7vdnXlMAwEEKh+Sg/mkmXtCb6l1+0KjhUHj5iwpuXUH6sAcxL53QoFnyQXX1ja6KwIjcumRCeR/J6MN+jxhiaPxXzc9z48Z7BIye7j0LVQOdf9NgvgF15d+3MBs6RVU9DbMXZ8uQjEJB/CPsHNGEH19AwVp75KhcQWVro2/rsnJv5FwaHJquE8W4b4dUNAmUHjLeEHLkomLGejIzb2lfMGTLJy8OyQBBWtz+/i5br9n+WZvSGQpigKE7Q25Jg8Wzq5VpDwMHsZiwEMRVeLBESC+j8J+LeC0hQqKnnAFRhCV2zzrKqJLocHCBcJfp5ERGHnATSZXE4VPmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.234) smtp.rcpttodomain=xilinx.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ruaJDLJw6zhkVA2oxaMwHR8b/3dFfnRBF+9u+cOpLMs=; b=ZBVOx0NKFQS5HUSRtTjlkbCzZOhG1S3lg0S7z3MFIVipq+6EJhwiQtXIhn1Da6PHEFL6LqHkBBeO01v6jj+Vav7YDVNpBui5wzwFTIvAUK52dikBUsm4RQw/z+t05k86Ce0eKc4dqygHDEO0Wex7iBr4AVrrle556CKxZLBq01EoRtksQPPhMqI+GoB1Te61DNljsyuBrx2ETh5eqzwFtvjW+6KvTl+Y8NA8GhazryOfT2yGo09Qxeh7l6w3zSWxQutN/QgPQ/hDoDj/uCc9/CVD/5HaTkk6fEXEXtKd//QI/2ZNqzitgD57sHaGY6AILVXnirxWxxfIOJt4a9guJA== Received: from BN6PR19CA0082.namprd19.prod.outlook.com (2603:10b6:404:133::20) by BN8PR12MB3217.namprd12.prod.outlook.com (2603:10b6:408:6e::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.20; Tue, 21 Jun 2022 08:12:54 +0000 Received: from BN8NAM11FT003.eop-nam11.prod.protection.outlook.com (2603:10b6:404:133:cafe::16) by BN6PR19CA0082.outlook.office365.com (2603:10b6:404:133::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.22 via Frontend Transport; Tue, 21 Jun 2022 08:12:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.234) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.234 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.234; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (12.22.5.234) by BN8NAM11FT003.mail.protection.outlook.com (10.13.177.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5353.14 via Frontend Transport; Tue, 21 Jun 2022 08:12:54 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL101.nvidia.com (10.27.9.10) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Tue, 21 Jun 2022 08:12:53 +0000 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 21 Jun 2022 01:12:51 -0700 From: Xueming Li To: Ke Zhang CC: Andrew Rybchenko , Ferruh Yigit , dpdk stable Subject: patch 'kni: use dedicated function to set random MAC address' has been queued to stable release 20.11.6 Date: Tue, 21 Jun 2022 11:02:56 +0300 Message-ID: <20220621080301.2315720-111-xuemingl@nvidia.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220621080301.2315720-1-xuemingl@nvidia.com> References: <20220621080301.2315720-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: de937754-bf75-4b53-c341-08da535dd7b4 X-MS-TrafficTypeDiagnostic: BN8PR12MB3217:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zcZ4qPnAEI+/c+EanIWBsV3GCDaMb/gGwUQ9bxOGuSd2kEv/jW3j5aTAyBiL/FyWhg1idWq3kWJobMdN1LINFDznQUbQf23/g/aKp4Zk5jMmSZqwTT/Ls0MQ4dyxSwctcPxRlFJ6Qd0u4zXhjgvnzeiryBRu1Z3G41AAeCAgxWEWROxyPU3BTa676EKvOVw+kMpk9/2Hmq33YrClhT0zhABB8+sSm7GoLBIUvdbH78FwNX3P12gZYUh8sfx2x9qkN0uiz6Wb2uRsOYwfJP6Z1bu5sgq6reL/zXrpxxusnZAVeVSP46bhExu0U8MRNvbGgMULtzRdBBCONNZx2tLdzWSk/pqoP4WNrv4mneTJZHugPa82wZtMimUa/KgnMUg/hg6H3l3kWU04K8TSA1UQOtATYQMtKsn8JfipDzk8+HNzmL/OP4cImujq7F9Z/VALMN3uOJia8pYhsSxgniUCR9pPI6jrG7FPwWF4q802V1cNvGW6lGMJY9d1Jt87tjBdEeEtVe6PG8vipXd51FIL2lTGVA1sFJkv2Dmjjb0eSJ2qiNQ8Gy22eYGyzOmd6+JPgdEajHhmaa0TJspDVc5+sgXaGade/JyitFN8JjbhUhpV6xqKDAW0liqOh2RNvLMlXUA9jR8xpIwTtmFSsRYz/1eYjR28pRLNu3ew8h46jC4/kOFv3MEGTTeWgm3JRXHX0mT0EuGj0AbBCPB01gLiau+aNf7FGFwR2SljcgW4CQ3997Obus0rR6jgNGWalG+c/hQRtopPzmx9jmHbOvt2y7aQ2XGWLZ1xGBMXqCJa8+hcK3Es8BSvF7Re6LS+MBHfqMrCd96PyoloSXkqeO+OLPjO9+81rhHVg8dXqftIxn0= X-Forefront-Antispam-Report: CIP:12.22.5.234; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230016)(4636009)(346002)(376002)(136003)(396003)(39860400002)(46966006)(40470700004)(36840700001)(40460700003)(36860700001)(86362001)(82310400005)(478600001)(2616005)(8936002)(356005)(82740400003)(2906002)(41300700001)(316002)(966005)(26005)(70206006)(426003)(54906003)(70586007)(1076003)(8676002)(40480700001)(47076005)(6916009)(336012)(4326008)(83380400001)(7696005)(6286002)(5660300002)(81166007)(36756003)(53546011)(55016003)(186003)(16526019)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2022 08:12:54.0639 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: de937754-bf75-4b53-c341-08da535dd7b4 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.234]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT003.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3217 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/23/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/628b8d88c48c3679daf1ae2e7a42933c5ad5401a Thanks. Xueming Li --- >From 628b8d88c48c3679daf1ae2e7a42933c5ad5401a Mon Sep 17 00:00:00 2001 From: Ke Zhang Date: Wed, 8 Jun 2022 15:11:16 +0300 Subject: [PATCH] kni: use dedicated function to set random MAC address MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Xueming Li [ upstream commit 2ee8c67ef9399759cb0d3f34b2c9fb6ea0ecc832 ] eth_hw_addr_random() sets address type correctly. eth_hw_addr_random() is available since Linux v3.4, so no compat is required. Also fix the warning: warning: passing argument 1 of ‘memcpy’ discards ‘const’ qualifier from pointer target type Variable dev_addr is done const intentionally in Linux v5.17 to prevent using it directly. Fixes: ea6b39b5b847 ("kni: remove ethtool support") Signed-off-by: Ke Zhang Signed-off-by: Andrew Rybchenko Acked-by: Ferruh Yigit --- kernel/linux/kni/kni_misc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/linux/kni/kni_misc.c b/kernel/linux/kni/kni_misc.c index d1f6f54aac..a6b51fc32f 100644 --- a/kernel/linux/kni/kni_misc.c +++ b/kernel/linux/kni/kni_misc.c @@ -407,8 +407,8 @@ kni_ioctl_create(struct net *net, uint32_t ioctl_num, if (is_valid_ether_addr(dev_info.mac_addr)) memcpy(net_dev->dev_addr, dev_info.mac_addr, ETH_ALEN); else - /* Generate random MAC address. */ - eth_random_addr(net_dev->dev_addr); + /* Assign random MAC address. */ + eth_hw_addr_random(net_dev); if (dev_info.mtu) net_dev->mtu = dev_info.mtu; -- 2.35.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-06-21 15:37:54.105319444 +0800 +++ 0110-kni-use-dedicated-function-to-set-random-MAC-address.patch 2022-06-21 15:37:49.234451950 +0800 @@ -1 +1 @@ -From 2ee8c67ef9399759cb0d3f34b2c9fb6ea0ecc832 Mon Sep 17 00:00:00 2001 +From 628b8d88c48c3679daf1ae2e7a42933c5ad5401a Mon Sep 17 00:00:00 2001 @@ -7,0 +8,3 @@ +Cc: Xueming Li + +[ upstream commit 2ee8c67ef9399759cb0d3f34b2c9fb6ea0ecc832 ] @@ -22 +24,0 @@ -Cc: stable@dpdk.org @@ -32 +34 @@ -index 780187d8bf..4f6dd373a3 100644 +index d1f6f54aac..a6b51fc32f 100644 @@ -35 +37 @@ -@@ -405,8 +405,8 @@ kni_ioctl_create(struct net *net, uint32_t ioctl_num, +@@ -407,8 +407,8 @@ kni_ioctl_create(struct net *net, uint32_t ioctl_num,