From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 19C56A0545 for ; Tue, 21 Jun 2022 10:04:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 10C0A42802; Tue, 21 Jun 2022 10:04:42 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2067.outbound.protection.outlook.com [40.107.95.67]) by mails.dpdk.org (Postfix) with ESMTP id 751A540151 for ; Tue, 21 Jun 2022 10:04:41 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iC5IrQ9jdR0PgNfTwm4W63kctJEzWEMWGkhI4zZtBGBabocN6zCHeUtOp81nkn7KcDC4s7sXa0EkEw6HFxWNd/8kaCcpOQzvGbYAZakaQcu38xq5jWoPWADVYmO922gIctnHicChDPI2qsFORYl6i+A9H/gSbcS7HR04f4/23mbZbt5jMm6pE5no+Pd+evvamjOSEnXIrBfYlkq9MV2YyEpCBg0HzCQCD8CxN7Wwozo4PDjsGadVnAZTCDuAh/S42UX1SMA9Oz1K9mali78dtThwwsmq5g+paYLU6uB6VWyw5znTNo/pqNNTCxj2PJzQ0275R5tczQlJdQWnWbTlIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HAOGZUzNqNaHgwIelLcXSnSk5Vqtur/0Fozr4qEyj2w=; b=V3oaJX+6mO/Zq+GBYBMT/ipWL/Tp4yFhQx0f8zDdPjjYpweop10VO+VC4xp6fTWtv7wuRpve0eNzo4mxtbqcNu7bZ2N1ESFlQAW6R1wRWa3VjX4Q3lAw2a5ag/uIWaX3nL2Tf7n/FA+DvQDLWw2RRxr50ivYXR2Gx5oO0ID/g/2POUWmOhlyUCzERZGL55hdMClIi/trBoXHrU1FXWVLYiMLhtp2wW/30lFv0KjXckspCktrdyoTPpwZlqUSXV/wZ8B8hPqBqqXCVRE1tA6zDDGwI5YAcjEt4uhUuLdqk/9qFOslL3KFBiUY1pPPKepMoysec6ouY7kP4VYc2sL84w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.235) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HAOGZUzNqNaHgwIelLcXSnSk5Vqtur/0Fozr4qEyj2w=; b=C8WcWhrVcumrP3Ihbjr4mCi11X+qhRADw17lr2157FWDXyK7be1hvQbznvCBnZzaggWmS7oKLwTf05Kxn9z2ENP8Fg7HL5zmNZUksqVlJych0iNEOeVgo6gCnEQulZaLgJMnI3JzVbWDNjysu8VjQXA0FwJSa5H461BBTYANxGhT0pi6m6SvhDpROj3+NSWMFrPP1bcdGgEU+tAC28HSIlR/ifuAl1sMsWWMhN9ax+PrOJV1tXRiYvjPEexUxf84PzsuneEHNPSG2D/SmaVm01QBlpTdjMOiuemICtBmybg3oIkZYV7VTWl2qql8zxMKBDFEA35JzFcPswZCfPFtqg== Received: from CO2PR18CA0051.namprd18.prod.outlook.com (2603:10b6:104:2::19) by DS0PR12MB6536.namprd12.prod.outlook.com (2603:10b6:8:d3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.18; Tue, 21 Jun 2022 08:04:39 +0000 Received: from CO1NAM11FT037.eop-nam11.prod.protection.outlook.com (2603:10b6:104:2:cafe::35) by CO2PR18CA0051.outlook.office365.com (2603:10b6:104:2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.22 via Frontend Transport; Tue, 21 Jun 2022 08:04:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.235) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.235 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.235; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (12.22.5.235) by CO1NAM11FT037.mail.protection.outlook.com (10.13.174.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5353.14 via Frontend Transport; Tue, 21 Jun 2022 08:04:38 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Tue, 21 Jun 2022 08:04:38 +0000 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 21 Jun 2022 01:04:36 -0700 From: Xueming Li To: Gagandeep Singh CC: Akhil Goyal , dpdk stable Subject: patch 'crypto/dpaa2_sec: fix buffer pool ID check' has been queued to stable release 20.11.6 Date: Tue, 21 Jun 2022 11:01:23 +0300 Message-ID: <20220621080301.2315720-18-xuemingl@nvidia.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220621080301.2315720-1-xuemingl@nvidia.com> References: <20220621080301.2315720-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d8ebd7c9-13fc-424a-cf09-08da535cb07e X-MS-TrafficTypeDiagnostic: DS0PR12MB6536:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: E4gU33aXTPmOcHvIKfCmMeg8QMKRJlUDZuUUhT5kWoLRE50chy4F3BRmoXG8AlYYYH6QOH7m2a6D+F5hxVp8kQJR4K6W9zXmwO+kxlWsyH3MwZIRg4g9FJOijM92mx/YXgoxkrBvBY4BSBsncg45kXVHMKWS7WWesw27ovJGMoESe+CYUj71q0D/7tGSAMEGcomko9jIgS72eHRnmqUpGl0cP8K+ldR6AnIM8UB4MZCcwuzQ+ddglxjUVKaMCdOsvZBDxBF/gtih9GcebUuYw9t8z8KhVkuv2w8S6hIlyucRBD2xiC4MGGLsF2+O/pUu4ZI+ooUDO/CwOe1fLJQwYpyR4b7unKpjPUry1vCJUjoV8l9p4PrYEt9351oja0CawS0gsZQaC20gwEB1yA6cGzs8auCv3pit3Vrh31GhkM4wytEvjKSCSlmp8VZwgcMaCRas9dkzejskH8gKpOJ9JixZeg7uB+zEAIBZIpmXvYghB4bYVsxSSmL/8x973PT7d2VyAUGJ4VqcMMzkTDGR0e9YTcIj7ewMZirIjrXatEXGWbSGSlUDHFMVDc1JuGKcsZW7tw4+9nHV/VHGVk5r3eZjONyWzyLyGNCbctB+UbI5JSWT3BcVS33JSdRVFbtjWFiphXwgVX8yUxDFKX3GgvPgn1Zraz2llPf80CvlpPGd3L16ZlyVtrtfIJUvNML0UaCyVIurYOXXX3WGFel860jIW6d3QdZB9LRsru8vpk4/OAuxQbZ+SOdp+Jos7hp3GYRjVVna78j9fBCXMG2RApO8SQ58aIjWjVi8kgQqCF55aBYU+gXDyqA+RJ0kTsld7vbhhzPalxCTE+tjceRrW7Jbjq+T1nXo3a6h+ZENM5A= X-Forefront-Antispam-Report: CIP:12.22.5.235; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230016)(4636009)(376002)(136003)(39860400002)(396003)(346002)(46966006)(36840700001)(40470700004)(316002)(4326008)(70206006)(54906003)(6916009)(478600001)(70586007)(2906002)(8936002)(53546011)(8676002)(86362001)(36756003)(5660300002)(26005)(2616005)(6286002)(1076003)(186003)(16526019)(47076005)(82740400003)(40480700001)(55016003)(83380400001)(426003)(40460700003)(336012)(82310400005)(41300700001)(966005)(7696005)(6666004)(81166007)(356005)(36860700001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2022 08:04:38.8450 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d8ebd7c9-13fc-424a-cf09-08da535cb07e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.235]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT037.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6536 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/23/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/faf1c3baa87e275829adee1889f6277f4e1b1d2b Thanks. Xueming Li --- >From faf1c3baa87e275829adee1889f6277f4e1b1d2b Mon Sep 17 00:00:00 2001 From: Gagandeep Singh Date: Thu, 28 Apr 2022 17:17:21 +0530 Subject: [PATCH] crypto/dpaa2_sec: fix buffer pool ID check Cc: Xueming Li [ upstream commit e2b70a309f901b6aa947087a318ba0be3ea8782b ] Simple fd rely on bpid of the buffers whereas other FD types can support buffers without bpid of pool. So moving the bpid check to simple fd to mbuf conversion function. Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation") Signed-off-by: Gagandeep Singh Acked-by: Akhil Goyal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c index c9e378d467..de0cf0fbc4 100644 --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c @@ -1561,6 +1561,10 @@ sec_simple_fd_to_mbuf(const struct qbman_fd *fd) int16_t diff = 0; dpaa2_sec_session *sess_priv __rte_unused; + if (unlikely(DPAA2_GET_FD_IVP(fd))) { + DPAA2_SEC_ERR("error: non inline buffer"); + return NULL; + } struct rte_mbuf *mbuf = DPAA2_INLINE_MBUF_FROM_BUF( DPAA2_IOVA_TO_VADDR(DPAA2_GET_FD_ADDR(fd)), rte_dpaa2_bpid_info[DPAA2_GET_FD_BPID(fd)].meta_data_size); @@ -1607,11 +1611,6 @@ sec_fd_to_mbuf(const struct qbman_fd *fd) * We can have a better approach to use the inline Mbuf */ - if (unlikely(DPAA2_GET_FD_IVP(fd))) { - /* TODO complete it. */ - DPAA2_SEC_ERR("error: non inline buffer"); - return NULL; - } op = (struct rte_crypto_op *)DPAA2_GET_FLE_ADDR((fle - 1)); /* Prefeth op */ -- 2.35.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-06-21 15:37:50.068993449 +0800 +++ 0017-crypto-dpaa2_sec-fix-buffer-pool-ID-check.patch 2022-06-21 15:37:48.987784408 +0800 @@ -1 +1 @@ -From e2b70a309f901b6aa947087a318ba0be3ea8782b Mon Sep 17 00:00:00 2001 +From faf1c3baa87e275829adee1889f6277f4e1b1d2b Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit e2b70a309f901b6aa947087a318ba0be3ea8782b ] @@ -14 +16,0 @@ -Cc: stable@dpdk.org @@ -23 +25 @@ -index 03fef5e500..2374d67978 100644 +index c9e378d467..de0cf0fbc4 100644 @@ -26 +28 @@ -@@ -1566,6 +1566,10 @@ sec_simple_fd_to_mbuf(const struct qbman_fd *fd) +@@ -1561,6 +1561,10 @@ sec_simple_fd_to_mbuf(const struct qbman_fd *fd) @@ -37 +39 @@ -@@ -1612,11 +1616,6 @@ sec_fd_to_mbuf(const struct qbman_fd *fd) +@@ -1607,11 +1611,6 @@ sec_fd_to_mbuf(const struct qbman_fd *fd)