From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4C1DA0543 for ; Tue, 21 Jun 2022 10:05:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C0B0440151; Tue, 21 Jun 2022 10:05:36 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2070.outbound.protection.outlook.com [40.107.223.70]) by mails.dpdk.org (Postfix) with ESMTP id 831A640151 for ; Tue, 21 Jun 2022 10:05:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I7ngGHOv1tz1YyzVdTTrjDDNVK0VCCIIzrqR2z82yVTXaXRFiqgCUmQzMD6kmiq10PWL1ijbNd2p+6IrQ1APsplQiD1ZBBUZy9Pc1v07o7O9aS5qw3ypV5EJGonfPx8yRvLVkaemHJIdyCT642xZpKRsCZ8Bi1jZDxj3Dp8X92xjcc33sGQB9ibdjs9exSwc/9h+1CyPrx/6f8oRKTnThIiDHehYmBjaWnQ6e+yCwiLWaafFh1YJ3auWOGEuj8HlJ1Ctx+wdIs8kqpoBC3mgKkCX/Oo2wJMRpRIpCMSe5rsm2Ky7uAIha6ymcyQ716lqdu0dOERZg6f3swKMwMNkPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fOARqRV/09jad+YUhVNV+NKQCgdZvhVEN1Y26sxA+Uk=; b=JA7crbkhQUGqOsr6G4df2SVyw5oKh+zOfVuJ5jknHoZ6Bxx2tEn6I9WFE9KPQ+5LV6c3xBSVwSCVFe5Nc+tphOWdfvDGALTbiQmhOgzqGaEh29unnCsIiOBzUgUHK4dsMYWFatJsNHU9mAHHMoZsG2vJ6gKCTBJUAxBIEnm5RwPHSXEb5qfhGIJTt+oZ4XlxbeOQeKFyMIlh74d/jUTsqUoVi3e9GpVwzGOia8Dsot21hlO4aJ3D49RWzQWPxsM2U/gQA0MhncF6a6dWawxe3iq5ECbgEhIAkV2ZEUGgwXyk2er1o9XKzaqZORLt41g5DRAjKVhIopxoSbgyn0ldJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.236) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fOARqRV/09jad+YUhVNV+NKQCgdZvhVEN1Y26sxA+Uk=; b=A+NZzQnBYgcDmHPcgoCCqfgoG+pFnxVXtRGl6ilJrxtpWBu7XyHB613Cl0KtmaWKFbhHgxA/wTj+dgTizMWyTzL46Sq70Cc6ReIrTPpIMC+jXSuCW3+OhsRKuz5CsTjthrFFUPBGotstchgg4wUrpTLJv/zjgB7Yhu9NnxjxGgRA7NKjetHB0yVaHg4wpsB7g976hUqwHLTsq+Q41EDY50xY4S2p1BHih9uJBQYdiet1kr97Y7wYZSUonzuvLnvUnYsQXMfkNKBfcRkAuyOim9VBD6whteLcBXaVbmCBRXuEjPZ4E/X7S4EIfjdb+kxif3z+COcpg0P077CPSFyWDQ== Received: from DM5PR13CA0056.namprd13.prod.outlook.com (2603:10b6:3:117::18) by DS7PR12MB6005.namprd12.prod.outlook.com (2603:10b6:8:7c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.18; Tue, 21 Jun 2022 08:05:33 +0000 Received: from DM6NAM11FT042.eop-nam11.prod.protection.outlook.com (2603:10b6:3:117:cafe::7) by DM5PR13CA0056.outlook.office365.com (2603:10b6:3:117::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.10 via Frontend Transport; Tue, 21 Jun 2022 08:05:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.236) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.236 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.236; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (12.22.5.236) by DM6NAM11FT042.mail.protection.outlook.com (10.13.173.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5353.14 via Frontend Transport; Tue, 21 Jun 2022 08:05:33 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL109.nvidia.com (10.27.9.19) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Tue, 21 Jun 2022 08:05:32 +0000 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 21 Jun 2022 01:05:31 -0700 From: Xueming Li To: Maxime Coquelin CC: David Marchand , dpdk stable Subject: patch 'net/vhost: fix TSO feature default disablement' has been queued to stable release 20.11.6 Date: Tue, 21 Jun 2022 11:01:35 +0300 Message-ID: <20220621080301.2315720-30-xuemingl@nvidia.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220621080301.2315720-1-xuemingl@nvidia.com> References: <20220621080301.2315720-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 541c9c34-f276-4b12-3dd3-08da535cd104 X-MS-TrafficTypeDiagnostic: DS7PR12MB6005:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 771ATjPaKMs2C6e8Bb1wo5booQ5xMqOZbK/oGctoZug5M1xR2d2b1ZS5LHDkhoiNw3If5RrWX8tCWhqmzGXWeiuUqzClFCI392uxAv5NhouyfrVZf9YDkT2h+6rc2fCQ9/gUNf2G80M/8rPtg9A8k0nwWI/+rQBnbxUusAPQw1gDlDqww3wdQpC2Cz2DK6Z7cNNrt9HSjiw/N+A2iMwt0pr4VFzFMgxmN/yTlGV4nBm2PLpX+pUQnrw0Bp7Tn6nKs1WWNujsz5vqnxrE/73JFL3A/LJkadsE67VmFPfiYW/BZvlrrclW/f6bLA4nfN/SHe5xYyUmYNBZ92OD5yOmudlgrLNotLcrCvO6I3Kw9QEKN0x5YxUiCZauejRFLzwlioho2AjvcNyP8sq4Ijz5zGLObxhwVrFAKNpQ6atKIkpjhK8cuIS9FIAUQu9SgvYPVSyr/kdqflqMuD06f0Fs2aeoGb1mAPBFG36teUKju1oORDcy3fKjMnQFis8Akm45m4Vey45gLiwz8+st33TJr18iy5d3wDYeU+/nH6R0vp1yYWF18nOLq7eGqITu6zsENr4cq6EgayilHMRzx57DRfQ1c6GllwsGmfZ4i3jGP35pSt5UA9yv7iMHVx+IpY/qZpABG5m3BZ6KBG0yUNvOUu4M7YPcAUqkEUCralwQPdaHAy0BXBDD9u8/TeFV7kC4UZZx33tSUY2nhqTFANtOv8EHJTxmV6SdkJ83mWw24Ij8nlsZmISQlnpb6zevzsMJ1wPQkgmpp+0mkvrIDP8tqknHAikwqWQmDHYu93g053B0UW44oWigmDn6CnDLlhzXGTo7k5TJnVGzQCmlB0UNPey2AL3IAo37ocptXyfa6ek= X-Forefront-Antispam-Report: CIP:12.22.5.236; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(346002)(396003)(376002)(136003)(46966006)(40470700004)(36840700001)(966005)(426003)(70586007)(47076005)(1076003)(6286002)(5660300002)(4326008)(2616005)(36756003)(83380400001)(40480700001)(16526019)(70206006)(2906002)(356005)(336012)(55016003)(40460700003)(81166007)(186003)(6916009)(54906003)(82310400005)(41300700001)(82740400003)(26005)(36860700001)(8936002)(478600001)(8676002)(7696005)(316002)(53546011)(86362001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2022 08:05:33.3909 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 541c9c34-f276-4b12-3dd3-08da535cd104 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.236]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT042.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6005 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/23/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/45f14afcf9b88b23c9aed9c42c103713438e6e7b Thanks. Xueming Li --- >From 45f14afcf9b88b23c9aed9c42c103713438e6e7b Mon Sep 17 00:00:00 2001 From: Maxime Coquelin Date: Fri, 22 Apr 2022 11:35:43 +0200 Subject: [PATCH] net/vhost: fix TSO feature default disablement Cc: Xueming Li [ upstream commit 6d7046215a3da334bac77d2b06e5ae1c208f3ca4 ] By default, TSO feature should be disabled because it requires application's support to be functional as mentioned in the documentation. However, if "tso" devarg was not specified, the feature did not get disabled. This patch fixes this issue, so that TSO is disabled, even if "tso=0" is not passed as devarg. Fixes: e289400669d5 ("net/vhost: support TSO disabling") Signed-off-by: Maxime Coquelin Reviewed-by: David Marchand --- drivers/net/vhost/rte_eth_vhost.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c index 0778dfbd13..2df516ec21 100644 --- a/drivers/net/vhost/rte_eth_vhost.c +++ b/drivers/net/vhost/rte_eth_vhost.c @@ -1604,11 +1604,11 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev) &open_int, &tso); if (ret < 0) goto out_free; + } - if (tso == 0) { - disable_flags |= (1ULL << VIRTIO_NET_F_HOST_TSO4); - disable_flags |= (1ULL << VIRTIO_NET_F_HOST_TSO6); - } + if (tso == 0) { + disable_flags |= (1ULL << VIRTIO_NET_F_HOST_TSO4); + disable_flags |= (1ULL << VIRTIO_NET_F_HOST_TSO6); } if (rte_kvargs_count(kvlist, ETH_VHOST_LINEAR_BUF) == 1) { -- 2.35.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-06-21 15:37:50.655500148 +0800 +++ 0029-net-vhost-fix-TSO-feature-default-disablement.patch 2022-06-21 15:37:49.007784479 +0800 @@ -1 +1 @@ -From 6d7046215a3da334bac77d2b06e5ae1c208f3ca4 Mon Sep 17 00:00:00 2001 +From 45f14afcf9b88b23c9aed9c42c103713438e6e7b Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 6d7046215a3da334bac77d2b06e5ae1c208f3ca4 ] @@ -17 +19,0 @@ -Cc: stable@dpdk.org @@ -26 +28 @@ -index 8a6595504a..a248a65df4 100644 +index 0778dfbd13..2df516ec21 100644 @@ -29 +31 @@ -@@ -1654,11 +1654,11 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev) +@@ -1604,11 +1604,11 @@ rte_pmd_vhost_probe(struct rte_vdev_device *dev)