From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E303FA0543 for ; Tue, 21 Jun 2022 10:08:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DD4E34069C; Tue, 21 Jun 2022 10:08:36 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2065.outbound.protection.outlook.com [40.107.244.65]) by mails.dpdk.org (Postfix) with ESMTP id B06464281C for ; Tue, 21 Jun 2022 10:08:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g/Xl5baDLMRxThAHLvX3egSS+dgjgA7xaI0ImVa71mZ/UvSTpMjuok8apvD/dy4dTFANeOxvEjMgAZBMpj5w4EsQFRnKGQ0C9pyomsW2joxDs2kZxhtg9/3ffLJUxc3ZzlmUhW1LURf0aQSWaPvllvmzF2wm0am0SatchqKV/YRk6PHodF9Wdrtyq7rKRngO8ZW8xtIb6B1AfAgqcgffkLLuiKKxbiqa/cK+ZR9PyOK/e0w0ogEjnLbV42OOcchibwHDYruVsJ4Df9pklJrqQPUfwt/ChVNW5gVoAjI+v0hwyNHWEuq2t6JmM9jcE9aP9SkuUxiHyO2ZtmjSO71JZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4qLVPJovkJsH+6Hk98OgTaeaC2RWEzcTMjXNOr88XB0=; b=fJaNEsvkZu7kD2keajOym//v9hVhiW7M1sy2CPelowzf4GSOHecjwc1ALzAofRJ9DyvqY0B5/fksBEfgxnywVhY2kwGY6ttJIYX4UaRIpD4ybwuzH8DBBJR1Xh8uFEOdYtDQBU8/UQ/G+oXrHoeVd9n92Z7V3DL8baE3qLKTzGBqz+K8Yn6nnZzvmELOJK15qZSqW9R7fiB1e+I1UWhzFqeQeTKsuEf6I2HFmJjj/AZwg7LGXHzGx0GBRTs0CNzvunf8J7vYZa2D+fBn5uSZZVedPqCFaSCY3nDCrSFc4Kai0hNjfg9JEjaH7fQkisRIAAEfOsw1VL6r1ZHlcow0eA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.234) smtp.rcpttodomain=marvell.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4qLVPJovkJsH+6Hk98OgTaeaC2RWEzcTMjXNOr88XB0=; b=Bkr4fHYMfeI1qrSIePiL0houU3xBtScc8C39txSyt9c0YEItmbB8VD7ueyJdG76kBqNfQoXNj28pjKOlqx8QZeXE1YTMHp6b3jRPmOVCMKy3/pBW2O1+zpwobtJ+Qxajh5psTLQjbrzf4/zpLoXgwDr4SPLmOVUuGnpkPRfLLG0X/O81yZ8RYJAxdaDdfPk117BvwuFiQDmIMMWhp/15l5kO4oAt4zzpAtPT9oaCSaulrqCu32Lb2YSdArcSz6rYkZoZk8P4DLILahsirZaEiQpxIOEma1j896gCjFeq2LTRMFFAjwi5+oJ9RHWlyeqSsxasGqgX8Viy/HRkhaJq4Q== Received: from BN9PR03CA0969.namprd03.prod.outlook.com (2603:10b6:408:109::14) by PH0PR12MB5451.namprd12.prod.outlook.com (2603:10b6:510:ee::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.16; Tue, 21 Jun 2022 08:08:34 +0000 Received: from BN8NAM11FT041.eop-nam11.prod.protection.outlook.com (2603:10b6:408:109:cafe::84) by BN9PR03CA0969.outlook.office365.com (2603:10b6:408:109::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.17 via Frontend Transport; Tue, 21 Jun 2022 08:08:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.234) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.234 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.234; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (12.22.5.234) by BN8NAM11FT041.mail.protection.outlook.com (10.13.177.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5353.14 via Frontend Transport; Tue, 21 Jun 2022 08:08:33 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL101.nvidia.com (10.27.9.10) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Tue, 21 Jun 2022 08:08:33 +0000 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 21 Jun 2022 01:08:31 -0700 From: Xueming Li To: Volodymyr Fialko CC: Anoob Joseph , Akhil Goyal , "dpdk stable" Subject: patch 'examples/ipsec-secgw: fix uninitialized memory access' has been queued to stable release 20.11.6 Date: Tue, 21 Jun 2022 11:02:09 +0300 Message-ID: <20220621080301.2315720-64-xuemingl@nvidia.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220621080301.2315720-1-xuemingl@nvidia.com> References: <20220621080301.2315720-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 52a6380f-b6ed-4461-bc56-08da535d3c95 X-MS-TrafficTypeDiagnostic: PH0PR12MB5451:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VWGyVVO7agEN6plh5iqViakc1ZYrkblejS+honD0+iDrKxXOCdDI8oWu9X/RgN4XQ/iEOc7nChdz28my4SVVhuBOKsA9hxXPryXpbucaJWgZo2cG2N+rgzoMWq9abXK6QMsRiQxx/jvFs8J4Yji+KXhzEylAHsxsoLe8stigifUcVBxsoiVxY3IUYQEMxHoegKsBZbBuFh8rFPpI5WNg6fKOMl8CLupPsCgZphYIJ+JXfHd+aAWrK1pHP9eFJxtEoEOg5ksTvGKaFcquM+5qyjSuQQd1rLV5UKYXvQxm4yaNpd9I+wGH6KY70SmxeX0pbl/fld+0SauaXjl7o2P2UJe5eF07lJP6+dt78qwckrmfuGXviR4PMdaEP1uSAzqzZ7awuYjDYa4ScAPX022y97H5mfpFZj+r6ot6gmMcr0sRFXb7+Q4tkZKDeX31FkaXSPhKGHRTMV10bLEFbkyWEdtPRxOZtB7W3cW+LdM8VYLd56nG0jt9a4u9eXwxtC+oxHvqiyXgb+HbgGQIMKTKSw6USpemG9n4e0uIJn+p5vGkO+2q2w2rZKH2z3MZLDzwFqlMmVxtbSL9s6KjKu/xReKXqV5D8uYpyfW6wnH0qM545/7L5+EyzQK2EjRjz5/OPvRxVz7aBTqx2wU6194yNEPvfdmThPEiehS1AreR6SqXa4wDb7YTt7S790Bv8M6ZS2ory1aJ8nwNleM5o6Q/+lDGGKhulL0YjfjCb2iEPDEB9wAKSZpg5uiyqphnxLf0QKl+gZ5YwloIuBolq1+qSVFW+LGEpuj0k73vR4WJ5uF8A6PECtKULZ0yK6c4+e/3ppBaYpS2sQS7IDjd0pz1HvNb/itdIndy7ZFuadW+Dho= X-Forefront-Antispam-Report: CIP:12.22.5.234; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(136003)(376002)(346002)(396003)(40470700004)(46966006)(36840700001)(70586007)(4326008)(82740400003)(356005)(70206006)(36860700001)(8676002)(83380400001)(478600001)(316002)(16526019)(186003)(86362001)(966005)(336012)(26005)(1076003)(2616005)(2906002)(53546011)(54906003)(6286002)(40460700003)(47076005)(6666004)(426003)(40480700001)(82310400005)(8936002)(41300700001)(6916009)(55016003)(7696005)(36756003)(5660300002)(81166007)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2022 08:08:33.8294 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 52a6380f-b6ed-4461-bc56-08da535d3c95 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.234]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT041.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5451 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/23/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/78059ea5a5fd9eed93237e9a6d04dd3b96ae1d38 Thanks. Xueming Li --- >From 78059ea5a5fd9eed93237e9a6d04dd3b96ae1d38 Mon Sep 17 00:00:00 2001 From: Volodymyr Fialko Date: Fri, 25 Mar 2022 12:29:42 +0100 Subject: [PATCH] examples/ipsec-secgw: fix uninitialized memory access Cc: Xueming Li [ upstream commit 0b512a92b77009ab6e4291382b18f0e0ac74645f ] rte_flow_validate and rte_flow_create not always initialize flow error. Using error.message in some error cases will cause read from uninitialized memory. Fixes: 6738c0a9569 ("examples/ipsec-secgw: support flow director") Signed-off-by: Volodymyr Fialko Acked-by: Anoob Joseph Acked-by: Akhil Goyal --- examples/ipsec-secgw/flow.c | 2 +- examples/ipsec-secgw/ipsec.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/ipsec-secgw/flow.c b/examples/ipsec-secgw/flow.c index 1a1ec7861c..c217b9e475 100644 --- a/examples/ipsec-secgw/flow.c +++ b/examples/ipsec-secgw/flow.c @@ -214,7 +214,7 @@ flow_init_single(struct flow_rule_entry *rule) struct rte_flow_item pattern[MAX_RTE_FLOW_PATTERN] = {}; struct rte_flow_action action[MAX_RTE_FLOW_ACTIONS] = {}; struct rte_flow_attr attr = {}; - struct rte_flow_error err; + struct rte_flow_error err = {}; int ret; attr.egress = 0; diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c index 6baeeb342f..a8a8cdbe2e 100644 --- a/examples/ipsec-secgw/ipsec.c +++ b/examples/ipsec-secgw/ipsec.c @@ -425,7 +425,7 @@ int create_ipsec_esp_flow(struct ipsec_sa *sa) { int ret = 0; - struct rte_flow_error err; + struct rte_flow_error err = {}; if (sa->direction == RTE_SECURITY_IPSEC_SA_DIR_EGRESS) { RTE_LOG(ERR, IPSEC, "No Flow director rule for Egress traffic\n"); -- 2.35.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-06-21 15:37:52.160100934 +0800 +++ 0063-examples-ipsec-secgw-fix-uninitialized-memory-access.patch 2022-06-21 15:37:49.081118072 +0800 @@ -1 +1 @@ -From 0b512a92b77009ab6e4291382b18f0e0ac74645f Mon Sep 17 00:00:00 2001 +From 78059ea5a5fd9eed93237e9a6d04dd3b96ae1d38 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 0b512a92b77009ab6e4291382b18f0e0ac74645f ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org @@ -35 +37 @@ -index 2d4a26c962..b66ff2b650 100644 +index 6baeeb342f..a8a8cdbe2e 100644 @@ -38 +40 @@ -@@ -496,7 +496,7 @@ int +@@ -425,7 +425,7 @@ int