From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BED6A0543 for ; Tue, 21 Jun 2022 10:09:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B87042B78; Tue, 21 Jun 2022 10:09:06 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2055.outbound.protection.outlook.com [40.107.220.55]) by mails.dpdk.org (Postfix) with ESMTP id 8E48742B73 for ; Tue, 21 Jun 2022 10:09:04 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j7tqSagECWlnnkr055PAKtZqARF6KumWwuCy/jSpZY5351nElsRnEKwEtXzmLxDxwZTsq0UYvnO/JltiRY6zPtTHsvpJz12UXEI5EtIiPUWrZAA3Ohk243uORp+9R+UfThL+A4YDORMPVy3gp7NXKsop22ydV4eha3MChBx/Eazz1dvXd5YqdQjHEPA5gAYBKQ6ea3mEx5TIpgJm/JKrNlHQZqLSjLpejdLwPDmtynkIdUvdrpNjT5BVXCi0z5VD2BZVkBY+r6NqttScNpTxg0rl+w/p89WDH69eAbmtUsAqNzAvZjHB5Jl3pOUEqzhk2+aoKraPpG0WwwUTuFopNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=otnOyiI481ZJ8BxXD2Q1w+u/zZQJqDW5JOX+3/NShTM=; b=iJwJc4oL0tntcjKLLl21FX1YH+oTjCXucu7ahOccjMicTpCBUR3t3pZPP9jNT86awqNuudDWpsWHWg1DDOchkefg7jDhTHMu7+RqSUrHlvmK/kwZTyolWegjTKpCYlS4KAkqxG0yzjGAQhU3Osy/c8gDlyFIOJpbgl0xWPpKS/oyoM1kOvxXj1bx/eK3oSwIclMktys7eU21cLqMpdhv3If6HlAZLuYFdcg7pgTSp+dm8WDUhSWzmMiWEoKhWosK3GgkDDYg2+Od800St8Og9TXqvJRgJk5EUsrC8QxSceUgkNKgBV3ozC+4kOXWLKm2gGNNKoZkkmOSrB4opUMQDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.238) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=otnOyiI481ZJ8BxXD2Q1w+u/zZQJqDW5JOX+3/NShTM=; b=DgYFeCgd82g2nWJIU2NXUegA/8/O1gV6Qdk4mhPbeN35FN0IIGEtcQ0xKEPVOPDniaUWxdUvJLGmSK4rDnfEuh92pkJiv0KbKdIxZ/b7/xd2e1CvkDKfoYvgaww6kczjkJY7RIb6SzwMQqRPVxX9X4g7mW0RS8p2xHNJ8r7dN1aIVopyTWptmtzWC/jZ3MupUu0he2d9eMfOE3UIIXjzTtI/z+JyP4EdBdZuC0INS4SiUKIPZpVITM5Lvf4rI9GWF7Qakz4CY9BNXViqYsO6xqdYS/MY4SQbsYbmHrjBdGL202dFt1X4gOoLEaT2ywtzHO1Ro1rHxEYaHzHtq7HgZQ== Received: from MWHPR2001CA0012.namprd20.prod.outlook.com (2603:10b6:301:15::22) by BYAPR12MB4742.namprd12.prod.outlook.com (2603:10b6:a03:9f::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.15; Tue, 21 Jun 2022 08:09:02 +0000 Received: from CO1NAM11FT052.eop-nam11.prod.protection.outlook.com (2603:10b6:301:15:cafe::b5) by MWHPR2001CA0012.outlook.office365.com (2603:10b6:301:15::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.22 via Frontend Transport; Tue, 21 Jun 2022 08:09:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.238) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.238 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.238; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (12.22.5.238) by CO1NAM11FT052.mail.protection.outlook.com (10.13.174.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5353.14 via Frontend Transport; Tue, 21 Jun 2022 08:09:02 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL105.nvidia.com (10.27.9.14) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Tue, 21 Jun 2022 08:09:01 +0000 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 21 Jun 2022 01:09:00 -0700 From: Xueming Li To: David Marchand CC: dpdk stable Subject: patch 'app/testpmd: remove useless pointer checks' has been queued to stable release 20.11.6 Date: Tue, 21 Jun 2022 11:02:15 +0300 Message-ID: <20220621080301.2315720-70-xuemingl@nvidia.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220621080301.2315720-1-xuemingl@nvidia.com> References: <20220621080301.2315720-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 82772f0c-9015-4ac3-c56b-08da535d4d78 X-MS-TrafficTypeDiagnostic: BYAPR12MB4742:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5vxzFLNs9Kxlvr34B79n0ItGJBSBx/SBj+uiysRhXAFBI3H5Fa+gts2JYmzpj7a0NVXW7AQUMt8INfpPX3dE2vYW8E4EuNX6m6pK7PmBYIwjI4mRW/05/DBjRjzlwbyQLi0YTe76d5+St7XgBWNZB9J1YmFaT+nN2x9iYXN4lVxmiAtbZuVugRcITDqsszkkkVZl4IG15D9yDdED25ABJHnUSKkl2DkdDkU5krWBFXz71ugcdUEWYWDFJUPR6Kp0oZmT83uXBFMP+qKNtWwVKsh3RURHNYwNvpnCsBuwABGJlTsVCmGo10jzi9fdAZGXVw776jwBNzf+MqQ4bln3Lec/3dfBhqFfO5uWAm0BUGP4z775ZK+yOvhTjy1mj8cxFkGk0Ow67DWM3zyvMkSol7tUjkHFNpA4aOhvmqhzObnpCW4ySdGmE72tY/bUoEIhCJtU8iLpx+rkOmdmOAzZVTeQxRtojiZQd8ZE9WWTCTsnZAEwGyQmk5oKs7Fk4D0oBOlmDBuPoEFgPK/Swrd9ulGiXI29Q+Qk+NNWL0AKATrc0P3z6XDJ85YWCXhqUsarn3JO0g19ZEYm7cwv9BWIWwoEOudXYtqvT1sKN0+7ogY+BXv3yqq+82oiVqkTIXp8nNVD5EvPAxVrYeowic48NhAZ/cJAyNA1mR+ZXd5jHBjrKgXuX7LXKja6MWmbys7Cs4tWG6uVbF8xbJMgkpF2QuHmOo2Hoazp4LOqNjKvCdStu12hrfxZwcW5EFzUjmFb+x6rHvEIi+dT4DsW/GzilqeeVi5fdHgb3TNeUoGiOpgZAKfprryTWf6Ne8P/Pma3JdoosjroI4F6D6o+1JLJdlEuJcDmjrRjzRy8LuOFj1c= X-Forefront-Antispam-Report: CIP:12.22.5.238; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(346002)(136003)(396003)(376002)(46966006)(40470700004)(36840700001)(36860700001)(6916009)(55016003)(40480700001)(7696005)(83380400001)(53546011)(86362001)(4326008)(70206006)(70586007)(2906002)(8676002)(316002)(40460700003)(966005)(82310400005)(81166007)(36756003)(2616005)(186003)(8936002)(1076003)(41300700001)(6666004)(356005)(82740400003)(336012)(6286002)(26005)(5660300002)(47076005)(478600001)(426003)(16526019)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2022 08:09:02.1921 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 82772f0c-9015-4ac3-c56b-08da535d4d78 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.238]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT052.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB4742 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/23/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/cf28773c938acfdf13f181649facbad24efea7d1 Thanks. Xueming Li --- >From cf28773c938acfdf13f181649facbad24efea7d1 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Thu, 24 Mar 2022 17:15:03 +0100 Subject: [PATCH] app/testpmd: remove useless pointer checks Cc: Xueming Li [ upstream commit 2d8699ebb2a0638e8ae18fc0a83c56f984d0b270 ] Parameters to this static helper can't be NULL. str has already been dereferenced in caller. dst and size point to variable in stack. Fixes: 169a9fed1f4c ("app/testpmd: fix hex string parser support for flow API") Signed-off-by: David Marchand --- app/test-pmd/cmdline_flow.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index c80be57bfe..de0db3994b 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -6414,11 +6414,7 @@ parse_hex_string(const char *src, uint8_t *dst, uint32_t *size) const uint8_t *head = dst; uint32_t left; - /* Check input parameters */ - if ((src == NULL) || - (dst == NULL) || - (size == NULL) || - (*size == 0)) + if (*size == 0) return -1; left = *size; -- 2.35.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-06-21 15:37:52.420196937 +0800 +++ 0069-app-testpmd-remove-useless-pointer-checks.patch 2022-06-21 15:37:49.101118143 +0800 @@ -1 +1 @@ -From 2d8699ebb2a0638e8ae18fc0a83c56f984d0b270 Mon Sep 17 00:00:00 2001 +From cf28773c938acfdf13f181649facbad24efea7d1 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 2d8699ebb2a0638e8ae18fc0a83c56f984d0b270 ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org @@ -19 +21 @@ -index fc4a6d9cca..e3269e278d 100644 +index c80be57bfe..de0db3994b 100644 @@ -22 +24 @@ -@@ -9338,11 +9338,7 @@ parse_hex_string(const char *src, uint8_t *dst, uint32_t *size) +@@ -6414,11 +6414,7 @@ parse_hex_string(const char *src, uint8_t *dst, uint32_t *size)