From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 102A3A0545 for ; Tue, 21 Jun 2022 10:10:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0746D42B83; Tue, 21 Jun 2022 10:09:59 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2061.outbound.protection.outlook.com [40.107.220.61]) by mails.dpdk.org (Postfix) with ESMTP id 57678427E9 for ; Tue, 21 Jun 2022 10:09:56 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=efppM86F/Al251IHOUWDuMl2mF9my+/3zqh++s5gx46OGqnPbEasjSBl5q3dwPMViZaLVAl3oVhxPl0j+oPOVLkCOKRqSVbPuaXHuCFnkD1ixAvbA2vdYJyqXMrqGBX16FeAGRfDKcMNACnCoNfhlAKqGsEeyOd62kpMLwAa9b0Q3Q8zzLT7fHsWMMUhcX75hxhGxwo1ZK0SWfeOqHJmSq3pqbNdysjY6TV85ngrOXFtsrl0dFrEmULHu8+C/erv5nlheGBnh5uw8CheYiHwc5b2teoxf9Lg5UNQMSXJCFu7k5G7DabZFIQt9vF3SNosTPDt7/o27vQvX6K6KubMBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EHJvVL1oCOiIPlKBMEXZRDBVsrPLAsWn290bbjy2Fjk=; b=Lo6ELkf1uZbPASuwdLpZnL8rt61pwLJlVnRiCJOsQZkr0tqDhtPQIOpg0tkc1wb7dDJVjXQ9axzneT+e+FHt2jpsQ6aJf19m9Nuewe6R164DNOZ81KIXp5SgBlrHY+39bFSztqtFcVOM+2Kkw7gIBOtyCp6TJXScONSM+b7FCuUnAENswnHnH1qToLNkbrsmwrxbOOxMoPPMjXxWwyX0BNlEZskSJOzYyXMfq3ZQnDPrmulyefaDbnHu4ejNIkDZtd0EnYgYoEyM/xy3FpM3fLqIW6q11mn74OSY3gvWNNh6GvI5714nfMOKlM4zzgfIy3IHM8T2ubmoycc0EELUsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.238) smtp.rcpttodomain=xilinx.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EHJvVL1oCOiIPlKBMEXZRDBVsrPLAsWn290bbjy2Fjk=; b=CQImRttNdkybbwqPNPSsjFgsp1vhvsi9e2m+7tGUheo+Z9DPsmSh5xEc8RN73eBKtu5AeN4TX/4WG34z0YN8v1qGCPwNaWr5d5xmsrMTwN8CnMJL1tnknHAZcUIUJ1cnoytMYWcJYjm2r80lJ1zWgVBo5P7MN+wMlpgTn88kkJ8bxpCbWzz9EAceHJukz96PIMW6fM7JL4G1svENGgINJgJfExPJSbhF81qquTmcvUxkMbeoirUji5xHYspkkw8sWGOworHmMorrF1pniKYyq45q6Ovxpi6boefryuRTlJSg2JVeDFPeZd5C3Z8TFRJPmc3jQYl5QmxZ6CqaCjL8DA== Received: from MWHPR01CA0046.prod.exchangelabs.com (2603:10b6:300:101::32) by BN8PR12MB3265.namprd12.prod.outlook.com (2603:10b6:408:6a::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14; Tue, 21 Jun 2022 08:09:54 +0000 Received: from CO1NAM11FT032.eop-nam11.prod.protection.outlook.com (2603:10b6:300:101:cafe::da) by MWHPR01CA0046.outlook.office365.com (2603:10b6:300:101::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14 via Frontend Transport; Tue, 21 Jun 2022 08:09:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.238) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.238 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.238; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (12.22.5.238) by CO1NAM11FT032.mail.protection.outlook.com (10.13.174.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5353.14 via Frontend Transport; Tue, 21 Jun 2022 08:09:53 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL105.nvidia.com (10.27.9.14) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Tue, 21 Jun 2022 08:09:53 +0000 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 21 Jun 2022 01:09:51 -0700 From: Xueming Li To: Mingxia Liu CC: Yuying Zhang , Ferruh Yigit , dpdk stable Subject: patch 'app/testpmd: replace hardcoded min mbuf number with macro' has been queued to stable release 20.11.6 Date: Tue, 21 Jun 2022 11:02:23 +0300 Message-ID: <20220621080301.2315720-78-xuemingl@nvidia.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220621080301.2315720-1-xuemingl@nvidia.com> References: <20220621080301.2315720-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 86be9e36-ec7a-4c3e-6969-08da535d6c3b X-MS-TrafficTypeDiagnostic: BN8PR12MB3265:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7XrMhoXo83uuMCtkcX8glwVlSXvnkkvuaDzBDj7lY/Hdu3FTnkpJTXWjg6l50rUUrEteQX57qV9x+PKddPFC/iUfvn+WMuG9PXD9kkp2YrT20PwOI/TCwH1F6Sd2u90BacZMiuhwid3y5BeVQ9OgEZ7vY9eQekyLU16t4gpzdWCbGBtbT3taYCUNQD5PKNcTaUrH0bwol8fLE0lLuJId3OC73NRFbPlW8OXtwhQh+qNmO8gET4CECzGyD2Qu1aiPKPcwcwDNP3fE+B1nTBldu9/Cyp8HVrlwCtgDy/LL2Ys13uO8nlGdSlZqMpwlbaqN1IlNvD0OBGPeKAtNZ1xFoEqH2vzzqZgKEdVJ3xaDl3yKFn7PGqKdeVcjYN41yxv9lRUDAmr6rxIz2U3VJJg777yr++KkiqURUSlLHhaZEgZ1jDYxIV46H9ZUItpQ8pyhZ5k4lTRhiPDPl3XN2yOczxRBw2LQbOBUGdRmAERHs2GiYCJ7sCpulb+KU5ebfG6XOZgvGVkHvfD0Eean3UMDX8cto9kDWnzZQcr7nslvY4+HcGN/Xp2eO1Qv4B8RC6YMOGpuNn1XD1iDNEVfCmM7X898+9HnmTi47UyqKyahhNNpZMg404IS03CKgc2966ZVFOEgGQe1yM+koZkmWwiLg2dbO3TlgjbRQDf8RKC4xWcTUKKruEb/6FXaV780FEd162Km4jhJ1NWr2Hwd3hZJ0Yyez3rjdLiCbEKNzX1xxBokAZLj7QMhkea/0tG5MJQeQJ1M3OpAhh22lAowBjFHyI/QeqG34hLASHeq0fU40W70wm9EsEQOHl2AqN5TLp+SnuZkuo5ZoaLDrXrbzmSCLEB0rxC3r03b1vzgCMAn+dk= X-Forefront-Antispam-Report: CIP:12.22.5.238; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230016)(4636009)(346002)(136003)(39860400002)(396003)(376002)(46966006)(36840700001)(40470700004)(966005)(36860700001)(336012)(6916009)(1076003)(70206006)(40460700003)(2906002)(54906003)(426003)(36756003)(316002)(16526019)(53546011)(86362001)(26005)(82740400003)(186003)(6286002)(6666004)(356005)(41300700001)(4326008)(47076005)(8936002)(5660300002)(8676002)(83380400001)(81166007)(40480700001)(2616005)(7696005)(55016003)(82310400005)(70586007)(478600001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2022 08:09:53.8149 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 86be9e36-ec7a-4c3e-6969-08da535d6c3b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.238]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT032.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3265 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/23/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/070f2b2b8a0da9f20601f1aea430f5fdddcf35a3 Thanks. Xueming Li --- >From 070f2b2b8a0da9f20601f1aea430f5fdddcf35a3 Mon Sep 17 00:00:00 2001 From: Mingxia Liu Date: Thu, 31 Mar 2022 02:33:33 +0000 Subject: [PATCH] app/testpmd: replace hardcoded min mbuf number with macro Cc: Xueming Li [ upstream commit 57d91f5b8dc589226a307560bd36181ac7a6b7df ] Add macro MIN_TOTAL_NUM_MBUFS (1024) to indicate what the value of total-num-mbufs should bigger than. Fixes: c87988187fdb ("app/testpmd: add --total-num-mbufs option") Signed-off-by: Mingxia Liu Acked-by: Yuying Zhang Acked-by: Ferruh Yigit --- app/test-pmd/parameters.c | 5 +++-- app/test-pmd/testpmd.h | 2 ++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index c842943796..f9b5c189cb 100644 --- a/app/test-pmd/parameters.c +++ b/app/test-pmd/parameters.c @@ -804,11 +804,12 @@ launch_args_parse(int argc, char** argv) } if (!strcmp(lgopts[opt_idx].name, "total-num-mbufs")) { n = atoi(optarg); - if (n > 1024) + if (n > MIN_TOTAL_NUM_MBUFS) param_total_num_mbufs = (unsigned)n; else rte_exit(EXIT_FAILURE, - "total-num-mbufs should be > 1024\n"); + "total-num-mbufs should be > %d\n", + MIN_TOTAL_NUM_MBUFS); } if (!strcmp(lgopts[opt_idx].name, "max-pkt-len")) { n = atoi(optarg); diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index 2d4dc05332..2a6312217d 100644 --- a/app/test-pmd/testpmd.h +++ b/app/test-pmd/testpmd.h @@ -64,6 +64,8 @@ #define NUMA_NO_CONFIG 0xFF #define UMA_NO_CONFIG 0xFF +#define MIN_TOTAL_NUM_MBUFS 1024 + typedef uint8_t lcoreid_t; typedef uint16_t portid_t; typedef uint16_t queueid_t; -- 2.35.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-06-21 15:37:52.744280180 +0800 +++ 0077-app-testpmd-replace-hardcoded-min-mbuf-number-with-m.patch 2022-06-21 15:37:49.121118214 +0800 @@ -1 +1 @@ -From 57d91f5b8dc589226a307560bd36181ac7a6b7df Mon Sep 17 00:00:00 2001 +From 070f2b2b8a0da9f20601f1aea430f5fdddcf35a3 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 57d91f5b8dc589226a307560bd36181ac7a6b7df ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -21 +23 @@ -index daf6a31b2b..641c9c767e 100644 +index c842943796..f9b5c189cb 100644 @@ -24 +26 @@ -@@ -940,11 +940,12 @@ launch_args_parse(int argc, char** argv) +@@ -804,11 +804,12 @@ launch_args_parse(int argc, char** argv) @@ -40 +42 @@ -index 67f253b30e..f04a9a11b4 100644 +index 2d4dc05332..2a6312217d 100644 @@ -43 +45 @@ -@@ -72,6 +72,8 @@ +@@ -64,6 +64,8 @@