From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28E57A0543 for ; Tue, 21 Jun 2022 10:11:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E4344281A; Tue, 21 Jun 2022 10:11:15 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2072.outbound.protection.outlook.com [40.107.236.72]) by mails.dpdk.org (Postfix) with ESMTP id B631542B70 for ; Tue, 21 Jun 2022 10:11:13 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VRoBPKtRGceeWUACj7B9IjhlhjV5h7Bcf2A1YZnIr06sLAGI2GE3Kb+CPH+CA4rIjQAWJCw2XVOzm0FH9GI2qCv8kkQ5mu5E6XIEVfv1zt3HxqC9OJm1BvRymjwb7suWhJ+8XjTRL9aDref/a5lv8khOMr93EiOSHa92YUf7kB/utyNHBvAEaa3QsU+8N8918BMHhZbIqqJRduIlbhZpkF41BOsyamWCOJrw+b0buWBE0ItrX1Mx6i3NSplngmoG+J//4LqTrdaP+ei8rX6I29g+EFfN6AOezwFHYK2iDzC6gMXGm+FSo+raFpikDGbx/lteVNdwpk/Fyt6hGHBxNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IcYYxuiXgkIewvThRS82x51bUDOoTFgULJKbh9goMcE=; b=YDErAl5aNKWuTqL6OMfIhGxSMNooltDjO7T7p8fCbrQuJC7sr7bR3KhK0oCKAys0iI7zwqzUu9ULwfoX8e8ntMNHLDQQ/B6XBIxexm7UKXW33jtbpu4GPQxTZ7i2eYo5TF/YoAQWSx54uooE1GdoxODkwfjxsdAk0c+l2IytqTVB7UZi/c2HtFVrfcZNaPVxN97ALu4rfcPRG2RRgAMJpTnFq0zbsdIL6Hvg75JrOfIYZu5fF99Xj/tgx5hTxAfhtcnaGGKm6eswFQrwYLb3OZfDjlodt6ui6Gdk39T+vcfZa2vogPCHGmvvo4cJuRNCyyrfgl6JCNN53o0fy7KceQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.235) smtp.rcpttodomain=xilinx.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IcYYxuiXgkIewvThRS82x51bUDOoTFgULJKbh9goMcE=; b=NVorglLm3yu1Ti/OWomSvFhdxeN7Vh7d6LTuXao/KqGxr0O59SDAO+xzCFPFdsrtDF6+vYCQ0NZ4RuVE1r7Ku2+Tsn+skxbsTdl2+9bAWw/9969XYlMGOBdVYgIKv6zqihBlxXGIOD0f8hgkECpl2smQK/NTLAMpHHOM9wkNw76l8bloLuUl8jQx/iWPdv1RJoLpamV5Zs3XTihYBdrI5SnpLwuyhNfNMKLcGCxPqTc/yz6ZFuD8hi3Xx79YMZZd9K3VZ3TXAZ79uHZmdAG4VjFVN8EHap0P+oUN4Ta2GVOB/BOKhjhCyYtwa3WD78nsfnE5ljVaLRzKmCSU5pRX9A== Received: from CO2PR04CA0200.namprd04.prod.outlook.com (2603:10b6:104:5::30) by BL1PR12MB5143.namprd12.prod.outlook.com (2603:10b6:208:31b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.15; Tue, 21 Jun 2022 08:11:11 +0000 Received: from CO1NAM11FT018.eop-nam11.prod.protection.outlook.com (2603:10b6:104:5:cafe::3c) by CO2PR04CA0200.outlook.office365.com (2603:10b6:104:5::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Tue, 21 Jun 2022 08:11:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.235) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.235 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.235; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (12.22.5.235) by CO1NAM11FT018.mail.protection.outlook.com (10.13.175.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5353.14 via Frontend Transport; Tue, 21 Jun 2022 08:11:11 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Tue, 21 Jun 2022 08:10:22 +0000 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 21 Jun 2022 01:10:20 -0700 From: Xueming Li To: "Min Hu (Connor)" CC: Thomas Monjalon , Ferruh Yigit , dpdk stable Subject: patch 'ethdev: fix port state when stop' has been queued to stable release 20.11.6 Date: Tue, 21 Jun 2022 11:02:29 +0300 Message-ID: <20220621080301.2315720-84-xuemingl@nvidia.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220621080301.2315720-1-xuemingl@nvidia.com> References: <20220621080301.2315720-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 76f96d54-8d28-4b73-ffab-08da535d9a4b X-MS-TrafficTypeDiagnostic: BL1PR12MB5143:EE_ X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mkBP6bN5jvHmmfznugndgy5c0UwXcp2dxY1Xdn0jm5lIHISlTs7nv6tNyOkDQg8tVcyQSpHgIY5KQURz8HkVo6/t53VQOi8MvcvFjpK8EbeS52mrUEh7km9w/nX1sk6w0wqSLcssvN4whRVeFj7j4a9H3vkph8hKA3MWL7owMR/uZ22OLzXAOqrjPgg4s+D9g8JKv/OJM7ipSls8yY30AB/dEHMsenoOKmzLxUrO3IvT3B9H2Vm3nqcJ1zsEPfj7B4Pu/0Fo3BfnnzokbOthMioChIKDxMhg6pH/mAIfdscu4lYPeGvU4H38tlNyADrR0DgLHdhVFL0tW0O5nTNwhDCTqYuw1Ziy2FEqVYU/Ah9atdest9vWxK7EyaywXWluNKlTVSy1Qn4AcgMj4QXqhzoRcMoD30L6KBUxw4MHfgzxcySKpQDtT11ZvU8KqsZHxCS6N1O7zGHGr8Lt74yreiMi8cJeyalhBjT+V26aRh0GF78jWzd+hYy6zND5nYk8IKX+6v0oyCZxOJ2glZEojEvV/0xa6RwpI+a8blJ9MNjma17gzmh5RAPxyZCxO3tb4dBIb7/NYAJaVXyB0g9GRugpyJNfkQXpKdBoMItWGZXgt3JqQ2nFx62hLhZAl5uV1+695aW+KyNKXQ2mLHD8XlpA3xq9pS9h+nC+uYPSW8Txq166fay1BwIoqFaHunkcqsEiTvpFYNWl5FNTuCXJI4IgXSgxkPhbzHDFBSEGl/Fu/0Z6LHwM+t/RtEZPE8Dlnz6quG6mubdtI1AIvWjvl75XMoDCWAQqrVk/X7oCaatm/4oiVVC37OGSdAiCjtdGjPWrHOXgiXK9BJWAmOYK/1UDtgqrUN5IhKCLyb415pM= X-Forefront-Antispam-Report: CIP:12.22.5.235; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230016)(4636009)(136003)(396003)(376002)(346002)(39860400002)(40470700004)(46966006)(36840700001)(70206006)(356005)(2616005)(1076003)(336012)(36756003)(47076005)(478600001)(426003)(186003)(16526019)(70586007)(40460700003)(7696005)(316002)(5660300002)(53546011)(966005)(81166007)(83380400001)(4326008)(86362001)(41300700001)(82310400005)(82740400003)(6916009)(36860700001)(2906002)(55016003)(6286002)(8676002)(54906003)(8936002)(40480700001)(26005)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2022 08:11:11.0988 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 76f96d54-8d28-4b73-ffab-08da535d9a4b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.235]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT018.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5143 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/23/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/d096c590deef6b8352eec0ca5c67fb9cb81b39a7 Thanks. Xueming Li --- >From d096c590deef6b8352eec0ca5c67fb9cb81b39a7 Mon Sep 17 00:00:00 2001 From: "Min Hu (Connor)" Date: Tue, 3 May 2022 18:02:17 +0800 Subject: [PATCH] ethdev: fix port state when stop Cc: Xueming Li [ upstream commit 74b74269978c2790bc49238029e00b7c6e81c450 ] Currently, 'dev_started' is always set to be 0 when dev stop, whether it succeeded or failed. This is unreasonable and this patch fixed it. Fixes: 62024eb82756 ("ethdev: change stop operation callback to return int") Signed-off-by: Min Hu (Connor) Acked-by: Thomas Monjalon Acked-by: Ferruh Yigit --- lib/librte_ethdev/rte_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index 259498342d..ac88c4484e 100644 --- a/lib/librte_ethdev/rte_ethdev.c +++ b/lib/librte_ethdev/rte_ethdev.c @@ -1785,8 +1785,9 @@ rte_eth_dev_stop(uint16_t port_id) return 0; } - dev->data->dev_started = 0; ret = (*dev->dev_ops->dev_stop)(dev); + if (ret == 0) + dev->data->dev_started = 0; rte_ethdev_trace_stop(port_id, ret); return ret; -- 2.35.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-06-21 15:37:53.006656095 +0800 +++ 0083-ethdev-fix-port-state-when-stop.patch 2022-06-21 15:37:49.174451737 +0800 @@ -1 +1 @@ -From 74b74269978c2790bc49238029e00b7c6e81c450 Mon Sep 17 00:00:00 2001 +From d096c590deef6b8352eec0ca5c67fb9cb81b39a7 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 74b74269978c2790bc49238029e00b7c6e81c450 ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -16 +18 @@ - lib/ethdev/rte_ethdev.c | 3 ++- + lib/librte_ethdev/rte_ethdev.c | 3 ++- @@ -19,7 +21,7 @@ -diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c -index a175867651..fe64f8d39d 100644 ---- a/lib/ethdev/rte_ethdev.c -+++ b/lib/ethdev/rte_ethdev.c -@@ -1533,8 +1533,9 @@ rte_eth_dev_stop(uint16_t port_id) - /* point fast-path functions to dummy ones */ - eth_dev_fp_ops_reset(rte_eth_fp_ops + port_id); +diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c +index 259498342d..ac88c4484e 100644 +--- a/lib/librte_ethdev/rte_ethdev.c ++++ b/lib/librte_ethdev/rte_ethdev.c +@@ -1785,8 +1785,9 @@ rte_eth_dev_stop(uint16_t port_id) + return 0; + }