From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01CF1A0543 for ; Tue, 21 Jun 2022 10:11:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CCC4742B9B; Tue, 21 Jun 2022 10:11:17 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2042.outbound.protection.outlook.com [40.107.236.42]) by mails.dpdk.org (Postfix) with ESMTP id 1C66C42B77 for ; Tue, 21 Jun 2022 10:11:17 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AyVN3ArKmh8XCC7IsJd5kR1cTJT2HRxda4tFsDgtUq2EsoCp8wj3+COLYtj9FrqgkPMLhwlLHAvJZq5u252OcMjQyh86oQgzb6PeRBlpPr1csjMBaTv2sBgGhJpt0D/T9g5E7OWDpEd7J2bc0lFf6TpcMIxqsIbJL1jS/7vgA+KXwW2Mhn6ONhcFSdSXjB8XC3/fLI4KTWDUm8WcYteC4L09Gz9apQ9NXJDUZlr0WTV9gV3TRjktCMnXL3HKEJI0asynzvnUCdABD7QAoE1r5vrXZzNc7Fp7/hKOh2DEG7Jwc/fUdYhzTX3JiBLi3qZYO05IA40CgSxgBVdSzJJWIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/itMaqSPv9+zuKGXpbYBdUGRbfqm42+zMvC/97Es3LA=; b=enYqrJPxYiJj91uJ2/rPDdzEM/GQ6zzD5mvS07uMr6ejxeYl+G+FHhFo/AxnMFvmf5cWndiBAEAjQvxYO+nyHsbCx6+0DWBGetJ1N2J5qukRqn8ijs5JuzKhbx/Wb0suh1Div3C1t8napTI8iKEvPUBbGUF8AmjF5VnVbS+SjzQla8csIP1xyG2xfeCwzawRUAKPxbQNqu4A6jrKO9IG7PC8G/cBDbm8NGgFhE7MGYW+tsx1OcFSSkYJFy8+8rQUYajO2RM0D4uoiLgvuBucGvlNs9GjBcLyUmEUXQ7SUG7A5EiAr08MkBh2Ri7/0TNpdvSm30fL505Aan5HuyaC4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.235) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/itMaqSPv9+zuKGXpbYBdUGRbfqm42+zMvC/97Es3LA=; b=LoHtnZN7v3ixlmIxJ0GPWevrqSNNeEz2uijxHYCu2HjzLT/K8yYtUmIPv7p55xr79bJ8Ef8J0zKRynYR857GBXnrb9GlOXbPB9fqJKjSwCHQJjgOgDWaicI4DNakaeimrw31bgFvnaRxd4mQOCteEAcz3ydJtarPIywzzVbUAurU+hdLgUlJUnqSVNndmQscXxqJYCSG/CUluFcFY5RCqcqlN0YqK9TeVUSsbKodXpVLT8a2qM0dNAeL3C28PTJnlwSM4d0/7F36nPfmT7UTRrZLjj3TLZcIWyfe55rPaSpvZx0w7xhjdxaM3XsegbwXVRwJMQkTV7oK/n7w25JL0Q== Received: from CO2PR04CA0197.namprd04.prod.outlook.com (2603:10b6:104:5::27) by MN2PR12MB4831.namprd12.prod.outlook.com (2603:10b6:208:1b9::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.16; Tue, 21 Jun 2022 08:11:15 +0000 Received: from CO1NAM11FT018.eop-nam11.prod.protection.outlook.com (2603:10b6:104:5:cafe::f8) by CO2PR04CA0197.outlook.office365.com (2603:10b6:104:5::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Tue, 21 Jun 2022 08:11:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.235) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.235 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.235; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (12.22.5.235) by CO1NAM11FT018.mail.protection.outlook.com (10.13.175.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5353.14 via Frontend Transport; Tue, 21 Jun 2022 08:11:14 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Tue, 21 Jun 2022 08:10:47 +0000 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 21 Jun 2022 01:10:45 -0700 From: Xueming Li To: David Marchand CC: Ajit Khaparde , dpdk stable Subject: patch 'net/bnxt: fix compatibility with some old firmwares' has been queued to stable release 20.11.6 Date: Tue, 21 Jun 2022 11:02:33 +0300 Message-ID: <20220621080301.2315720-88-xuemingl@nvidia.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220621080301.2315720-1-xuemingl@nvidia.com> References: <20220621080301.2315720-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3031bff9-30a3-42d8-7944-08da535d9c96 X-MS-TrafficTypeDiagnostic: MN2PR12MB4831:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qnqJCeLwM0sR554CrJDLRlM4Ox5CEnXnoCFx+qMrj6iOfOkn7FI/siMWkv77Nt4I4R5aM9SxoAcwBDwoe7hy/e/PrcUM/RCJ2rzwTNxT9oFy9C0wrdpqQ8+h+8SyJuQn7pDKhDcs5OxL5jAT1wxKDPZzdFzuURvkdcPRZGDmG7Ae1+SkaUs/3AF47pbOpRjdREk4OwZQ6pgK+V5uV99qW/hfYEwfo4gMsY4HMw2Uu4NfucG6uGk6tJ/jgRHDx/0ibxyXk3IjvQihAha6EDBiIw/AXE0G2+sL7qx7DMA4icwTy5g5gaUjAVuPwDbFkac/7wCierQ3to77fiZ0/Ay7eKvfXL6nQBR5cFaICL+KAy/yUhAu9AoMZqnLj3U5y7Oj/f9dxvP7kWV4pFiQLezn8Yn9oHRN3Mp2t501SNUrg456G86G7Cq9YgmkJgYliczh72su+Dltav0049ZdKBFkP2rFRpOTb7oFhBsm2mv7biwc+iGHeNOleCOJ6mDKL5cQB1H39XEmnkv1JULYkc2davwI/fJJ0dAp0gxIOESHUC6CGZWAbRmxzjcqVLs4KtLhtqPY8+NjhDLiih+0q52nem7P56IAWbWgGmi8uO6psN+rcANVmkeN/b1QgVQeZab6sUtaDYQDhT7K2TBQYs2mtUFTkroYIvvUwUroMvFIVWf/pr6cu/TW0vBAH//5SzSx/eOC8WMY9tTcjLpcFvQC+z2ogu+LqJArzxHhht0njCR7edtWywejwlCPN/UXAPnvwSYFBatkA4PeHrsdC0fLOjHu+Gr2AeIPpufUtN7vg8kOVYg0X3HG849LZbaBS7bXPmqfSTjmVGIX2Ga5e06E9lYB86k/R0zHQnVZJ1P2OiU= X-Forefront-Antispam-Report: CIP:12.22.5.235; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230016)(4636009)(346002)(376002)(136003)(39860400002)(396003)(36840700001)(46966006)(40470700004)(336012)(70206006)(6666004)(2616005)(1076003)(82740400003)(426003)(81166007)(41300700001)(7696005)(53546011)(47076005)(70586007)(26005)(36860700001)(6286002)(186003)(16526019)(356005)(83380400001)(82310400005)(86362001)(8936002)(55016003)(8676002)(36756003)(5660300002)(40480700001)(4326008)(2906002)(316002)(40460700003)(54906003)(478600001)(6916009)(966005)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2022 08:11:14.9267 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3031bff9-30a3-42d8-7944-08da535d9c96 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.235]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT018.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4831 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/23/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/ff874e673ad8161edf3c3eedc6a7c61a86f05076 Thanks. Xueming Li --- >From ff874e673ad8161edf3c3eedc6a7c61a86f05076 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Fri, 18 Mar 2022 16:03:31 +0100 Subject: [PATCH] net/bnxt: fix compatibility with some old firmwares Cc: Xueming Li [ upstream commit a43d0129579034af06314b6603d92a866d809eeb ] This reverts commit 3972281f47b2cc0cf844698885f0e6b4228c0975. Reported by Red Hat QE: with older firmware versions (at least versions 20.6.112.0 and 20.6.143.0), initialisation never succeeds following this change. Revert it for now, waiting for a more complete fix. Fixes: 3972281f47b2 ("net/bnxt: fix device readiness check") Signed-off-by: David Marchand Acked-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 6a3d81f223..deebea428a 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -1122,11 +1122,6 @@ int bnxt_hwrm_ver_get(struct bnxt *bp, uint32_t timeout) else HWRM_CHECK_RESULT(); - if (resp->flags & HWRM_VER_GET_OUTPUT_FLAGS_DEV_NOT_RDY) { - rc = -EAGAIN; - goto error; - } - PMD_DRV_LOG(INFO, "%d.%d.%d:%d.%d.%d.%d\n", resp->hwrm_intf_maj_8b, resp->hwrm_intf_min_8b, resp->hwrm_intf_upd_8b, resp->hwrm_fw_maj_8b, @@ -5959,10 +5954,6 @@ int bnxt_hwrm_poll_ver_get(struct bnxt *bp) rc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB); HWRM_CHECK_RESULT_SILENT(); - - if (resp->flags & HWRM_VER_GET_OUTPUT_FLAGS_DEV_NOT_RDY) - rc = -EAGAIN; - HWRM_UNLOCK(); return rc; -- 2.35.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-06-21 15:37:53.169463168 +0800 +++ 0087-net-bnxt-fix-compatibility-with-some-old-firmwares.patch 2022-06-21 15:37:49.184451772 +0800 @@ -1 +1 @@ -From a43d0129579034af06314b6603d92a866d809eeb Mon Sep 17 00:00:00 2001 +From ff874e673ad8161edf3c3eedc6a7c61a86f05076 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit a43d0129579034af06314b6603d92a866d809eeb ] @@ -14 +16,0 @@ -Cc: stable@dpdk.org @@ -23 +25 @@ -index 6e4753c508..9eb8b8d56d 100644 +index 6a3d81f223..deebea428a 100644 @@ -26 +28 @@ -@@ -1249,11 +1249,6 @@ int bnxt_hwrm_ver_get(struct bnxt *bp, uint32_t timeout) +@@ -1122,11 +1122,6 @@ int bnxt_hwrm_ver_get(struct bnxt *bp, uint32_t timeout) @@ -38 +40 @@ -@@ -6154,10 +6149,6 @@ int bnxt_hwrm_poll_ver_get(struct bnxt *bp) +@@ -5959,10 +5954,6 @@ int bnxt_hwrm_poll_ver_get(struct bnxt *bp)