From: Xueming Li <xuemingl@nvidia.com>
To: Yuan Wang <yuanx.wang@intel.com>
Cc: Chenbo Xia <chenbo.xia@intel.com>, dpdk stable <stable@dpdk.org>
Subject: patch 'examples/vhost: fix crash when no VMDq' has been queued to stable release 20.11.6
Date: Tue, 21 Jun 2022 11:02:36 +0300 [thread overview]
Message-ID: <20220621080301.2315720-91-xuemingl@nvidia.com> (raw)
In-Reply-To: <20220621080301.2315720-1-xuemingl@nvidia.com>
Hi,
FYI, your patch has been queued to stable release 20.11.6
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/23/22. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk
This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/27dda79b5d23c2badbf870e2a4edcc3bf430c118
Thanks.
Xueming Li <xuemingl@nvidia.com>
---
From 27dda79b5d23c2badbf870e2a4edcc3bf430c118 Mon Sep 17 00:00:00 2001
From: Yuan Wang <yuanx.wang@intel.com>
Date: Wed, 18 May 2022 21:36:33 +0800
Subject: [PATCH] examples/vhost: fix crash when no VMDq
Cc: Xueming Li <xuemingl@nvidia.com>
[ upstream commit 6f3d83c7f207d435d960ad881f127e9971a81069 ]
If the VMDq limits is 0, a divide-by-zero error occurs.
This patch replaces throwing a floating point exception with
a normal error message.
Fixes: d19533e86f ("examples/vhost: copy old vhost example")
Signed-off-by: Yuan Wang <yuanx.wang@intel.com>
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
---
examples/vhost/main.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index fc07b31b2e..24e37f7ce5 100644
--- a/examples/vhost/main.c
+++ b/examples/vhost/main.c
@@ -255,6 +255,10 @@ port_init(uint16_t port)
return retval;
}
+ if (dev_info.max_vmdq_pools == 0) {
+ RTE_LOG(ERR, VHOST_PORT, "Failed to get VMDq info.\n");
+ return -1;
+ }
rxconf = &dev_info.default_rxconf;
txconf = &dev_info.default_txconf;
--
2.35.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2022-06-21 15:37:53.293101523 +0800
+++ 0090-examples-vhost-fix-crash-when-no-VMDq.patch 2022-06-21 15:37:49.187785117 +0800
@@ -1 +1 @@
-From 6f3d83c7f207d435d960ad881f127e9971a81069 Mon Sep 17 00:00:00 2001
+From 27dda79b5d23c2badbf870e2a4edcc3bf430c118 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl@nvidia.com>
+
+[ upstream commit 6f3d83c7f207d435d960ad881f127e9971a81069 ]
@@ -11 +13,0 @@
-Cc: stable@dpdk.org
@@ -20 +22 @@
-index 5bc34b0c52..e7fee5aa1b 100644
+index fc07b31b2e..24e37f7ce5 100644
@@ -23 +25 @@
-@@ -431,6 +431,10 @@ port_init(uint16_t port)
+@@ -255,6 +255,10 @@ port_init(uint16_t port)
next prev parent reply other threads:[~2022-06-21 8:11 UTC|newest]
Thread overview: 180+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 8:01 patch " Xueming Li
2022-06-21 8:01 ` patch 'crypto/ipsec_mb: fix length and offset settings' " Xueming Li
2022-06-21 8:01 ` patch 'crypto/ipsec_mb: fix GMAC parameters setting' " Xueming Li
2022-06-21 8:01 ` patch 'eal/windows: fix data race when creating threads' " Xueming Li
2022-06-21 8:01 ` patch 'eal/windows: add missing C++ include guards' " Xueming Li
2022-06-21 8:01 ` patch 'examples/bond: fix invalid use of trylock' " Xueming Li
2022-06-21 8:01 ` patch 'net/iavf: fix HW ring scan method selection' " Xueming Li
2022-06-21 8:01 ` patch 'net/i40e: populate error in flow director parser' " Xueming Li
2022-06-21 8:01 ` patch 'net/netvsc: fix calculation of checksums based on mbuf flag' " Xueming Li
2022-06-21 8:01 ` patch 'net/mlx5: fix Tx when inlining is impossible' " Xueming Li
2022-06-21 8:01 ` patch 'net/mlx5: fix GTP handling in header modify action' " Xueming Li
2022-06-21 8:01 ` patch 'net/mlx5: fix Rx/Tx stats concurrency' " Xueming Li
2022-06-21 8:01 ` patch 'test/table: fix buffer overflow on lpm entry' " Xueming Li
2022-06-21 8:01 ` patch 'mem: skip attaching external memory in secondary process' " Xueming Li
2022-06-21 8:01 ` patch 'eal: fix C++ include for device event and DMA' " Xueming Li
2022-06-21 8:01 ` patch 'crypto/dpaa_sec: fix digest size' " Xueming Li
2022-06-21 8:01 ` patch 'crypto/dpaa2_sec: fix fle buffer leak' " Xueming Li
2022-06-21 8:01 ` patch 'crypto/dpaa2_sec: fix buffer pool ID check' " Xueming Li
2022-06-21 8:01 ` patch 'crypto/dpaa_sec: fix secondary process probing' " Xueming Li
2022-06-21 8:01 ` patch 'crypto/dpaa2_sec: fix operation status for simple FD' " Xueming Li
2022-06-21 8:01 ` patch 'common/dpaax: fix short MAC-I IV calculation for ZUC' " Xueming Li
2022-06-21 8:01 ` patch 'examples/l2fwd-crypto: fix stats refresh rate' " Xueming Li
2022-06-21 8:01 ` patch 'test/hash: report non HTM numbers for single thread' " Xueming Li
2022-06-21 8:01 ` patch 'net/nfp: remove unneeded header inclusion' " Xueming Li
2022-06-21 8:01 ` patch 'net/bonding: fix RSS key config with extended key length' " Xueming Li
2022-06-21 8:01 ` patch 'net/cxgbe: fix port ID in Rx mbuf' " Xueming Li
2022-06-21 8:01 ` patch 'net/cxgbe: fix Tx queue stuck with mbuf chain coalescing' " Xueming Li
2022-06-21 8:01 ` patch 'net/vhost: fix access to freed memory' " Xueming Li
2022-06-21 8:01 ` patch 'net/virtio: restore some optimisations with AVX512' " Xueming Li
2022-06-21 8:01 ` patch 'net/vhost: fix TSO feature default disablement' " Xueming Li
2022-06-21 8:01 ` patch 'vhost: fix missing virtqueue lock protection' " Xueming Li
2022-06-21 8:01 ` patch 'vdpa/mlx5: fix interrupt trash that leads to crash' " Xueming Li
2022-06-21 8:01 ` patch 'vdpa/mlx5: fix dead loop when process interrupted' " Xueming Li
2022-06-21 8:01 ` patch 'net/dpaa: fix event queue detach' " Xueming Li
2022-06-21 8:01 ` patch 'doc: update matching versions in ice guide' " Xueming Li
2022-06-21 8:01 ` patch 'net/bonding: fix stopping non-active slaves' " Xueming Li
2022-06-21 8:01 ` patch 'net/bonding: fix slave stop and remove on port close' " Xueming Li
2022-06-21 8:01 ` patch 'net/hns3: fix RSS disable' " Xueming Li
2022-06-21 8:01 ` patch 'net/hns3: fix rollback on RSS hash update' " Xueming Li
2022-06-21 8:01 ` patch 'net/hns3: remove redundant RSS tuple field' " Xueming Li
2022-06-21 8:01 ` patch 'net/hns3: remove unnecessary RSS switch' " Xueming Li
2022-06-21 8:01 ` patch 'app/testpmd: check statistics query before printing' " Xueming Li
2022-06-21 8:01 ` patch 'net/bnxt: fix reordering in NEON Rx' " Xueming Li
2022-06-21 8:01 ` patch 'net/bnxt: remove unused macro' " Xueming Li
2022-06-21 8:01 ` patch 'net/bnxt: fix device capability reporting' " Xueming Li
2022-06-21 8:01 ` patch 'net/bnxt: fix Rx configuration' " Xueming Li
2022-06-21 8:01 ` patch 'net/bnxt: fix ring group on Rx restart' " Xueming Li
2022-06-21 8:01 ` patch 'net/bnxt: avoid unnecessary endianness conversion' " Xueming Li
2022-06-21 8:01 ` patch 'net/bnxt: fix speed autonegotiation' " Xueming Li
2022-06-21 8:01 ` patch 'net/bnxt: force PHY update on certain configurations' " Xueming Li
2022-06-21 8:01 ` patch 'net/bnxt: fix link status when port is stopped' " Xueming Li
2022-06-21 8:01 ` patch 'net/bnxt: recheck FW readiness if in reset process' " Xueming Li
2022-06-21 8:01 ` patch 'net/bnxt: fix freeing VNIC filters' " Xueming Li
2022-06-21 8:01 ` patch 'eal/x86: fix unaligned access for small memcpy' " Xueming Li
2022-06-21 8:02 ` patch 'examples/l3fwd: fix scalar LPM' " Xueming Li
2022-06-21 8:02 ` patch 'test/ring: remove excessive inlining' " Xueming Li
2022-06-21 8:02 ` patch 'eal/freebsd: fix use of newer cpuset macros' " Xueming Li
2022-06-21 8:02 ` patch 'test: avoid hang if queues are full and Tx fails' " Xueming Li
2022-06-21 8:02 ` patch 'acl: fix rules with 8-byte field size' " Xueming Li
2022-06-21 8:02 ` patch 'rib: fix traversal with /32 route' " Xueming Li
2022-06-21 8:02 ` patch 'mbuf: dump outer VLAN' " Xueming Li
2022-06-21 8:02 ` patch 'doc: fix API index Markdown syntax' " Xueming Li
2022-06-21 8:02 ` patch 'devtools: fix null test for NUMA systems' " Xueming Li
2022-06-21 8:02 ` patch 'examples/ipsec-secgw: fix uninitialized memory access' " Xueming Li
2022-06-21 8:02 ` patch 'examples/ipsec-secgw: fix promiscuous mode option' " Xueming Li
2022-06-21 8:02 ` patch 'test/crypto: fix null check for ZUC authentication' " Xueming Li
2022-06-21 8:02 ` patch 'drivers/crypto: fix warnings for OpenSSL version' " Xueming Li
2022-06-21 8:02 ` patch 'doc: add missing auth algo for IPsec example' " Xueming Li
2022-06-21 8:02 ` patch 'app/testpmd: perform SW IP checksum for GRO/GSO packets' " Xueming Li
2022-06-21 8:02 ` patch 'app/testpmd: remove useless pointer checks' " Xueming Li
2022-06-21 8:02 ` patch 'ethdev: clarify null location case in xstats get' " Xueming Li
2022-06-21 8:02 ` patch 'net/hns3: fix xstats get return if xstats is null' " Xueming Li
2022-06-21 8:02 ` patch 'net/ipn3ke: " Xueming Li
2022-06-21 8:02 ` patch 'net/mvpp2: " Xueming Li
2022-06-21 8:02 ` patch 'net/axgbe: " Xueming Li
2022-06-21 8:02 ` patch 'ethdev: fix memory leak in xstats telemetry' " Xueming Li
2022-06-21 8:02 ` patch 'ethdev: fix possible null pointer access' " Xueming Li
2022-06-21 8:02 ` patch 'app/testpmd: replace hardcoded min mbuf number with macro' " Xueming Li
2022-06-21 8:02 ` patch 'app/testpmd: fix metering and policing command for RFC4115' " Xueming Li
2022-06-21 8:02 ` patch 'ethdev: prohibit polling stopped queue' " Xueming Li
2022-06-21 8:02 ` patch 'app/testpmd: do not poll stopped queues' " Xueming Li
2022-06-21 8:02 ` patch 'net/bonding: fix mbuf fast free usage' " Xueming Li
2022-06-21 8:02 ` patch 'net/memif: fix overwriting of head segment' " Xueming Li
2022-06-21 8:02 ` patch 'ethdev: fix port state when stop' " Xueming Li
2022-06-21 8:02 ` patch 'net/txgbe: fix max number of queues for SR-IOV' " Xueming Li
2022-06-21 8:02 ` patch 'net/nfp: fix disabling VLAN stripping' " Xueming Li
2022-06-21 8:02 ` patch 'ethdev: fix port close in secondary process' " Xueming Li
2022-06-21 8:02 ` patch 'net/bnxt: fix compatibility with some old firmwares' " Xueming Li
2022-06-21 8:02 ` patch 'doc: fix vhost multi-queue reconnection' " Xueming Li
2022-06-21 8:02 ` patch 'vhost: fix deadlock when message handling failed' " Xueming Li
2022-06-21 8:02 ` Xueming Li [this message]
2022-06-21 8:02 ` patch 'net/mlx5: fix Tx recovery' " Xueming Li
2022-06-21 8:02 ` patch 'kni: fix build with Linux 5.18' " Xueming Li
2022-06-21 8:02 ` patch 'net/iavf: fix data path selection' " Xueming Li
2022-06-21 8:02 ` patch 'net/ixgbe: add option for link up check on pin SDP3' " Xueming Li
2022-06-21 8:02 ` patch 'net/ice/base: fix getting sched node from ID type' " Xueming Li
2022-06-21 8:02 ` patch 'net/ice: fix MTU info for DCF' " Xueming Li
2022-06-21 8:02 ` patch 'net/i40e: fix max frame size config at port level' " Xueming Li
2022-06-21 8:02 ` patch 'net/iavf: fix queue start exception handling' " Xueming Li
2022-06-21 8:02 ` patch 'net/iavf: fix mbuf release in multi-process' " Xueming Li
2022-06-21 8:02 ` patch 'net/iavf: fix Rx queue interrupt setting' " Xueming Li
2022-06-21 8:02 ` patch 'doc: update matching versions in i40e guide' " Xueming Li
2022-06-21 8:02 ` patch 'net/ice: fix outer L4 checksum in scalar Rx' " Xueming Li
2022-06-21 8:02 ` patch 'net/iavf: increase reset complete wait count' " Xueming Li
2022-06-21 8:02 ` patch 'examples/dma: fix Tx drop statistics' " Xueming Li
2022-06-21 8:02 ` patch 'raw/ifpga: unregister interrupt on close' " Xueming Li
2022-06-21 8:02 ` patch 'bus/fslmc: fix VFIO setup' " Xueming Li
2022-06-21 8:02 ` patch 'doc: fix formatting and link in BPF library guide' " Xueming Li
2022-06-21 8:02 ` patch 'app/testpmd: fix packet segment allocation' " Xueming Li
2022-06-21 8:02 ` patch 'app/testpmd: fix multicast address pool leak' " Xueming Li
2022-06-21 8:02 ` patch 'kni: use dedicated function to set random MAC address' " Xueming Li
2022-06-21 8:02 ` patch 'kni: use dedicated function to set " Xueming Li
2022-06-21 8:02 ` patch 'raw/ifpga: remove virtual devices on close' " Xueming Li
2022-06-21 8:02 ` patch 'vhost: fix async access' " Xueming Li
2022-06-21 8:03 ` patch 'net/bnxt: fix tunnel stateless offloads' " Xueming Li
2022-06-21 8:03 ` patch 'net/mlx5: fix RSS hash types adjustment' " Xueming Li
2022-07-20 8:20 ` patch 'vdpa/ifc: fix build with GCC 12' " Xueming Li
2022-07-20 8:20 ` patch 'app/flow-perf: " Xueming Li
2022-07-20 8:20 ` patch 'trace: fix init with long file prefix' " Xueming Li
2022-07-20 8:20 ` patch 'eal/x86: drop export of internal alignment macro' " Xueming Li
2022-07-20 8:20 ` patch 'baseband/acc100: update companion PF configure function' " Xueming Li
2022-07-20 8:20 ` patch 'baseband/acc100: add protection for some negative scenario' " Xueming Li
2022-07-20 8:20 ` patch 'baseband/acc100: remove RTE prefix for internal macros' " Xueming Li
2022-07-20 8:20 ` patch 'common/cpt: fix build with GCC 12' " Xueming Li
2022-07-20 8:20 ` patch 'test/ipsec: " Xueming Li
2022-07-20 8:20 ` patch 'crypto/scheduler: fix queue pair in scheduler failover' " Xueming Li
2022-07-20 8:20 ` patch 'test/crypto: fix cipher offset for ZUC' " Xueming Li
2022-07-20 8:20 ` patch 'test/ipsec: fix performance test' " Xueming Li
2022-07-20 8:20 ` patch 'eventdev/eth_tx: fix adapter creation' " Xueming Li
2022-07-20 8:20 ` patch 'net/bonding: fix RSS inconsistency between ports' " Xueming Li
2022-07-20 8:20 ` patch 'test/bonding: fix RSS test when disable RSS' " Xueming Li
2022-07-20 8:20 ` patch 'net/hns3: fix an unreasonable memset' " Xueming Li
2022-07-20 8:20 ` patch 'net/hns3: remove duplicate definition' " Xueming Li
2022-07-20 8:20 ` patch 'net/hns3: fix return value for unsupported tuple' " Xueming Li
2022-07-20 8:20 ` patch 'app/testpmd: fix bonding slave devices not released' " Xueming Li
2022-07-20 8:20 ` patch 'net/txgbe: fix register polling' " Xueming Li
2022-07-20 8:20 ` patch 'app/testpmd: revert MAC update in checksum forwarding' " Xueming Li
2022-07-20 8:20 ` patch 'vhost: fix missing enqueue pseudo-header calculation' " Xueming Li
2022-07-20 8:20 ` patch 'vhost/crypto: fix build with GCC 12' " Xueming Li
2022-07-20 8:20 ` patch 'vhost/crypto: fix descriptor processing' " Xueming Li
2022-07-20 8:20 ` patch 'malloc: fix allocation of almost hugepage size' " Xueming Li
2022-07-20 8:20 ` patch 'config: fix C++ cross compiler for Arm and PPC' " Xueming Li
2022-07-20 8:20 ` patch 'ci: enable C++ check " Xueming Li
2022-07-20 8:20 ` patch 'net/octeontx: fix port close' " Xueming Li
2022-07-20 8:20 ` patch 'net/qede: fix build with GCC 13' " Xueming Li
2022-07-20 8:20 ` patch 'net/ice/base: fix build with GCC 12' " Xueming Li
2022-07-20 8:21 ` patch 'net/qede: " Xueming Li
2022-07-20 8:21 ` patch 'net/mlx5: fix build with clang 14' " Xueming Li
2022-07-20 8:21 ` patch 'net/mlx5: fix RSS expansion for patterns with ICMP item' " Xueming Li
2022-07-20 8:21 ` patch 'net/mlx5: fix stack buffer overflow in drop action' " Xueming Li
2022-07-20 8:21 ` patch 'raw/ioat: fix build when ioat dmadev enabled' " Xueming Li
2022-07-20 8:21 ` patch 'rib: fix references for IPv6 implementation' " Xueming Li
2022-07-20 8:21 ` patch 'test/hash: fix out of bound access' " Xueming Li
2022-07-20 8:21 ` patch 'app/procinfo: show all non-owned ports' " Xueming Li
2022-07-20 8:21 ` patch 'test: check memory allocation for CRC' " Xueming Li
2022-07-20 8:21 ` patch 'net/hns3: fix descriptors check with SVE' " Xueming Li
2022-07-20 8:21 ` patch 'examples/distributor: fix distributor on Rx core' " Xueming Li
2022-07-20 8:21 ` patch 'doc: add more instructions for running as non-root' " Xueming Li
2022-08-01 12:21 ` Dmitry Kozlyuk
2022-07-20 8:21 ` patch 'net/bnxt: fix switch domain allocation' " Xueming Li
2022-07-20 8:21 ` patch 'net/bnxt: allow Tx only or Rx only' " Xueming Li
2022-07-20 8:21 ` patch 'net/bnxt: fix setting forced speed' " Xueming Li
2022-07-20 8:21 ` patch 'test/crypto: fix authentication IV for ZUC SGL' " Xueming Li
2022-07-20 8:21 ` patch 'test/crypto: fix ZUC vector IV format' " Xueming Li
2022-07-20 8:21 ` patch 'test/crypto: fix SNOW3G " Xueming Li
2022-07-20 8:21 ` patch 'baseband/acc100: remove prefix of internal file' " Xueming Li
2022-07-20 8:21 ` patch 'examples/fips_validation: handle empty payload' " Xueming Li
2022-07-20 8:21 ` patch 'crypto/qat: fix DOCSIS crash' " Xueming Li
2022-07-20 8:21 ` patch 'doc: fix grammar and formatting in compressdev guide' " Xueming Li
2022-07-20 8:21 ` patch 'doc: fix grammar and parameters in l2fwd-crypto " Xueming Li
2022-07-20 8:21 ` patch 'eventdev/eth_tx: fix queue delete' " Xueming Li
2022-07-20 8:21 ` patch 'app/testpmd: fix supported RSS offload display' " Xueming Li
2022-07-20 8:21 ` patch 'net/netvsc: fix vmbus device reference in multi-process' " Xueming Li
2022-07-20 8:21 ` patch 'doc: fix readability in vhost guide' " Xueming Li
2022-07-20 8:21 ` patch 'net/vhost: fix deadlock on vring state change' " Xueming Li
2022-07-20 8:21 ` patch 'vhost: add some trailing newline in log messages' " Xueming Li
2022-07-20 8:21 ` patch 'net/igc: support multi-process' " Xueming Li
2022-07-20 8:21 ` patch 'service: fix lingering active status' " Xueming Li
2022-07-20 8:21 ` patch 'gro: fix identifying fragmented packets' " Xueming Li
2022-07-20 8:21 ` patch 'examples/link_status_interrupt: fix stats refresh rate' " Xueming Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220621080301.2315720-91-xuemingl@nvidia.com \
--to=xuemingl@nvidia.com \
--cc=chenbo.xia@intel.com \
--cc=stable@dpdk.org \
--cc=yuanx.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).