From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B25C9A0032 for ; Fri, 24 Jun 2022 17:02:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AD5CD415D7; Fri, 24 Jun 2022 17:02:22 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A10E9415D7 for ; Fri, 24 Jun 2022 17:02:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656082940; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KTVfz4bMHTjkmaXEtCOhct0RH66dGJRFg+EJZ39kvkQ=; b=e6jm2jylIQM1MDUmMf4b/SG759Y6Tzupx5Jamq/YBZKN90bpWYhKdp3uZhDJKbEZBRPLjE 949qhiDGEK5H5ailH+o4pWukaX4XR0EkvCoDv4MucWd1okaGQmWDP1mUkQ9+pcBEeZb/Uo rKJ5Idqsbqz03MK534mUbjxMsDcU9zI= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-638-rsRqIDm0PHKU1GZYLojoRw-1; Fri, 24 Jun 2022 11:02:16 -0400 X-MC-Unique: rsRqIDm0PHKU1GZYLojoRw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 889713801F57; Fri, 24 Jun 2022 15:02:16 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.194.217]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7B4CE18EAB; Fri, 24 Jun 2022 15:02:15 +0000 (UTC) From: Kevin Traynor To: Ankur Dwivedi Cc: Anoob Joseph , Jerin Jacob , David Marchand , dpdk stable Subject: patch 'crypto/cnxk: fix build with GCC 12' has been queued to stable release 21.11.2 Date: Fri, 24 Jun 2022 16:01:20 +0100 Message-Id: <20220624150148.1855580-12-ktraynor@redhat.com> In-Reply-To: <20220624150148.1855580-1-ktraynor@redhat.com> References: <20220624150148.1855580-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/27/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/e0bff8480fce6437124558f49f608f214c9092be Thanks. Kevin --- >From e0bff8480fce6437124558f49f608f214c9092be Mon Sep 17 00:00:00 2001 From: Ankur Dwivedi Date: Fri, 17 Jun 2022 19:09:30 +0530 Subject: [PATCH] crypto/cnxk: fix build with GCC 12 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit d82d2db2659411059c047a96e867666625a0f1f2 ] The following warning is observed with GCC 12 compilation: In file included from ../drivers/crypto/cnxk/cn10k_cryptodev_ops.c:17: In function ‘fill_sg_comp_from_iov’, inlined from ‘cpt_pdcp_chain_alg_prep’ at ../drivers/crypto/cnxk/cnxk_se.h:1194:8, inlined from ‘cpt_fc_enc_hmac_prep’ at ../drivers/crypto/cnxk/cnxk_se.h:1871:9, inlined from ‘fill_digest_params’ at ../drivers/crypto/cnxk/cnxk_se.h:2829:8, inlined from ‘cpt_sym_inst_fill’ at ../drivers/crypto/cnxk/cn10k_cryptodev_ops.c:92:9, inlined from ‘cn10k_cpt_fill_inst.constprop’ at ../drivers/crypto/cnxk/cn10k_cryptodev_ops.c:146:10: ../drivers/crypto/cnxk/cnxk_se.h:222:52: warning: array subscript 0 is outside array bounds of ‘struct roc_se_buf_ptr[0]’ [-Warray-bounds] 222 | e_vaddr = (uint64_t)bufs[j].vaddr; | ~~~~~~~^~~~~~ ../drivers/crypto/cnxk/cnxk_se.h:223:48: warning: array subscript 0 is outside array bounds of ‘struct roc_se_buf_ptr[0]’ [-Warray-bounds] 223 | e_len = (size > bufs[j].size) ? bufs[j].size : size; | ~~~~~~~^~~~~ This patch resolves the warning. Fixes: 3de331795f73 ("crypto/cnxk: add flexi cipher encryption") Signed-off-by: Ankur Dwivedi Reviewed-by: Anoob Joseph Reviewed-by: Jerin Jacob Tested-by: David Marchand --- drivers/crypto/cnxk/cnxk_se.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/crypto/cnxk/cnxk_se.h b/drivers/crypto/cnxk/cnxk_se.h index 37237de21a..99a2894fa6 100644 --- a/drivers/crypto/cnxk/cnxk_se.h +++ b/drivers/crypto/cnxk/cnxk_se.h @@ -180,25 +180,25 @@ fill_sg_comp_from_iov(struct roc_se_sglist_comp *list, uint32_t i, uint32_t extra_len = extra_buf ? extra_buf->size : 0; uint32_t size = *psize; - struct roc_se_buf_ptr *bufs; - bufs = from->bufs; for (j = 0; (j < from->buf_cnt) && size; j++) { + struct roc_se_sglist_comp *to = &list[i >> 2]; + uint32_t buf_sz = from->bufs[j].size; + void *vaddr = from->bufs[j].vaddr; uint64_t e_vaddr; uint32_t e_len; - struct roc_se_sglist_comp *to = &list[i >> 2]; if (unlikely(from_offset)) { - if (from_offset >= bufs[j].size) { - from_offset -= bufs[j].size; + if (from_offset >= buf_sz) { + from_offset -= buf_sz; continue; } - e_vaddr = (uint64_t)bufs[j].vaddr + from_offset; - e_len = (size > (bufs[j].size - from_offset)) ? - (bufs[j].size - from_offset) : + e_vaddr = (uint64_t)vaddr + from_offset; + e_len = (size > (buf_sz - from_offset)) ? + (buf_sz - from_offset) : size; from_offset = 0; } else { - e_vaddr = (uint64_t)bufs[j].vaddr; - e_len = (size > bufs[j].size) ? bufs[j].size : size; + e_vaddr = (uint64_t)vaddr; + e_len = (size > buf_sz) ? buf_sz : size; } -- 2.34.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-06-24 15:51:09.324544490 +0100 +++ 0012-crypto-cnxk-fix-build-with-GCC-12.patch 2022-06-24 15:51:08.857984044 +0100 @@ -1 +1 @@ -From d82d2db2659411059c047a96e867666625a0f1f2 Mon Sep 17 00:00:00 2001 +From e0bff8480fce6437124558f49f608f214c9092be Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit d82d2db2659411059c047a96e867666625a0f1f2 ] + @@ -35 +36,0 @@ -Cc: stable@dpdk.org @@ -46 +47 @@ -index 8ed3a8b2ef..5c61e4dfa4 100644 +index 37237de21a..99a2894fa6 100644 @@ -49 +50 @@ -@@ -189,25 +189,25 @@ fill_sg_comp_from_iov(struct roc_se_sglist_comp *list, uint32_t i, +@@ -180,25 +180,25 @@ fill_sg_comp_from_iov(struct roc_se_sglist_comp *list, uint32_t i,