patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Harman Kalra <hkalra@marvell.com>
Cc: Pavan Nikhilesh <pbhagavatula@marvell.com>,
	dpdk stable <stable@dpdk.org>
Subject: patch 'event/octeontx: fix SSO fast path' has been queued to stable release 21.11.2
Date: Fri, 24 Jun 2022 16:01:25 +0100	[thread overview]
Message-ID: <20220624150148.1855580-17-ktraynor@redhat.com> (raw)
In-Reply-To: <20220624150148.1855580-1-ktraynor@redhat.com>

Hi,

FYI, your patch has been queued to stable release 21.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/27/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/d2c3d326d001605c8ba05ac61f8ce656754dc36f

Thanks.

Kevin

---
From d2c3d326d001605c8ba05ac61f8ce656754dc36f Mon Sep 17 00:00:00 2001
From: Harman Kalra <hkalra@marvell.com>
Date: Tue, 24 May 2022 14:12:25 +0530
Subject: [PATCH] event/octeontx: fix SSO fast path

[ upstream commit d430b921a4d7c5449f6e99b5ba40671b27d87adb ]

Segmentation fault is observed as soon as any  application
with ethdev event is launched as ev->mbuf was not set properly.

Fixing sub event type violation as in OCTEONTX event device
sub_event_type is used to store the ethernet port identifier
when work is received from OCTEONTX ethernet device. This violates
the event device spec as sub_event_type should be 0 in the initial
receive stage. Setting sub_event_type to 0 after copying the port id
in single workslot mode.

Fixes: 44a2cebbd489 ("crypto/octeontx: add crypto adapter data path")

Signed-off-by: Harman Kalra <hkalra@marvell.com>
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
 drivers/event/octeontx/ssovf_worker.h | 24 +++++++++++++++---------
 1 file changed, 15 insertions(+), 9 deletions(-)

diff --git a/drivers/event/octeontx/ssovf_worker.h b/drivers/event/octeontx/ssovf_worker.h
index e6ee292688..57be476394 100644
--- a/drivers/event/octeontx/ssovf_worker.h
+++ b/drivers/event/octeontx/ssovf_worker.h
@@ -180,14 +180,20 @@ ssows_get_work(struct ssows *ws, struct rte_event *ev, const uint16_t flag)
 
 	if (get_work1) {
-		if (ev->event_type == RTE_EVENT_TYPE_ETHDEV)
-			get_work1 = (uintptr_t)ssovf_octeontx_wqe_to_pkt(
-				get_work1, (ev->event >> 20) & 0x7F, flag,
-				ws->lookup_mem);
-		else if (ev->event_type == RTE_EVENT_TYPE_CRYPTODEV)
+		if (ev->event_type == RTE_EVENT_TYPE_ETHDEV) {
+			uint16_t port = (ev->event >> 20) & 0x7F;
+
+			ev->sub_event_type = 0;
+			ev->mbuf = ssovf_octeontx_wqe_to_pkt(
+				get_work1, port, flag, ws->lookup_mem);
+		} else if (ev->event_type == RTE_EVENT_TYPE_CRYPTODEV) {
 			get_work1 = otx_crypto_adapter_dequeue(get_work1);
-		ev->u64 = get_work1;
-	} else if (unlikely((get_work0 & 0xFFFFFFFF) == 0xFFFFFFFF)) {
-		ssovf_octeontx_wqe_free(get_work1);
-		return 0;
+			ev->u64 = get_work1;
+		} else {
+			if (unlikely((get_work0 & 0xFFFFFFFF) == 0xFFFFFFFF)) {
+				ssovf_octeontx_wqe_free(get_work1);
+				return 0;
+			}
+			ev->u64 = get_work1;
+		}
 	}
 
-- 
2.34.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-06-24 15:51:09.554392156 +0100
+++ 0022-event-octeontx-fix-SSO-fast-path.patch	2022-06-24 15:51:08.886984122 +0100
@@ -1 +1 @@
-From d430b921a4d7c5449f6e99b5ba40671b27d87adb Mon Sep 17 00:00:00 2001
+From d2c3d326d001605c8ba05ac61f8ce656754dc36f Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit d430b921a4d7c5449f6e99b5ba40671b27d87adb ]
+
@@ -17 +18,0 @@
-Cc: stable@dpdk.org


  parent reply	other threads:[~2022-06-24 15:02 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-24 15:01 patch 'trace: fix init with long file prefix' " Kevin Traynor
2022-06-24 15:01 ` patch 'test: drop reference to removed tests' " Kevin Traynor
2022-06-24 15:01 ` patch 'sched: remove unnecessary floating point' " Kevin Traynor
2022-06-24 15:01 ` patch 'eal/x86: drop export of internal alignment macro' " Kevin Traynor
2022-06-24 16:42   ` Kevin Traynor
2022-06-24 15:01 ` patch 'baseband/acc100: update companion PF configure function' " Kevin Traynor
2022-06-24 15:01 ` patch 'baseband/acc100: add protection for some negative scenario' " Kevin Traynor
2022-06-24 15:01 ` patch 'ipsec: fix NAT-T ports and length' " Kevin Traynor
2022-06-24 15:01 ` patch 'examples/ipsec-secgw: fix NAT-T header fields' " Kevin Traynor
2022-06-24 15:01 ` patch 'net/iavf: fix NAT-T payload length' " Kevin Traynor
2022-06-24 15:01 ` patch 'examples/ipsec-secgw: fix ESN setting' " Kevin Traynor
2022-06-24 15:01 ` patch 'common/cpt: fix build with GCC 12' " Kevin Traynor
2022-06-24 15:01 ` patch 'crypto/cnxk: " Kevin Traynor
2022-06-24 15:01 ` patch 'test/ipsec: " Kevin Traynor
2022-06-24 15:01 ` patch 'crypto/scheduler: fix queue pair in scheduler failover' " Kevin Traynor
2022-06-24 15:01 ` patch 'test/crypto: fix cipher offset for ZUC' " Kevin Traynor
2022-06-24 15:01 ` patch 'test/ipsec: fix performance test' " Kevin Traynor
2022-06-24 15:01 ` Kevin Traynor [this message]
2022-06-24 15:01 ` patch 'event/dlb2: rework queue drain handling' " Kevin Traynor
2022-06-24 15:01 ` patch 'event/dlb2: fix check of QID in-flight' " Kevin Traynor
2022-06-24 15:01 ` patch 'event/cnxk: fix QoS parameter handling' " Kevin Traynor
2022-06-24 15:01 ` patch 'event/cnxk: fix Tx adapter enqueue return for CN10K' " Kevin Traynor
2022-06-24 15:01 ` patch 'event/dlb2: fix advertized capabilities' " Kevin Traynor
2022-06-24 15:01 ` patch 'eventdev/eth_tx: fix adapter creation' " Kevin Traynor
2022-06-24 15:01 ` patch 'net/bonding: fix RSS inconsistency between ports' " Kevin Traynor
2022-06-24 15:01 ` patch 'test/bonding: fix RSS test when disable RSS' " Kevin Traynor
2022-06-24 15:01 ` patch 'net/hns3: fix an unreasonable memset' " Kevin Traynor
2022-06-24 15:01 ` patch 'net/hns3: remove duplicate definition' " Kevin Traynor
2022-06-24 15:01 ` patch 'net/hns3: fix code check warning' " Kevin Traynor
2022-06-24 15:01 ` patch 'net/hns3: fix return value for unsupported tuple' " Kevin Traynor
2022-06-24 15:01 ` patch 'net/hns3: fix crash from secondary process' " Kevin Traynor
2022-06-24 15:01 ` patch 'net/hns3: fix TM capability' " Kevin Traynor
2022-06-24 15:01 ` patch 'app/testpmd: add help messages for multi-process' " Kevin Traynor
2022-06-24 15:01 ` patch 'app/testpmd: fix bonding slave devices not released' " Kevin Traynor
2022-06-24 15:01 ` patch 'net/txgbe: fix register polling' " Kevin Traynor
2022-06-24 15:01 ` patch 'net/ngbe: add more packet statistics' " Kevin Traynor
2022-06-24 15:01 ` patch 'app/testpmd: revert MAC update in checksum forwarding' " Kevin Traynor
2022-06-24 15:01 ` patch 'vhost: fix missing enqueue pseudo-header calculation' " Kevin Traynor
2022-06-24 15:01 ` patch 'vhost/crypto: fix build with GCC 12' " Kevin Traynor
2022-06-24 15:01 ` patch 'vhost/crypto: fix descriptor processing' " Kevin Traynor
2022-06-24 15:01 ` patch 'net/virtio: unmap PCI device in secondary process' " Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220624150148.1855580-17-ktraynor@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=hkalra@marvell.com \
    --cc=pbhagavatula@marvell.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).