From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3CF81A00C2 for ; Fri, 24 Jun 2022 17:02:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3793B4281B; Fri, 24 Jun 2022 17:02:16 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 4F883427F1 for ; Fri, 24 Jun 2022 17:02:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656082933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IklFV8X8GILCBqduMC11AWTifrLK4ZDjxHKoAJCglwg=; b=Wvm05zp48p2u+Jq+ISA3ELJaehfy6ec5l+azWyYN+6xfSWNapnEkXX9ErejhAYLC2AtyFP DAt87iAIqIhS/Yb28iEuXPydL24J6AkW+6NZy9xgJllE7HebxnY6j0KPd0A3g8qxA2JT+e Yehfg2ZiZ4DhujSBGnAuwbuII+XZfv4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-134-A65VT7-BO6uwiO47wNV4IQ-1; Fri, 24 Jun 2022 11:02:08 -0400 X-MC-Unique: A65VT7-BO6uwiO47wNV4IQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C3976919940; Fri, 24 Jun 2022 15:02:03 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.194.217]) by smtp.corp.redhat.com (Postfix) with ESMTP id C1EBA10725; Fri, 24 Jun 2022 15:02:02 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: Jasvinder Singh , dpdk stable Subject: patch 'sched: remove unnecessary floating point' has been queued to stable release 21.11.2 Date: Fri, 24 Jun 2022 16:01:11 +0100 Message-Id: <20220624150148.1855580-3-ktraynor@redhat.com> In-Reply-To: <20220624150148.1855580-1-ktraynor@redhat.com> References: <20220624150148.1855580-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/27/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/bba01c7ab88dfac1a732b3fb12cf81921bec9da2 Thanks. Kevin --- >From bba01c7ab88dfac1a732b3fb12cf81921bec9da2 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 26 May 2022 13:26:52 -0700 Subject: [PATCH] sched: remove unnecessary floating point [ upstream commit bb421e98c0c0f56f1adc68722a54d6d24abf137d ] The qdelay variable is derived from and compared to 64 bit value so it doesn't have to be floating point. Fixes: 44c730b0e379 ("sched: add PIE based congestion management") Signed-off-by: Stephen Hemminger Acked-by: Jasvinder Singh --- lib/sched/rte_pie.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/sched/rte_pie.h b/lib/sched/rte_pie.h index 02a987f54a..3e2c1ef467 100644 --- a/lib/sched/rte_pie.h +++ b/lib/sched/rte_pie.h @@ -219,5 +219,5 @@ _rte_pie_drop(const struct rte_pie_config *pie_cfg, { uint64_t rand_value; - double qdelay = pie_cfg->qdelay_ref * 0.5; + uint64_t qdelay = pie_cfg->qdelay_ref / 2; /* PIE is active but the queue is not congested: return 0 */ -- 2.34.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-06-24 15:51:08.993883078 +0100 +++ 0003-sched-remove-unnecessary-floating-point.patch 2022-06-24 15:51:08.811983920 +0100 @@ -1 +1 @@ -From bb421e98c0c0f56f1adc68722a54d6d24abf137d Mon Sep 17 00:00:00 2001 +From bba01c7ab88dfac1a732b3fb12cf81921bec9da2 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit bb421e98c0c0f56f1adc68722a54d6d24abf137d ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org