From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A720DA0032 for ; Fri, 24 Jun 2022 17:02:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A26ED400EF; Fri, 24 Jun 2022 17:02:43 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id A8A014280B for ; Fri, 24 Jun 2022 17:02:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656082961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1ay9GDTpTDceERd+uPC89kBd3fZZdIxE3c+jAxi4ECs=; b=VEeMiC1DevPeLkDMeLZFDaOHPCgd/UgPYR5LUuTA4du4KW2EIrLGisgC8M4OHn5SF/QtDW 2G1cyvTUjc8PFNoWBRaPv/CnhiZsXQ/cCC2NrUEctDBiS0/7zR4skFOttsgeDQh1WsSc24 eXpE4eayear/CoqkzQpvctWB82yafWI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-589-wE9aFn6UPIardbqMug-Cdg-1; Fri, 24 Jun 2022 11:02:38 -0400 X-MC-Unique: wE9aFn6UPIardbqMug-Cdg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AFFD5101E166; Fri, 24 Jun 2022 15:02:37 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.194.217]) by smtp.corp.redhat.com (Postfix) with ESMTP id D9DEB9D63; Fri, 24 Jun 2022 15:02:36 +0000 (UTC) From: Kevin Traynor To: Huisong Li Cc: Min Hu , dpdk stable Subject: patch 'net/hns3: fix crash from secondary process' has been queued to stable release 21.11.2 Date: Fri, 24 Jun 2022 16:01:38 +0100 Message-Id: <20220624150148.1855580-30-ktraynor@redhat.com> In-Reply-To: <20220624150148.1855580-1-ktraynor@redhat.com> References: <20220624150148.1855580-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/27/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/35582af08c0c141db6b5ddb4abcc893b7643fc98 Thanks. Kevin --- >From 35582af08c0c141db6b5ddb4abcc893b7643fc98 Mon Sep 17 00:00:00 2001 From: Huisong Li Date: Wed, 1 Jun 2022 11:52:50 +0800 Subject: [PATCH] net/hns3: fix crash from secondary process [ upstream commit 8ba42ce98dd45958354817c340796f3ce6496410 ] If a hns3 device in the secondary process is attached to do probing operation, 'rx_queues' and 'tx_queues' in dev->data are null in eth_dev_fp_ops_setup when calling rte_eth_dev_probing_finish. The primary process calls dev_start to re-setup their fp_ops. But the secondary process can't call dev_start and has no chance to do it. If the application sends and receives packets at this time, a segfault will occur. So this patch uses the MP communication of the PMD to update the fp_ops of the device in the secondary process. Fixes: 96c33cfb06cf ("net/hns3: fix Rx/Tx functions update") Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_rxtx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c index 2f3bc836e3..f259791f0c 100644 --- a/drivers/net/hns3/hns3_rxtx.c +++ b/drivers/net/hns3/hns3_rxtx.c @@ -4425,4 +4425,6 @@ hns3_eth_dev_fp_ops_config(const struct rte_eth_dev *dev) fpo[port_id].rx_descriptor_status = dev->rx_descriptor_status; fpo[port_id].tx_descriptor_status = dev->tx_descriptor_status; + fpo[port_id].rxq.data = dev->data->rx_queues; + fpo[port_id].txq.data = dev->data->tx_queues; } -- 2.34.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-06-24 15:51:09.853261490 +0100 +++ 0035-net-hns3-fix-crash-from-secondary-process.patch 2022-06-24 15:51:08.908984181 +0100 @@ -1 +1 @@ -From 8ba42ce98dd45958354817c340796f3ce6496410 Mon Sep 17 00:00:00 2001 +From 35582af08c0c141db6b5ddb4abcc893b7643fc98 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8ba42ce98dd45958354817c340796f3ce6496410 ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index bbf98fc90e..e25a91becf 100644 +index 2f3bc836e3..f259791f0c 100644 @@ -28 +29 @@ -@@ -4410,4 +4410,6 @@ hns3_eth_dev_fp_ops_config(const struct rte_eth_dev *dev) +@@ -4425,4 +4425,6 @@ hns3_eth_dev_fp_ops_config(const struct rte_eth_dev *dev)