From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C183A0032 for ; Fri, 24 Jun 2022 18:10:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 371FD4280C; Fri, 24 Jun 2022 18:10:40 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D4FAE400EF for ; Fri, 24 Jun 2022 18:10:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656087038; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qmN7tXRP1hMxlnB0HChd/ysRpZoPt6S1YLqhxB28umw=; b=iwKUGS29+f7QQ+s6HVJirI6tPbmY2mEdyiJJjLB9n3aXaQRVihfKsJ3Xo8oBKQ1Dm4ZBNw iFw7E+072e0DZyFsgnkB6IiNT1HN9R2HX/s+DaHIH6KzjvutAVzc6GWD5QxmFEJUR/bCG5 ohKupINjenDWDymctitg+c4L4DZagHk= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-504-K8WCYuhpNQGmveweQirDoQ-1; Fri, 24 Jun 2022 12:10:35 -0400 X-MC-Unique: K8WCYuhpNQGmveweQirDoQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BC14729ABA12; Fri, 24 Jun 2022 16:10:34 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.194.217]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7F05440334F; Fri, 24 Jun 2022 16:10:33 +0000 (UTC) From: Kevin Traynor To: Ali Alnubani Cc: Thomas Monjalon , Viacheslav Ovsiienko , dpdk stable Subject: patch 'net/mlx5: fix build with clang 14' has been queued to stable release 21.11.2 Date: Fri, 24 Jun 2022 17:10:11 +0100 Message-Id: <20220624161016.1881349-9-ktraynor@redhat.com> In-Reply-To: <20220624161016.1881349-1-ktraynor@redhat.com> References: <20220624161016.1881349-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/27/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/de9fa7b4538ef1f143821e32098c32b7ec9d3bfe Thanks. Kevin --- >From de9fa7b4538ef1f143821e32098c32b7ec9d3bfe Mon Sep 17 00:00:00 2001 From: Ali Alnubani Date: Wed, 11 May 2022 19:41:09 +0300 Subject: [PATCH] net/mlx5: fix build with clang 14 [ upstream commit bae645a23a41c7656928b742e0418fbf41095202 ] Use fgets instead of fscanf to resolve the following warning reported by clang 14.0.0 in Fedora 37 (Rawhide): drivers/net/mlx5/linux/mlx5_ethdev_os.c:1137:52: error: 'fscanf' may overflow; destination buffer in argument 3 has size 16, but the corresponding specifier may require size 17 [-Werror,-Wfortify-source] ret = fscanf(file, "%" RTE_STR(IF_NAMESIZE) "s", port_name); Fixes: 63d1db710fbc ("net/mlx5: fix unlimited parsing of switch info") Signed-off-by: Ali Alnubani Acked-by: Thomas Monjalon Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/linux/mlx5_ethdev_os.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c b/drivers/net/mlx5/linux/mlx5_ethdev_os.c index b5819cc656..fadcbd7ef7 100644 --- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c +++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c @@ -1119,5 +1119,4 @@ mlx5_sysfs_switch_info(unsigned int ifindex, struct mlx5_switch_info *info) bool device_dir = false; char c; - int ret; if (!if_indextoname(ifindex, ifname)) { @@ -1135,8 +1134,7 @@ mlx5_sysfs_switch_info(unsigned int ifindex, struct mlx5_switch_info *info) file = fopen(phys_port_name, "rb"); if (file != NULL) { - ret = fscanf(file, "%" RTE_STR(IF_NAMESIZE) "s", port_name); - fclose(file); - if (ret == 1) + if (fgets(port_name, IF_NAMESIZE, file) != NULL) mlx5_translate_port_name(port_name, &data); + fclose(file); } file = fopen(phys_switch_id, "rb"); -- 2.34.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-06-24 16:54:05.818645272 +0100 +++ 0009-net-mlx5-fix-build-with-clang-14.patch 2022-06-24 16:54:05.546165063 +0100 @@ -1 +1 @@ -From bae645a23a41c7656928b742e0418fbf41095202 Mon Sep 17 00:00:00 2001 +From de9fa7b4538ef1f143821e32098c32b7ec9d3bfe Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit bae645a23a41c7656928b742e0418fbf41095202 ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org @@ -26 +27 @@ -index 8d30ad0994..2a1cf04431 100644 +index b5819cc656..fadcbd7ef7 100644