From: <abhimanyu.saini@xilinx.com>
To: <dev@dpdk.org>
Cc: <chenbo.xia@intel.com>, <maxime.coquelin@redhat.com>,
<andrew.rybchenko@oktetlabs.ru>, <stable@dpdk.org>,
Abhimanyu Saini <absaini@amd.com>,
Vijay Kumar Srivastava <vsrivast@xilinx.com>
Subject: [PATCH] vdpa/sfc: handle sync issue between qemu and vhost-user
Date: Mon, 27 Jun 2022 14:19:17 +0530 [thread overview]
Message-ID: <20220627084917.2295-1-asaini@xilinx.com> (raw)
From: Abhimanyu Saini <absaini@amd.com>
When DPDK app is running in the VF, it sometimes rings the doorbell
before dev_config has had a chance to complete and hence it misses
the event. As workaround, ring the doorbell when vDPA reports the
notify_area to QEMU.
Fixes: 5e7596ba7cb3 ("vdpa/sfc: introduce Xilinx vDPA driver")
Cc: stable@dpdk.org
Signed-off-by: Vijay Kumar Srivastava <vsrivast@xilinx.com>
Signed-off-by: Abhimanyu Saini <absaini@amd.com>
---
drivers/vdpa/sfc/sfc_vdpa_ops.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/vdpa/sfc/sfc_vdpa_ops.c b/drivers/vdpa/sfc/sfc_vdpa_ops.c
index b3d9b6c..63aa52d 100644
--- a/drivers/vdpa/sfc/sfc_vdpa_ops.c
+++ b/drivers/vdpa/sfc/sfc_vdpa_ops.c
@@ -794,6 +794,8 @@
int vfio_dev_fd;
efx_rc_t rc;
unsigned int bar_offset;
+ volatile void *doorbell;
+ struct rte_pci_device *pci_dev;
struct rte_vdpa_device *vdpa_dev;
struct sfc_vdpa_ops_data *ops_data;
struct vfio_region_info reg = { .argsz = sizeof(reg) };
@@ -856,6 +858,18 @@
sfc_vdpa_info(dev, "vDPA ops get_notify_area :: offset : 0x%" PRIx64,
*offset);
+ pci_dev = sfc_vdpa_adapter_by_dev_handle(dev)->pdev;
+ doorbell = (uint8_t *)pci_dev->mem_resource[reg.index].addr + *offset;
+
+ /*
+ * virtio-net driver in VM sends queue notifications before
+ * vDPA has a chance to setup the queues and notification area,
+ * and hence the HW misses these doorbell notifications.
+ * Since, it is safe to send duplicate doorbell, send another
+ * doorbell from vDPA driver as workaround for this timing issue.
+ */
+ rte_write16(qid, doorbell);
+
return 0;
}
--
1.8.3.1
next reply other threads:[~2022-06-27 8:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 8:49 abhimanyu.saini [this message]
2022-06-27 15:03 ` Andrew Rybchenko
2022-06-28 5:29 ` [PATCH v2] " abhimanyu.saini
2022-06-28 9:01 ` Andrew Rybchenko
2022-06-30 12:56 ` Maxime Coquelin
2022-07-01 13:58 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220627084917.2295-1-asaini@xilinx.com \
--to=abhimanyu.saini@xilinx.com \
--cc=absaini@amd.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=vsrivast@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).