From: Kevin Laatz <kevin.laatz@intel.com>
To: dev@dpdk.org
Cc: bruce.richardson@intel.com, Kevin Laatz <kevin.laatz@intel.com>,
stable@dpdk.org
Subject: [PATCH v2 3/3] dma/idxd: fix null pointer dereference during pci remove
Date: Sun, 3 Jul 2022 13:22:43 +0100 [thread overview]
Message-ID: <20220703122243.929642-4-kevin.laatz@intel.com> (raw)
In-Reply-To: <20220703122243.929642-1-kevin.laatz@intel.com>
The 'info' struct was being declared as a NULL pointer. If a NULL
pointer is passed to 'rte_dma_info_get', EINVAL is returned and the
struct is not populated. This subsequently causes a segfault when
dereferencing 'info'.
This patch fixes the issue by simply declaring 'info' as a variable and
passing its address to 'rte_dma_info_get'.
Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe")
Cc: stable@dpdk.org
Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
---
drivers/dma/idxd/idxd_pci.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/dma/idxd/idxd_pci.c b/drivers/dma/idxd/idxd_pci.c
index 9349c56b3f..3c1effeb84 100644
--- a/drivers/dma/idxd/idxd_pci.c
+++ b/drivers/dma/idxd/idxd_pci.c
@@ -379,10 +379,10 @@ idxd_dmadev_remove_pci(struct rte_pci_device *dev)
IDXD_PMD_INFO("Closing %s on NUMA node %d", name, dev->device.numa_node);
RTE_DMA_FOREACH_DEV(i) {
- struct rte_dma_info *info = {0};
- rte_dma_info_get(i, info);
- if (strncmp(name, info->dev_name, strlen(name)) == 0)
- idxd_dmadev_destroy(info->dev_name);
+ struct rte_dma_info info;
+ rte_dma_info_get(i, &info);
+ if (strncmp(name, info.dev_name, strlen(name)) == 0)
+ idxd_dmadev_destroy(info.dev_name);
}
return 0;
--
2.31.1
next prev parent reply other threads:[~2022-07-03 12:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220408141504.1319913-1-kevin.laatz@intel.com>
2022-04-08 14:15 ` [PATCH 1/5] dma/idxd: fix memory leak in pci close Kevin Laatz
2022-04-08 14:49 ` Bruce Richardson
2022-04-08 14:15 ` [PATCH 2/5] dma/idxd: fix memory leak due to free on incorrect pointer Kevin Laatz
2022-04-08 14:52 ` Bruce Richardson
2022-04-19 16:20 ` Kevin Laatz
2022-04-08 14:15 ` [PATCH 5/5] examples/dma: fix missing dma close Kevin Laatz
[not found] ` <20220703122243.929642-1-kevin.laatz@intel.com>
2022-07-03 12:22 ` [PATCH v2 1/3] dma/idxd: fix memory leak in pci close Kevin Laatz
2022-07-04 13:19 ` Bruce Richardson
2022-07-04 13:34 ` Kevin Laatz
2022-07-04 13:44 ` Bruce Richardson
2022-07-03 12:22 ` [PATCH v2 2/3] dma/idxd: fix memory leak due to free on incorrect pointer Kevin Laatz
2022-07-04 13:23 ` Bruce Richardson
2022-07-04 13:25 ` Bruce Richardson
2022-07-03 12:22 ` Kevin Laatz [this message]
2022-07-04 13:25 ` [PATCH v2 3/3] dma/idxd: fix null pointer dereference during pci remove Bruce Richardson
[not found] ` <20220704152751.943965-1-kevin.laatz@intel.com>
2022-07-04 15:27 ` [PATCH v3 1/3] dma/idxd: fix memory leak in pci close Kevin Laatz
2022-07-04 15:39 ` Bruce Richardson
2022-07-04 15:27 ` [PATCH v3 2/3] dma/idxd: fix memory leak due to free on incorrect pointer Kevin Laatz
2022-07-04 15:27 ` [PATCH v3 3/3] dma/idxd: fix null pointer dereference during pci remove Kevin Laatz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220703122243.929642-4-kevin.laatz@intel.com \
--to=kevin.laatz@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).