From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 492B1A0540 for ; Wed, 6 Jul 2022 22:35:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4249D40FAE; Wed, 6 Jul 2022 22:35:51 +0200 (CEST) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mails.dpdk.org (Postfix) with ESMTP id 285F84069D for ; Wed, 6 Jul 2022 22:35:50 +0200 (CEST) Received: by mail-wm1-f53.google.com with SMTP id m184so9492192wme.1 for ; Wed, 06 Jul 2022 13:35:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=h3fek7zKdnCWdof3Ba5w2R8Mk3RYkJc6tnQyGA04+ps=; b=UYWSOA+enDQLDN2jberAFK0rBfQ45rOxgEv0KfGIE5tnBxBVTX03jSH9y16FlyZQBw CLO4B0nsIcO4tQHqDt9f2I5I4bI2D3lmGvr9xl2A/goLPFGUToC/XSGv33DnJR633ueE Dc2XzxWF/gHOLINmdwXTVYztBKXnuVJ4IJKF4O6/srHAX7rdWS0uEJBikBRBl++S3TzB luhMkr9w9kg20x0+sM9ToA0Q/iC9qQRIWj1aWxHL2vWTPzXvP+IQIUtdGAVJED8k0pr6 tqm9OViLcM/AK+4H5+u4HaLh17+HdK+DXgW1ovHogKaYE6b/2RA+I+DavmhlleekEJ5r NZfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=h3fek7zKdnCWdof3Ba5w2R8Mk3RYkJc6tnQyGA04+ps=; b=3myN686RzTg0Ss14pByC0EgS2iAEp+vAbQuXYceEckY0mfXy2hbMRxgq09NYeyctP9 IBc0palR87Bh+KyHyCy+GrrzOTZuQ9OTOhXL3Y+wvMBOcGFtnON6tbynUm1BFfNP943o VmCDCSzBn+gL4J812jUhCLiVCsaYQ3lsd0sZXRZIWxct4E0X8ytA5mVgrIe7AgHrHY6o IhC5s9BUoLVfVFeidhynQcxHmPTBRN9YBRa8nIGO6rzwyk7/Ah5i6WYzZhL3eCr+D8PL lnCNQg0nsQSkoqM5tCS8kU8ROb3mfVtx27wIEeSu1TPYUkeSrJyfeUAs1lOH9HWGIeXn UPzg== X-Gm-Message-State: AJIora+eMy+w/iYsrArNWvL4/t9MSS/V6olXiZlQ3I0wX/KcwFPLsSHw cPvZ7V/LEqr2zAFPbyv/Y/utwf7G6mro5w== X-Google-Smtp-Source: AGRyM1skPZrtx7nbGq/bFElhr7D8KfyZ9fsj7YRVO6d8S8ZE9EXXUomuXR9hv4P/xlK9I2UyisWorw== X-Received: by 2002:a05:600c:4e92:b0:3a0:4f34:8fd6 with SMTP id f18-20020a05600c4e9200b003a04f348fd6mr427173wmq.63.1657139749855; Wed, 06 Jul 2022 13:35:49 -0700 (PDT) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id s5-20020adfeb05000000b0021b91d1ddbfsm11420292wrn.21.2022.07.06.13.35.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jul 2022 13:35:49 -0700 (PDT) From: luca.boccassi@gmail.com To: Herakliusz Lipiec Cc: Chenbo Xia , dpdk stable Subject: patch 'doc: fix readability in vhost guide' has been queued to stable release 21.11.2 Date: Wed, 6 Jul 2022 21:34:47 +0100 Message-Id: <20220706203506.3422496-12-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220706203506.3422496-1-luca.boccassi@gmail.com> References: <20220628151938.2278711-26-ktraynor@redhat.com> <20220706203506.3422496-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/08/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/a3ff1d7e9ce4d3f5b2dbb2b4fda74cb20ad76781 Thanks. Luca Boccassi --- >From a3ff1d7e9ce4d3f5b2dbb2b4fda74cb20ad76781 Mon Sep 17 00:00:00 2001 From: Herakliusz Lipiec Date: Thu, 23 Jun 2022 14:57:21 +0100 Subject: [PATCH] doc: fix readability in vhost guide [ upstream commit c8a3ee49c94d72d03e2de5814bca01f7fd7d79d1 ] fix grammar issues and readbility in vhost library programmer guide Fixes: 768274ebbd5e ("vhost: avoid populate guest memory") Signed-off-by: Herakliusz Lipiec Reviewed-by: Chenbo Xia --- doc/guides/prog_guide/vhost_lib.rst | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/doc/guides/prog_guide/vhost_lib.rst b/doc/guides/prog_guide/vhost_lib.rst index 76f5d303c9..8959568d8f 100644 --- a/doc/guides/prog_guide/vhost_lib.rst +++ b/doc/guides/prog_guide/vhost_lib.rst @@ -331,7 +331,7 @@ vhost-user implementation has two options: * The vhost supported features must be exactly the same before and after the restart. For example, if TSO is disabled and then enabled, - nothing will work and issues undefined might happen. + nothing will work and undefined issues might happen. No matter which mode is used, once a connection is established, DPDK vhost-user will start receiving and processing vhost messages from QEMU. @@ -362,12 +362,12 @@ Guest memory requirement * Memory pre-allocation - For non-async data path, guest memory pre-allocation is not a - must. This can help save of memory. If users really want the guest memory - to be pre-allocated (e.g., for performance reason), we can add option - ``-mem-prealloc`` when starting QEMU. Or, we can lock all memory at vhost - side which will force memory to be allocated when mmap at vhost side; - option --mlockall in ovs-dpdk is an example in hand. + For non-async data path guest memory pre-allocation is not a + must but can help save memory. To do this we can add option + ``-mem-prealloc`` when starting QEMU, or we can lock all memory at vhost + side which will force memory to be allocated when it calls mmap + (option --mlockall in ovs-dpdk is an example in hand). + For async data path, we force the VM memory to be pre-allocated at vhost lib when mapping the guest memory; and also we need to lock the memory to @@ -375,8 +375,8 @@ Guest memory requirement * Memory sharing - Make sure ``share=on`` QEMU option is given. vhost-user will not work with - a QEMU version without shared memory mapping. + Make sure ``share=on`` QEMU option is given. The vhost-user will not work with + a QEMU instance without shared memory mapping. Vhost supported vSwitch reference --------------------------------- -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-07-06 21:07:53.984474236 +0100 +++ 0012-doc-fix-readability-in-vhost-guide.patch 2022-07-06 21:07:53.543518707 +0100 @@ -1 +1 @@ -From c8a3ee49c94d72d03e2de5814bca01f7fd7d79d1 Mon Sep 17 00:00:00 2001 +From a3ff1d7e9ce4d3f5b2dbb2b4fda74cb20ad76781 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c8a3ee49c94d72d03e2de5814bca01f7fd7d79d1 ] + @@ -9 +10,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ -index a4ffed9fa1..bad4d819e1 100644 +index 76f5d303c9..8959568d8f 100644 @@ -21 +22 @@ -@@ -351,7 +351,7 @@ vhost-user implementation has two options: +@@ -331,7 +331,7 @@ vhost-user implementation has two options: @@ -30 +31 @@ -@@ -382,12 +382,12 @@ Guest memory requirement +@@ -362,12 +362,12 @@ Guest memory requirement @@ -49 +50 @@ -@@ -395,8 +395,8 @@ Guest memory requirement +@@ -375,8 +375,8 @@ Guest memory requirement