From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB4F9A0540 for ; Wed, 6 Jul 2022 22:35:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A6C5D4113D; Wed, 6 Jul 2022 22:35:37 +0200 (CEST) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mails.dpdk.org (Postfix) with ESMTP id 447D140691 for ; Wed, 6 Jul 2022 22:35:36 +0200 (CEST) Received: by mail-wr1-f42.google.com with SMTP id r14so17814449wrg.1 for ; Wed, 06 Jul 2022 13:35:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mL6iSu3Emyp1oYHjLgkw5C1LQpgKqiV5VIPKTqUqYqg=; b=nu61DudLgbKu2eJUksmWCS63w7Rj4qLY5rhds4ADVFoU40cgECVFL/PBgMEUZmGlQF 7fXM8wOaj/nQQmzgxuJH0xaWioopwNX7qZZxXpjPG4YBOzwxa9S8FpEQ8CihYhXyTJdK IgFbfLU5SdmQTj8hfkMHvQF3QsnKlO0etnGK1JkuIunFcukUBri0bWey5I/xw1DgbE4u FQOl7EEbOSjvKyMLD3HvjEDRD7CtEqXnk6vdDuU33rjqdTmt4+wi81e5Mt8r7IX5WdgU DRhpLgQED5vwEmbYl+4+BsSY50dm6y+/k+PQRtdvAUnT3KcxJWWbWymAFp7sgvKnC1bh 71ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mL6iSu3Emyp1oYHjLgkw5C1LQpgKqiV5VIPKTqUqYqg=; b=StWrIIIy/5fWNwLp5R30Af+e3L/P6V5ofCnRDPdMbHknoaTc7MNly7XSj6zhXtkye4 8cS8l9EDW95eWUzNabhQBZReX3ECflV3phZpCUwP04nDMM8ub1rTakW6BJIkT5n1tQE0 /nC0UjQQ3csOEKSnlYuYKiZIQ3/Yiy+FqRob2aA7Ulr7az9v9RVpl3SBc7bCU4QWo+6r XeVG4YvzCqtz6PfJWBLlgNYm/E8GbtCxM+jmC1V2aaG76q1VCxoFFFJ46Nx6rQ0+OlkN ufaATgaT9t6iaGwkP3FFrSqNDvVo3M8df7nW0+HcQ6dDr23bTUgek0XDZOj/2Pd0zzFJ gazA== X-Gm-Message-State: AJIora8RbW1AVJV8bQJij+Gd2ethRQ0cMjvG8T7Jk6ulCpgqLDFeCQAO FyHSyxYi+kYhE4w9njlEc+Y= X-Google-Smtp-Source: AGRyM1tJdb3GUkZ+6mJFHwppmbfP5VSFSHgC6ivmjTi/JoQVKLWY0O/CmZc2ACVo8dW9QPaW2b5l7g== X-Received: by 2002:a5d:48ce:0:b0:21b:9f34:f297 with SMTP id p14-20020a5d48ce000000b0021b9f34f297mr39591959wrs.351.1657139736033; Wed, 06 Jul 2022 13:35:36 -0700 (PDT) Received: from localhost ([2a01:4b00:f41a:3600:360b:9754:2e3a:c344]) by smtp.gmail.com with ESMTPSA id m12-20020adfe0cc000000b0021d4155cd6fsm18173945wri.53.2022.07.06.13.35.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jul 2022 13:35:35 -0700 (PDT) From: luca.boccassi@gmail.com To: Naga Harish K S V Cc: Jay Jayatheerthan , dpdk stable Subject: patch 'eventdev/eth_tx: fix queue delete' has been queued to stable release 21.11.2 Date: Wed, 6 Jul 2022 21:34:43 +0100 Message-Id: <20220706203506.3422496-8-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220706203506.3422496-1-luca.boccassi@gmail.com> References: <20220628151938.2278711-26-ktraynor@redhat.com> <20220706203506.3422496-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/08/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/49cc0b73a033688bf15e3d98a1e3247eb8b0ac7e Thanks. Luca Boccassi --- >From 49cc0b73a033688bf15e3d98a1e3247eb8b0ac7e Mon Sep 17 00:00:00 2001 From: Naga Harish K S V Date: Thu, 23 Jun 2022 15:35:11 +0530 Subject: [PATCH] eventdev/eth_tx: fix queue delete [ upstream commit 881d4b4d8587419197815db57b94fc58ee487445 ] Add spinlock protection in queue delete function. This protects the data path while the queue delete operation is in progress. Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation") Signed-off-by: Naga Harish K S V Acked-by: Jay Jayatheerthan --- lib/eventdev/rte_event_eth_tx_adapter.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c index c700fb7b1f..b4b37f1cae 100644 --- a/lib/eventdev/rte_event_eth_tx_adapter.c +++ b/lib/eventdev/rte_event_eth_tx_adapter.c @@ -891,9 +891,10 @@ txa_service_queue_del(uint8_t id, txa = txa_service_id_to_data(id); + rte_spinlock_lock(&txa->tx_lock); tqi = txa_service_queue(txa, port_id, tx_queue_id); if (tqi == NULL || !tqi->added) - return 0; + goto ret_unlock; tb = tqi->tx_buf; tqi->added = 0; @@ -903,6 +904,9 @@ txa_service_queue_del(uint8_t id, txa->txa_ethdev[port_id].nb_queues--; txa_service_queue_array_free(txa, port_id); + +ret_unlock: + rte_spinlock_unlock(&txa->tx_lock); return 0; } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-07-06 21:07:53.844956826 +0100 +++ 0008-eventdev-eth_tx-fix-queue-delete.patch 2022-07-06 21:07:53.531518477 +0100 @@ -1 +1 @@ -From 881d4b4d8587419197815db57b94fc58ee487445 Mon Sep 17 00:00:00 2001 +From 49cc0b73a033688bf15e3d98a1e3247eb8b0ac7e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 881d4b4d8587419197815db57b94fc58ee487445 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org