From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76D0CA0540 for ; Thu, 7 Jul 2022 09:56:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7153E40A7B; Thu, 7 Jul 2022 09:56:38 +0200 (CEST) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id EB5A7427F0 for ; Thu, 7 Jul 2022 09:56:35 +0200 (CEST) Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id AC6F440A90 for ; Thu, 7 Jul 2022 07:56:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1657180595; bh=xynE0L8mHBg4xkiSFUvCTQHMAI77duwrLcQL243NjP4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=v7mymM8Z8jW+35hN+MbSoKZdeCuusnO6Wl7rqvs8TlCsJFT15IqWcTr1h0rBMqdL3 qk4YDhXnJw8YmnC3rTMH0Nht0pm0cvUC4tLZgGukzt3A3jkl/qwBx4zLdPWH04AxIt qn5DDxcQmOk58eI2bgDIDpvTTvPUGkHFuW4hHB6G/WwoyAE4LlDBmV9ZO5vwEDiZ8p sEwBW4Aj6dbBR9v/49f4kuHj4GFc93FCVKpwIfG1nqRyf2vhClp19qulx3yy0nwOzv 6g1tVn3PA3Cu99xbpoJhSibswyCg7G83P/QBDdDZAXy/v+GhHtxLAYUlZksAFTFKYp XatLhlLMJ1CJw== Received: by mail-ed1-f69.google.com with SMTP id g7-20020a056402424700b00435ac9c7a8bso13387357edb.14 for ; Thu, 07 Jul 2022 00:56:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xynE0L8mHBg4xkiSFUvCTQHMAI77duwrLcQL243NjP4=; b=dyxzR458ZFwzRqmXFW5Ac9QfPqLS8ZJXJU0sPdRJ+03nzmSM3oLiRxx7aI8ZLWDYGB phjZ3CZjPcJPnei/R0cpOyBx5/D6KCqwoB25loUbglGyUJUhyw6aqqQ8M8zy6RKRxAv3 lrY4IS5UARm6N7jzjmKMHXwmEJP6Qrj23aKxA34F3xgf7XLxMoBXF1T1AcRD5Zc5HOoe 609T5UBzv9RCwR4KEGuBmhHHxlN4AV/E6hZZEjlD3eK3Zv90kR6FCp3rg2ORLgp7huvI vq9W2kopt7UDizJsIoaLy2xfo229GHNud86KordMahcxbZE4GrTTBZ2Qt8nUgsO1YByI cZqA== X-Gm-Message-State: AJIora+ZJ9N1yPIJxbIs/2SdGy3uQAvsoSTbIJHaQ+SjmcWrKczkd89n FAywKHZTgslothobVvQddHp/JOnXPudpdWtvCttWFMU4ZgsyAmnTC1uOVItbJlbchwcdH+NQ2ct HjS3/cRmwwS9l1HPi1Djb7Lbt X-Received: by 2002:a17:907:168c:b0:726:c521:25aa with SMTP id hc12-20020a170907168c00b00726c52125aamr42870456ejc.46.1657180595506; Thu, 07 Jul 2022 00:56:35 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uu2oK0nLxy1FBhYhuzh85hBit0BR387xT8L7TEzGxK8auXoaYlevSf4dcm16WiwHAWmg6n+Q== X-Received: by 2002:a17:907:168c:b0:726:c521:25aa with SMTP id hc12-20020a170907168c00b00726c52125aamr42870438ejc.46.1657180595286; Thu, 07 Jul 2022 00:56:35 -0700 (PDT) Received: from Keschdeichel.fritz.box ([2a02:6d40:3a4f:7b00:c19b:938e:7c97:afe2]) by smtp.gmail.com with ESMTPSA id s16-20020a170906455000b00722bc0aa9e3sm12194041ejq.162.2022.07.07.00.56.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jul 2022 00:56:34 -0700 (PDT) From: christian.ehrhardt@canonical.com To: Somnath Kotur Cc: Kalesh AP , Ajit Khaparde , dpdk stable Subject: patch 'net/bnxt: fix freeing VNIC filters' has been queued to stable release 19.11.13 Date: Thu, 7 Jul 2022 09:54:19 +0200 Message-Id: <20220707075522.194223-24-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.37.0 In-Reply-To: <20220707075522.194223-1-christian.ehrhardt@canonical.com> References: <20220707075522.194223-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.13 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/09/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/0e67983b1e47a9b9c149275df0b91bb3fc307493 Thanks. Christian Ehrhardt --- >From 0e67983b1e47a9b9c149275df0b91bb3fc307493 Mon Sep 17 00:00:00 2001 From: Somnath Kotur Date: Wed, 27 Apr 2022 20:28:20 +0530 Subject: [PATCH] net/bnxt: fix freeing VNIC filters [ upstream commit 2df7dfffe3dc5d6b65c77a7fbe155e38a9e3dc24 ] In bnxt_free_all_filters(), all the filters attached to a vnic are removed. But each of these filters hold a backreference ptr to the vnic and they need to be reset to NULL now. Otherwise, during a normal testpmd quit, as part of dev_close_op(), first bnxt_free_all_filters() is invoked in dev_stop, followed by bnxt_free_filter_mem() from bnxt_uninit_resources(), which finds a filter with a vnic back reference ptr and now bnxt_hwrm_clean_up_l2_filter() also tries to remove the filter from the vnic's filter list which was already done as part of bnxt_free_all_filters(). Fixes: f0f6b5e6cf94 ("net/bnxt: fix reusing L2 filter") Signed-off-by: Somnath Kotur Reviewed-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_filter.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/bnxt/bnxt_filter.c b/drivers/net/bnxt/bnxt_filter.c index 2b33d266c9..d8b2b68c56 100644 --- a/drivers/net/bnxt/bnxt_filter.c +++ b/drivers/net/bnxt/bnxt_filter.c @@ -99,6 +99,8 @@ void bnxt_free_all_filters(struct bnxt *bp) bnxt_filter_info, next); STAILQ_INSERT_TAIL(&bp->free_filter_list, filter, next); + if (filter->vnic) + filter->vnic = NULL; filter = temp_filter; } STAILQ_INIT(&vnic->filter); -- 2.37.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-07-07 09:54:12.244769042 +0200 +++ 0024-net-bnxt-fix-freeing-VNIC-filters.patch 2022-07-07 09:54:10.837823826 +0200 @@ -1 +1 @@ -From 2df7dfffe3dc5d6b65c77a7fbe155e38a9e3dc24 Mon Sep 17 00:00:00 2001 +From 0e67983b1e47a9b9c149275df0b91bb3fc307493 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 2df7dfffe3dc5d6b65c77a7fbe155e38a9e3dc24 ] + @@ -17 +18,0 @@ -Cc: stable@dpdk.org @@ -27 +28 @@ -index 1d08e03b2f..b0c3bbd1b2 100644 +index 2b33d266c9..d8b2b68c56 100644