patches for DPDK stable branches
 help / color / mirror / Atom feed
From: christian.ehrhardt@canonical.com
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: Daxue Gao <daxuex.gao@intel.com>,
	David Marchand <david.marchand@redhat.com>,
	Kai Ji <kai.ji@intel.com>, dpdk stable <stable@dpdk.org>
Subject: patch 'drivers/crypto: fix warnings for OpenSSL version' has been queued to stable release 19.11.13
Date: Thu,  7 Jul 2022 09:54:27 +0200	[thread overview]
Message-ID: <20220707075522.194223-32-christian.ehrhardt@canonical.com> (raw)
In-Reply-To: <20220707075522.194223-1-christian.ehrhardt@canonical.com>

Hi,

FYI, your patch has been queued to stable release 19.11.13

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/09/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/cpaelzer/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/cpaelzer/dpdk-stable-queue/commit/57ae04724a4a45ca27f776843fca798e89f99017

Thanks.

Christian Ehrhardt <christian.ehrhardt@canonical.com>

---
From 57ae04724a4a45ca27f776843fca798e89f99017 Mon Sep 17 00:00:00 2001
From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Date: Tue, 10 May 2022 17:06:35 +0200
Subject: [PATCH] drivers/crypto: fix warnings for OpenSSL version
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

[ upstream commit 7360749f167b9039f549818700db3f57d6f8a9fd ]

The API of the OpenSSL library has changed with version 3.0. This results
in a lot of compiler warnings like

    ../dpdk/drivers/crypto/ccp/ccp_crypto.c:182:9:
    warning: ‘SHA256_Transform’ is deprecated:
    Since OpenSSL 3.0 [-Wdeprecated-declarations]

As many Linux distributions still use elder OpenSSL libraries we cannot
change the used API now. Instead define OPENSSL_API_COMPAT to indicate
that we are using the OpenSSL 1.1.0 API.

OPENSSL_API_COMPAT is introduced in *.c files and not in *.h files as some
*.c files directly include OpenSSL headers.

Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library")

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Tested-by: Daxue Gao <daxuex.gao@intel.com>
Tested-by: David Marchand <david.marchand@redhat.com>
Acked-by: Kai Ji <kai.ji@intel.com>
---
 drivers/crypto/ccp/ccp_crypto.c              | 2 ++
 drivers/crypto/openssl/rte_openssl_pmd.c     | 2 ++
 drivers/crypto/openssl/rte_openssl_pmd_ops.c | 2 ++
 drivers/crypto/qat/qat_sym.c                 | 2 ++
 drivers/crypto/qat/qat_sym_session.c         | 2 ++
 5 files changed, 10 insertions(+)

diff --git a/drivers/crypto/ccp/ccp_crypto.c b/drivers/crypto/ccp/ccp_crypto.c
index 4256734d16..1536b1a647 100644
--- a/drivers/crypto/ccp/ccp_crypto.c
+++ b/drivers/crypto/ccp/ccp_crypto.c
@@ -2,6 +2,8 @@
  *   Copyright(c) 2018 Advanced Micro Devices, Inc. All rights reserved.
  */
 
+#define OPENSSL_API_COMPAT 0x10100000L
+
 #include <dirent.h>
 #include <fcntl.h>
 #include <stdio.h>
diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c
index 3e0afd71a1..aee8dea0c6 100644
--- a/drivers/crypto/openssl/rte_openssl_pmd.c
+++ b/drivers/crypto/openssl/rte_openssl_pmd.c
@@ -2,6 +2,8 @@
  * Copyright(c) 2016-2017 Intel Corporation
  */
 
+#define OPENSSL_API_COMPAT 0x10100000L
+
 #include <rte_common.h>
 #include <rte_hexdump.h>
 #include <rte_cryptodev.h>
diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
index cbfb8149f9..4dda2e0c2f 100644
--- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c
+++ b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
@@ -2,6 +2,8 @@
  * Copyright(c) 2016-2017 Intel Corporation
  */
 
+#define OPENSSL_API_COMPAT 0x10100000L
+
 #include <string.h>
 
 #include <rte_common.h>
diff --git a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c
index 696b231a00..150c6a8b52 100644
--- a/drivers/crypto/qat/qat_sym.c
+++ b/drivers/crypto/qat/qat_sym.c
@@ -2,6 +2,8 @@
  * Copyright(c) 2015-2019 Intel Corporation
  */
 
+#define OPENSSL_API_COMPAT 0x10100000L
+
 #include <openssl/evp.h>
 
 #include <rte_mempool.h>
diff --git a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_sym_session.c
index ab12c99716..17647ea7b5 100644
--- a/drivers/crypto/qat/qat_sym_session.c
+++ b/drivers/crypto/qat/qat_sym_session.c
@@ -2,6 +2,8 @@
  * Copyright(c) 2015-2019 Intel Corporation
  */
 
+#define OPENSSL_API_COMPAT 0x10100000L
+
 #include <openssl/sha.h>	/* Needed to calculate pre-compute values */
 #include <openssl/aes.h>	/* Needed to calculate pre-compute values */
 #include <openssl/md5.h>	/* Needed to calculate pre-compute values */
-- 
2.37.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-07-07 09:54:12.568925220 +0200
+++ 0032-drivers-crypto-fix-warnings-for-OpenSSL-version.patch	2022-07-07 09:54:10.861823975 +0200
@@ -1 +1 @@
-From 7360749f167b9039f549818700db3f57d6f8a9fd Mon Sep 17 00:00:00 2001
+From 57ae04724a4a45ca27f776843fca798e89f99017 Mon Sep 17 00:00:00 2001
@@ -8,0 +9,2 @@
+[ upstream commit 7360749f167b9039f549818700db3f57d6f8a9fd ]
+
@@ -24 +25,0 @@
-Cc: stable@dpdk.org
@@ -39 +40 @@
-index 4ed91a7436..4bab18323b 100644
+index 4256734d16..1536b1a647 100644
@@ -52 +53 @@
-index d80e1052e2..4f331af157 100644
+index 3e0afd71a1..aee8dea0c6 100644
@@ -65 +66 @@
-index 1cb07794bd..87c395a836 100644
+index cbfb8149f9..4dda2e0c2f 100644
@@ -78 +79 @@
-index ca8c9a8124..3a6c9dcc0a 100644
+index 696b231a00..150c6a8b52 100644
@@ -82 +83 @@
-  * Copyright(c) 2015-2022 Intel Corporation
+  * Copyright(c) 2015-2019 Intel Corporation
@@ -91 +92 @@
-index 9d6a19c0be..737a180810 100644
+index ab12c99716..17647ea7b5 100644
@@ -95 +96 @@
-  * Copyright(c) 2015-2022 Intel Corporation
+  * Copyright(c) 2015-2019 Intel Corporation

  parent reply	other threads:[~2022-07-07  7:57 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-07  7:53 patch 'eal/windows: fix data race when creating threads' " christian.ehrhardt
2022-07-07  7:53 ` patch 'examples/bond: fix invalid use of trylock' " christian.ehrhardt
2022-07-07  7:53 ` patch 'net/mlx5: fix Tx when inlining is impossible' " christian.ehrhardt
2022-07-07  7:53 ` patch 'net/mlx5: fix GTP handling in header modify action' " christian.ehrhardt
2022-07-07  7:54 ` patch 'test/table: fix buffer overflow on lpm entry' " christian.ehrhardt
2022-07-07  7:54 ` patch 'mem: skip attaching external memory in secondary process' " christian.ehrhardt
2022-07-07  7:54 ` patch 'eal: fix C++ include for device event and DMA' " christian.ehrhardt
2022-07-07  7:54 ` patch 'crypto/dpaa_sec: fix digest size' " christian.ehrhardt
2022-07-07  7:54 ` patch 'crypto/dpaa2_sec: fix buffer pool ID check' " christian.ehrhardt
2022-07-07  7:54 ` patch 'crypto/dpaa_sec: fix secondary process probing' " christian.ehrhardt
2022-07-07  7:54 ` patch 'crypto/dpaa2_sec: fix operation status for simple FD' " christian.ehrhardt
2022-07-07  7:54 ` patch 'common/dpaax: fix short MAC-I IV calculation for ZUC' " christian.ehrhardt
2022-07-07  7:54 ` patch 'examples/l2fwd-crypto: fix stats refresh rate' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/nfp: remove unneeded header inclusion' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/bonding: fix RSS key config with extended key length' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/cxgbe: fix port ID in Rx mbuf' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/vhost: fix access to freed memory' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/vhost: fix TSO feature default disablement' " christian.ehrhardt
2022-07-07  7:54 ` patch 'vhost: fix missing virtqueue lock protection' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/dpaa: fix event queue detach' " christian.ehrhardt
2022-07-07  7:54 ` patch 'app/testpmd: check statistics query before printing' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/bnxt: remove unused macro' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/bnxt: recheck FW readiness if in reset process' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/bnxt: fix freeing VNIC filters' " christian.ehrhardt
2022-07-07  7:54 ` patch 'eal/x86: fix unaligned access for small memcpy' " christian.ehrhardt
2022-07-07  7:54 ` patch 'test: avoid hang if queues are full and Tx fails' " christian.ehrhardt
2022-07-07  7:54 ` patch 'acl: fix rules with 8-byte field size' " christian.ehrhardt
2022-07-07  7:54 ` patch 'rib: fix traversal with /32 route' " christian.ehrhardt
2022-07-07  7:54 ` patch 'devtools: fix null test for NUMA systems' " christian.ehrhardt
2022-07-07  7:54 ` patch 'examples/ipsec-secgw: fix promiscuous mode option' " christian.ehrhardt
2022-07-07  7:54 ` patch 'test/crypto: fix null check for ZUC authentication' " christian.ehrhardt
2022-07-07  7:54 ` christian.ehrhardt [this message]
2022-07-07  7:54 ` patch 'app/testpmd: remove useless pointer checks' " christian.ehrhardt
2022-07-07  7:54 ` patch 'ethdev: clarify null location case in xstats get' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/hns3: fix xstats get return if xstats is null' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/ipn3ke: " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/mvpp2: " christian.ehrhardt
2022-07-07  7:54 ` patch 'app/testpmd: replace hardcoded min mbuf number with macro' " christian.ehrhardt
2022-07-07  7:54 ` patch 'app/testpmd: fix metering and policing command for RFC4115' " christian.ehrhardt
2022-07-07  7:54 ` patch 'ethdev: prohibit polling stopped queue' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/bonding: fix mbuf fast free usage' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/memif: fix overwriting of head segment' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/bnxt: fix compatibility with some old firmwares' " christian.ehrhardt
2022-07-07  7:54 ` patch 'examples/vhost: fix crash when no VMDq' " christian.ehrhardt
2022-07-07  7:54 ` patch 'kni: fix build with Linux 5.18' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/ixgbe: add option for link up check on pin SDP3' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/ice/base: fix getting sched node from ID type' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/iavf: fix queue start exception handling' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/iavf: increase reset complete wait count' " christian.ehrhardt
2022-07-07  7:54 ` patch 'bus/fslmc: fix VFIO setup' " christian.ehrhardt
2022-07-07  7:54 ` patch 'kni: use dedicated function to set random MAC address' " christian.ehrhardt
2022-07-07  7:54 ` patch 'kni: use dedicated function to set " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/ice: fix build with GCC 12' " christian.ehrhardt
2022-07-07  7:54 ` patch 'vdpa/ifc: " christian.ehrhardt
2022-07-07  7:54 ` patch 'eal/x86: drop export of internal alignment macro' " christian.ehrhardt
2022-07-07  7:54 ` patch 'common/cpt: fix build with GCC 12' " christian.ehrhardt
2022-07-07  7:54 ` patch 'test/ipsec: " christian.ehrhardt
2022-07-07  7:54 ` patch 'crypto/scheduler: fix queue pair in scheduler failover' " christian.ehrhardt
2022-07-07  7:54 ` patch 'test/crypto: fix cipher offset for ZUC' " christian.ehrhardt
2022-07-07  7:54 ` patch 'eventdev/eth_tx: fix adapter creation' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/bonding: fix RSS inconsistency between ports' " christian.ehrhardt
2022-07-07  7:54 ` patch 'test/bonding: fix RSS test when disable RSS' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/hns3: remove duplicate definition' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/nfp: fix initialization' " christian.ehrhardt
2022-07-07  7:55 ` patch 'app/testpmd: revert MAC update in checksum forwarding' " christian.ehrhardt
2022-07-07  7:55 ` patch 'vhost: fix missing enqueue pseudo-header calculation' " christian.ehrhardt
2022-07-07  7:55 ` patch 'vhost/crypto: fix build with GCC 12' " christian.ehrhardt
2022-07-07  7:55 ` patch 'vhost/crypto: fix descriptor processing' " christian.ehrhardt
2022-07-07  7:55 ` patch 'malloc: fix allocation of almost hugepage size' " christian.ehrhardt
2022-07-07  7:55 ` patch 'net/octeontx: fix port close' " christian.ehrhardt
2022-07-07  7:55 ` patch 'net/qede: fix build with GCC 12' " christian.ehrhardt
2022-07-07  7:55 ` patch 'test/hash: fix out of bound access' " christian.ehrhardt
2022-07-07  7:55 ` patch 'test: check memory allocation for CRC' " christian.ehrhardt
2022-07-07  7:55 ` patch 'examples/distributor: fix distributor on Rx core' " christian.ehrhardt
2022-07-07  7:55 ` patch 'net/bnxt: allow Tx only or Rx only' " christian.ehrhardt
2022-07-07  7:55 ` patch 'net/bnxt: cleanup MTU setting' " christian.ehrhardt
2022-07-07  7:55 ` patch 'test/crypto: fix authentication IV for ZUC SGL' " christian.ehrhardt
2022-07-07  7:55 ` patch 'test/crypto: fix ZUC vector IV format' " christian.ehrhardt
2022-07-07  7:55 ` patch 'test/crypto: fix SNOW3G " christian.ehrhardt
2022-07-07  7:55 ` patch 'examples/fips_validation: handle empty payload' " christian.ehrhardt
2022-07-07  7:55 ` patch 'crypto/qat: fix DOCSIS crash' " christian.ehrhardt
2022-07-07  7:55 ` patch 'doc: fix grammar and formatting in compressdev guide' " christian.ehrhardt
2022-07-07  7:55 ` patch 'eventdev/eth_tx: fix queue delete' " christian.ehrhardt
2022-07-07  7:55 ` patch 'net/vhost: fix deadlock on vring state change' " christian.ehrhardt
2022-07-07  7:55 ` patch 'vhost: add some trailing newline in log messages' " christian.ehrhardt
2022-07-07  7:55 ` patch 'service: fix lingering active status' " christian.ehrhardt
2022-07-07  7:55 ` patch 'kni: fix build' " christian.ehrhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220707075522.194223-32-christian.ehrhardt@canonical.com \
    --to=christian.ehrhardt@canonical.com \
    --cc=david.marchand@redhat.com \
    --cc=daxuex.gao@intel.com \
    --cc=heinrich.schuchardt@canonical.com \
    --cc=kai.ji@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).