From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77C30A0540 for ; Thu, 7 Jul 2022 09:57:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 730E840DDE; Thu, 7 Jul 2022 09:57:06 +0200 (CEST) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 38990415D7 for ; Thu, 7 Jul 2022 09:57:05 +0200 (CEST) Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 10BD9402B9 for ; Thu, 7 Jul 2022 07:57:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1657180625; bh=PahC0JYhABq5Mpq/wRU+dA1knIOgVZF7NLcUeEH/0yg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=J+q2RT08LonK4+hHfOpexAGJGgChKFSpkT7Zoz6Vg3DLgGoiwTXNPkhX7bg8V5YDx EvRljkkE5hJbBZKNLoUzE5An7rPFW6p4jLbEn48rzTu47e2PcrcoMXowC6KSdVh6hN XFeIwkilMcHn7TcBoQNkoNeNg9ooqyA+w1suA4/kwf/cgOT9xdxrbsM4bIaShWE7T+ 6kmlQws5+MhmSavj/PsinHlhC28GrUDIKwub8zSCl4GixkGata7C4B8vjMIIpTQZbA YYZa/TpaHXxaNM0n0C7aIB5HUPt7CcHqJHAnWLoFGMWXlQhVOg4CKJpPJooZaEwFf1 nPb18ilYIVRfQ== Received: by mail-ed1-f71.google.com with SMTP id y18-20020a056402441200b0043564cdf765so13424903eda.11 for ; Thu, 07 Jul 2022 00:57:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PahC0JYhABq5Mpq/wRU+dA1knIOgVZF7NLcUeEH/0yg=; b=VzsLRKjDqDHdOLgoiFY9f462C6sU9Fzh1WL2J+PlU+31k2J5FQSbbVbMUwL/U0W6ql u0AxUBhZ3TA3KMC4FGD4iJCs35IxVdcE0lcDyqv3XXKBkxeJSScg5l2a5lsCp92XgsAd 5kiY5YaGe1xVV4Bggpz69SxtfQgYFtbslNy7N2ZHQ3U3OKjkijxtRtly4CcogrSHz1p4 xMTNX1jnNRWe0NRsJcHM5x+rELYRLjSgj/TkTxN9EVtahEL6evyZ4w894kCv0Kozxbve Kda5txzFtsyNzZ/xL6cGgu0HDlM9psInRaa490gcz6W4lyxVlQhD0QzuFlwQGFhCK2Ga 0QeA== X-Gm-Message-State: AJIora98h62CXcd92N2FEtu67iGTHK1qujrXTFs3r3VWe5t3C4gVASNi ff/+9V2A5po7Iecr8UFZ+s0QPx3CXN5cgnzzMW4tmZLZkAAT9HA4rspkqhUV1wTTIbZM5C1S7/a J2KAq8pifHEWperfGcj5EJbNp X-Received: by 2002:a17:906:8a7b:b0:6fe:b81f:f885 with SMTP id hy27-20020a1709068a7b00b006feb81ff885mr15115923ejc.621.1657180624582; Thu, 07 Jul 2022 00:57:04 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vlAc4xPyRGOmF177flr+nOteXWY/GqugwWz1lHeDf4Vib2Wz8j4Sj8sfaygImgqTeI2xOqfg== X-Received: by 2002:a17:906:8a7b:b0:6fe:b81f:f885 with SMTP id hy27-20020a1709068a7b00b006feb81ff885mr15115910ejc.621.1657180624379; Thu, 07 Jul 2022 00:57:04 -0700 (PDT) Received: from Keschdeichel.fritz.box ([2a02:6d40:3a4f:7b00:c19b:938e:7c97:afe2]) by smtp.gmail.com with ESMTPSA id u5-20020a170906068500b00703671ebe65sm18360271ejb.198.2022.07.07.00.57.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jul 2022 00:57:03 -0700 (PDT) From: christian.ehrhardt@canonical.com To: David Marchand Cc: dpdk stable Subject: patch 'app/testpmd: remove useless pointer checks' has been queued to stable release 19.11.13 Date: Thu, 7 Jul 2022 09:54:28 +0200 Message-Id: <20220707075522.194223-33-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.37.0 In-Reply-To: <20220707075522.194223-1-christian.ehrhardt@canonical.com> References: <20220707075522.194223-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.13 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/09/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/fa9bd2129ab34dfd1a2dcfdbdb2340fee2b83a21 Thanks. Christian Ehrhardt --- >From fa9bd2129ab34dfd1a2dcfdbdb2340fee2b83a21 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Thu, 24 Mar 2022 17:15:03 +0100 Subject: [PATCH] app/testpmd: remove useless pointer checks [ upstream commit 2d8699ebb2a0638e8ae18fc0a83c56f984d0b270 ] Parameters to this static helper can't be NULL. str has already been dereferenced in caller. dst and size point to variable in stack. Fixes: 169a9fed1f4c ("app/testpmd: fix hex string parser support for flow API") Signed-off-by: David Marchand --- app/test-pmd/cmdline_flow.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 9f43f6c43f..7ad4d29536 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -5296,11 +5296,7 @@ parse_hex_string(const char *src, uint8_t *dst, uint32_t *size) const uint8_t *head = dst; uint32_t left; - /* Check input parameters */ - if ((src == NULL) || - (dst == NULL) || - (size == NULL) || - (*size == 0)) + if (*size == 0) return -1; left = *size; -- 2.37.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-07-07 09:54:12.609708464 +0200 +++ 0033-app-testpmd-remove-useless-pointer-checks.patch 2022-07-07 09:54:10.865824000 +0200 @@ -1 +1 @@ -From 2d8699ebb2a0638e8ae18fc0a83c56f984d0b270 Mon Sep 17 00:00:00 2001 +From fa9bd2129ab34dfd1a2dcfdbdb2340fee2b83a21 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 2d8699ebb2a0638e8ae18fc0a83c56f984d0b270 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index fc4a6d9cca..e3269e278d 100644 +index 9f43f6c43f..7ad4d29536 100644 @@ -22 +23 @@ -@@ -9338,11 +9338,7 @@ parse_hex_string(const char *src, uint8_t *dst, uint32_t *size) +@@ -5296,11 +5296,7 @@ parse_hex_string(const char *src, uint8_t *dst, uint32_t *size)