patches for DPDK stable branches
 help / color / mirror / Atom feed
From: christian.ehrhardt@canonical.com
To: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
Cc: Tyler Retzlaff <roretzla@linux.microsoft.com>,
	dpdk stable <stable@dpdk.org>
Subject: patch 'ethdev: prohibit polling stopped queue' has been queued to stable release 19.11.13
Date: Thu,  7 Jul 2022 09:54:35 +0200	[thread overview]
Message-ID: <20220707075522.194223-40-christian.ehrhardt@canonical.com> (raw)
In-Reply-To: <20220707075522.194223-1-christian.ehrhardt@canonical.com>

Hi,

FYI, your patch has been queued to stable release 19.11.13

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/09/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/cpaelzer/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/cpaelzer/dpdk-stable-queue/commit/1e64fc63b5bef0c2437a3b9341c5320732288f6a

Thanks.

Christian Ehrhardt <christian.ehrhardt@canonical.com>

---
From 1e64fc63b5bef0c2437a3b9341c5320732288f6a Mon Sep 17 00:00:00 2001
From: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
Date: Mon, 11 Apr 2022 00:35:50 +0300
Subject: [PATCH] ethdev: prohibit polling stopped queue

[ upstream commit b77d3318d6a3ca266751031ff04520b7ad485529 ]

Whether it is allowed to call Rx/Tx functions for a stopped queue
was undocumented. Some PMDs make this behavior a no-op
either by explicitly checking the queue state
or by the way how their routines are implemented or HW works.

No-op behavior may be convenient for application developers.
But it also means that pollers of stopped queues
would go all the way down to PMD Rx/Tx routines, wasting cycles.
Some PMDs would do a check for the queue state on data path,
even though it may never be needed for a particular application.
Also, use cases for stopping queues or starting them deferred
do not logically require polling stopped queues.

Use case 1: a secondary that was polling the queue has crashed,
the primary is doing a recovery to free all mbufs.
By definition the queue to be restarted is not polled.

Use case 2: deferred queue start or queue reconfiguration.
The polling thread must be synchronized anyway,
because queue start and stop are non-atomic.

Prohibit calling Rx/Tx functions on stopped queues.

Fixes: 0748be2cf9a2 ("ethdev: queue start and stop")

Signed-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
 lib/librte_ethdev/rte_ethdev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index 826339009b..2aea6cb196 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -74,7 +74,7 @@
  * rte_eth_rx_queue_setup()), it must call rte_eth_dev_stop() first to stop the
  * device and then do the reconfiguration before calling rte_eth_dev_start()
  * again. The transmit and receive functions should not be invoked when the
- * device is stopped.
+ * device or the queue is stopped.
  *
  * Please note that some configuration is not stored between calls to
  * rte_eth_dev_stop()/rte_eth_dev_start(). The following configuration will
-- 
2.37.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-07-07 09:54:12.885410546 +0200
+++ 0040-ethdev-prohibit-polling-stopped-queue.patch	2022-07-07 09:54:10.909824271 +0200
@@ -1 +1 @@
-From b77d3318d6a3ca266751031ff04520b7ad485529 Mon Sep 17 00:00:00 2001
+From 1e64fc63b5bef0c2437a3b9341c5320732288f6a Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit b77d3318d6a3ca266751031ff04520b7ad485529 ]
+
@@ -30 +31,0 @@
-Cc: stable@dpdk.org
@@ -35 +36 @@
- lib/ethdev/rte_ethdev.h | 2 +-
+ lib/librte_ethdev/rte_ethdev.h | 2 +-
@@ -38,4 +39,4 @@
-diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
-index 04225bba4d..02df65d923 100644
---- a/lib/ethdev/rte_ethdev.h
-+++ b/lib/ethdev/rte_ethdev.h
+diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
+index 826339009b..2aea6cb196 100644
+--- a/lib/librte_ethdev/rte_ethdev.h
++++ b/lib/librte_ethdev/rte_ethdev.h

  parent reply	other threads:[~2022-07-07  7:57 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-07  7:53 patch 'eal/windows: fix data race when creating threads' " christian.ehrhardt
2022-07-07  7:53 ` patch 'examples/bond: fix invalid use of trylock' " christian.ehrhardt
2022-07-07  7:53 ` patch 'net/mlx5: fix Tx when inlining is impossible' " christian.ehrhardt
2022-07-07  7:53 ` patch 'net/mlx5: fix GTP handling in header modify action' " christian.ehrhardt
2022-07-07  7:54 ` patch 'test/table: fix buffer overflow on lpm entry' " christian.ehrhardt
2022-07-07  7:54 ` patch 'mem: skip attaching external memory in secondary process' " christian.ehrhardt
2022-07-07  7:54 ` patch 'eal: fix C++ include for device event and DMA' " christian.ehrhardt
2022-07-07  7:54 ` patch 'crypto/dpaa_sec: fix digest size' " christian.ehrhardt
2022-07-07  7:54 ` patch 'crypto/dpaa2_sec: fix buffer pool ID check' " christian.ehrhardt
2022-07-07  7:54 ` patch 'crypto/dpaa_sec: fix secondary process probing' " christian.ehrhardt
2022-07-07  7:54 ` patch 'crypto/dpaa2_sec: fix operation status for simple FD' " christian.ehrhardt
2022-07-07  7:54 ` patch 'common/dpaax: fix short MAC-I IV calculation for ZUC' " christian.ehrhardt
2022-07-07  7:54 ` patch 'examples/l2fwd-crypto: fix stats refresh rate' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/nfp: remove unneeded header inclusion' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/bonding: fix RSS key config with extended key length' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/cxgbe: fix port ID in Rx mbuf' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/vhost: fix access to freed memory' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/vhost: fix TSO feature default disablement' " christian.ehrhardt
2022-07-07  7:54 ` patch 'vhost: fix missing virtqueue lock protection' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/dpaa: fix event queue detach' " christian.ehrhardt
2022-07-07  7:54 ` patch 'app/testpmd: check statistics query before printing' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/bnxt: remove unused macro' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/bnxt: recheck FW readiness if in reset process' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/bnxt: fix freeing VNIC filters' " christian.ehrhardt
2022-07-07  7:54 ` patch 'eal/x86: fix unaligned access for small memcpy' " christian.ehrhardt
2022-07-07  7:54 ` patch 'test: avoid hang if queues are full and Tx fails' " christian.ehrhardt
2022-07-07  7:54 ` patch 'acl: fix rules with 8-byte field size' " christian.ehrhardt
2022-07-07  7:54 ` patch 'rib: fix traversal with /32 route' " christian.ehrhardt
2022-07-07  7:54 ` patch 'devtools: fix null test for NUMA systems' " christian.ehrhardt
2022-07-07  7:54 ` patch 'examples/ipsec-secgw: fix promiscuous mode option' " christian.ehrhardt
2022-07-07  7:54 ` patch 'test/crypto: fix null check for ZUC authentication' " christian.ehrhardt
2022-07-07  7:54 ` patch 'drivers/crypto: fix warnings for OpenSSL version' " christian.ehrhardt
2022-07-07  7:54 ` patch 'app/testpmd: remove useless pointer checks' " christian.ehrhardt
2022-07-07  7:54 ` patch 'ethdev: clarify null location case in xstats get' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/hns3: fix xstats get return if xstats is null' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/ipn3ke: " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/mvpp2: " christian.ehrhardt
2022-07-07  7:54 ` patch 'app/testpmd: replace hardcoded min mbuf number with macro' " christian.ehrhardt
2022-07-07  7:54 ` patch 'app/testpmd: fix metering and policing command for RFC4115' " christian.ehrhardt
2022-07-07  7:54 ` christian.ehrhardt [this message]
2022-07-07  7:54 ` patch 'net/bonding: fix mbuf fast free usage' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/memif: fix overwriting of head segment' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/bnxt: fix compatibility with some old firmwares' " christian.ehrhardt
2022-07-07  7:54 ` patch 'examples/vhost: fix crash when no VMDq' " christian.ehrhardt
2022-07-07  7:54 ` patch 'kni: fix build with Linux 5.18' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/ixgbe: add option for link up check on pin SDP3' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/ice/base: fix getting sched node from ID type' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/iavf: fix queue start exception handling' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/iavf: increase reset complete wait count' " christian.ehrhardt
2022-07-07  7:54 ` patch 'bus/fslmc: fix VFIO setup' " christian.ehrhardt
2022-07-07  7:54 ` patch 'kni: use dedicated function to set random MAC address' " christian.ehrhardt
2022-07-07  7:54 ` patch 'kni: use dedicated function to set " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/ice: fix build with GCC 12' " christian.ehrhardt
2022-07-07  7:54 ` patch 'vdpa/ifc: " christian.ehrhardt
2022-07-07  7:54 ` patch 'eal/x86: drop export of internal alignment macro' " christian.ehrhardt
2022-07-07  7:54 ` patch 'common/cpt: fix build with GCC 12' " christian.ehrhardt
2022-07-07  7:54 ` patch 'test/ipsec: " christian.ehrhardt
2022-07-07  7:54 ` patch 'crypto/scheduler: fix queue pair in scheduler failover' " christian.ehrhardt
2022-07-07  7:54 ` patch 'test/crypto: fix cipher offset for ZUC' " christian.ehrhardt
2022-07-07  7:54 ` patch 'eventdev/eth_tx: fix adapter creation' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/bonding: fix RSS inconsistency between ports' " christian.ehrhardt
2022-07-07  7:54 ` patch 'test/bonding: fix RSS test when disable RSS' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/hns3: remove duplicate definition' " christian.ehrhardt
2022-07-07  7:54 ` patch 'net/nfp: fix initialization' " christian.ehrhardt
2022-07-07  7:55 ` patch 'app/testpmd: revert MAC update in checksum forwarding' " christian.ehrhardt
2022-07-07  7:55 ` patch 'vhost: fix missing enqueue pseudo-header calculation' " christian.ehrhardt
2022-07-07  7:55 ` patch 'vhost/crypto: fix build with GCC 12' " christian.ehrhardt
2022-07-07  7:55 ` patch 'vhost/crypto: fix descriptor processing' " christian.ehrhardt
2022-07-07  7:55 ` patch 'malloc: fix allocation of almost hugepage size' " christian.ehrhardt
2022-07-07  7:55 ` patch 'net/octeontx: fix port close' " christian.ehrhardt
2022-07-07  7:55 ` patch 'net/qede: fix build with GCC 12' " christian.ehrhardt
2022-07-07  7:55 ` patch 'test/hash: fix out of bound access' " christian.ehrhardt
2022-07-07  7:55 ` patch 'test: check memory allocation for CRC' " christian.ehrhardt
2022-07-07  7:55 ` patch 'examples/distributor: fix distributor on Rx core' " christian.ehrhardt
2022-07-07  7:55 ` patch 'net/bnxt: allow Tx only or Rx only' " christian.ehrhardt
2022-07-07  7:55 ` patch 'net/bnxt: cleanup MTU setting' " christian.ehrhardt
2022-07-07  7:55 ` patch 'test/crypto: fix authentication IV for ZUC SGL' " christian.ehrhardt
2022-07-07  7:55 ` patch 'test/crypto: fix ZUC vector IV format' " christian.ehrhardt
2022-07-07  7:55 ` patch 'test/crypto: fix SNOW3G " christian.ehrhardt
2022-07-07  7:55 ` patch 'examples/fips_validation: handle empty payload' " christian.ehrhardt
2022-07-07  7:55 ` patch 'crypto/qat: fix DOCSIS crash' " christian.ehrhardt
2022-07-07  7:55 ` patch 'doc: fix grammar and formatting in compressdev guide' " christian.ehrhardt
2022-07-07  7:55 ` patch 'eventdev/eth_tx: fix queue delete' " christian.ehrhardt
2022-07-07  7:55 ` patch 'net/vhost: fix deadlock on vring state change' " christian.ehrhardt
2022-07-07  7:55 ` patch 'vhost: add some trailing newline in log messages' " christian.ehrhardt
2022-07-07  7:55 ` patch 'service: fix lingering active status' " christian.ehrhardt
2022-07-07  7:55 ` patch 'kni: fix build' " christian.ehrhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220707075522.194223-40-christian.ehrhardt@canonical.com \
    --to=christian.ehrhardt@canonical.com \
    --cc=dkozlyuk@nvidia.com \
    --cc=roretzla@linux.microsoft.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).