From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E212A0540 for ; Thu, 7 Jul 2022 09:57:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6AC794282F; Thu, 7 Jul 2022 09:57:23 +0200 (CEST) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 724B9415D7 for ; Thu, 7 Jul 2022 09:57:22 +0200 (CEST) Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id E870D40A90 for ; Thu, 7 Jul 2022 07:57:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1657180641; bh=WDPEo7fv5sS+Bj5JLgsqypUE1OFQIC00YQ+jk+ASEuk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CP/Cc17FjMcRzFEcEQyO9OuR16sCDkjl5Anpi05EJlOSBG6DJONO7BNlyEHQ2AmEP GHsEfFPIIUH/XbXnxvW6piaf0xl2i6LxNZGH9gQq+J3BFVdOxQWi6AkqWoiA97fLeK ttKnhmww0qhu4EMSRcDuX9ywoK7IzzxY3wBbXQtBPt4eCAlLLVvYBJ5lxK7Zh0KKmr f8B16lRUEZfMdr0si4O9i29cI1t87/TJIujqg3B9OUkMhOwhdoBL63yjNjpd8aHKYh +0lLKy12E7XkFw5Htd4idqV1Gjo46TpvHHWHx+1H9GrtJfuAA4/NrvkR2h95hbICv0 Fe8lbi4gpgOyQ== Received: by mail-ej1-f71.google.com with SMTP id hq41-20020a1709073f2900b00722e5ad076cso4517300ejc.20 for ; Thu, 07 Jul 2022 00:57:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WDPEo7fv5sS+Bj5JLgsqypUE1OFQIC00YQ+jk+ASEuk=; b=x6zxTq81GCToYrm2NCVdFc2Or3SoQif8ixDLAOVlQ39Cb9U3crr9yN/kTCU9xIiMZ4 LGF6N2CtqPiyU07kGvyOeT3GMnlU9engR/s8aMAineFFT/QvhleRso59irwu1vu/53yH imrf3hO7s3Wl1eUXUXU2QgjQ3WIuJS3Sl5bv+U0iq7QujIQK6M9fLqBk+JbiHtwaC9EN pfXh0rv7QvwSfVMaQlg3aeqr00ofGZu8g85Ybg8XaXucihhbq+Dabezzn5u4gMDGfRm+ kQ/LR/zDDtUl0D4voyE0GZDuHn0Ux4J6bilj0UsLdE927axsvVPPkO2EqXpsxGbhUXFR u9zg== X-Gm-Message-State: AJIora+atWYGH245HQa4gHp1LjuObD2GxArX8i8O4gUBe+m3xBX6smgB 0TcGEo3OJGqB6GtcY+Riyzsux7n7bGphdZzIx9NBpxfwfjx2LYxgWWziFH1tVoiYW0DI5Bg6CsE fvbEVObqzfiMqSZdnSrfLGsnD X-Received: by 2002:a17:906:845b:b0:72a:4dbf:82e6 with SMTP id e27-20020a170906845b00b0072a4dbf82e6mr41125131ejy.149.1657180641650; Thu, 07 Jul 2022 00:57:21 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vfrlC1zRCXDdGxK5+qQafOsP/8slBqtoETd+AyuCvcHLKNKm2hojBb6ZwsqqurLy5YATK/iQ== X-Received: by 2002:a17:906:845b:b0:72a:4dbf:82e6 with SMTP id e27-20020a170906845b00b0072a4dbf82e6mr41125115ejy.149.1657180641413; Thu, 07 Jul 2022 00:57:21 -0700 (PDT) Received: from Keschdeichel.fritz.box ([2a02:6d40:3a4f:7b00:c19b:938e:7c97:afe2]) by smtp.gmail.com with ESMTPSA id 18-20020a170906329200b0072abb95eaa4sm6194548ejw.215.2022.07.07.00.57.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jul 2022 00:57:20 -0700 (PDT) From: christian.ehrhardt@canonical.com To: Dmitry Kozlyuk Cc: Tyler Retzlaff , dpdk stable Subject: patch 'ethdev: prohibit polling stopped queue' has been queued to stable release 19.11.13 Date: Thu, 7 Jul 2022 09:54:35 +0200 Message-Id: <20220707075522.194223-40-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.37.0 In-Reply-To: <20220707075522.194223-1-christian.ehrhardt@canonical.com> References: <20220707075522.194223-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.13 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/09/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/1e64fc63b5bef0c2437a3b9341c5320732288f6a Thanks. Christian Ehrhardt --- >From 1e64fc63b5bef0c2437a3b9341c5320732288f6a Mon Sep 17 00:00:00 2001 From: Dmitry Kozlyuk Date: Mon, 11 Apr 2022 00:35:50 +0300 Subject: [PATCH] ethdev: prohibit polling stopped queue [ upstream commit b77d3318d6a3ca266751031ff04520b7ad485529 ] Whether it is allowed to call Rx/Tx functions for a stopped queue was undocumented. Some PMDs make this behavior a no-op either by explicitly checking the queue state or by the way how their routines are implemented or HW works. No-op behavior may be convenient for application developers. But it also means that pollers of stopped queues would go all the way down to PMD Rx/Tx routines, wasting cycles. Some PMDs would do a check for the queue state on data path, even though it may never be needed for a particular application. Also, use cases for stopping queues or starting them deferred do not logically require polling stopped queues. Use case 1: a secondary that was polling the queue has crashed, the primary is doing a recovery to free all mbufs. By definition the queue to be restarted is not polled. Use case 2: deferred queue start or queue reconfiguration. The polling thread must be synchronized anyway, because queue start and stop are non-atomic. Prohibit calling Rx/Tx functions on stopped queues. Fixes: 0748be2cf9a2 ("ethdev: queue start and stop") Signed-off-by: Dmitry Kozlyuk Acked-by: Tyler Retzlaff --- lib/librte_ethdev/rte_ethdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index 826339009b..2aea6cb196 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -74,7 +74,7 @@ * rte_eth_rx_queue_setup()), it must call rte_eth_dev_stop() first to stop the * device and then do the reconfiguration before calling rte_eth_dev_start() * again. The transmit and receive functions should not be invoked when the - * device is stopped. + * device or the queue is stopped. * * Please note that some configuration is not stored between calls to * rte_eth_dev_stop()/rte_eth_dev_start(). The following configuration will -- 2.37.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-07-07 09:54:12.885410546 +0200 +++ 0040-ethdev-prohibit-polling-stopped-queue.patch 2022-07-07 09:54:10.909824271 +0200 @@ -1 +1 @@ -From b77d3318d6a3ca266751031ff04520b7ad485529 Mon Sep 17 00:00:00 2001 +From 1e64fc63b5bef0c2437a3b9341c5320732288f6a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b77d3318d6a3ca266751031ff04520b7ad485529 ] + @@ -30 +31,0 @@ -Cc: stable@dpdk.org @@ -35 +36 @@ - lib/ethdev/rte_ethdev.h | 2 +- + lib/librte_ethdev/rte_ethdev.h | 2 +- @@ -38,4 +39,4 @@ -diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h -index 04225bba4d..02df65d923 100644 ---- a/lib/ethdev/rte_ethdev.h -+++ b/lib/ethdev/rte_ethdev.h +diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h +index 826339009b..2aea6cb196 100644 +--- a/lib/librte_ethdev/rte_ethdev.h ++++ b/lib/librte_ethdev/rte_ethdev.h