From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B739A0540 for ; Thu, 7 Jul 2022 09:59:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 46EC8406B4; Thu, 7 Jul 2022 09:59:06 +0200 (CEST) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 1CA39406B4 for ; Thu, 7 Jul 2022 09:59:05 +0200 (CEST) Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id AFFDD3F1CA for ; Thu, 7 Jul 2022 07:59:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1657180744; bh=BQhevcqmz1+yXJLQWSRDt6cgWhVoz/addnutK5bFgj8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=L52eGAjO71zTyq6TjfusfllTCBibMfRyj3peCUTCSvLCl26bOnRr2lsqJWH4NjTqO rJKHO1IPIuRSpMo12jjhDYRe+4pKyY8reZb6kXn4OkTDDSZ5xfNsOAGUSbO2gCMKvL JthbYUYhIDjVuF2KK8A4n2zIhEZExiG+bRN0cq6FBtJpbDB283yF7ULBQh6FfuQX3j Mlt28YtMfh2Ov9mradFUr8UD50xBmz4dd3yB5eeBHrfO/V2rA/y71qMYg2F+0Y273m OY1rieGBtfae2ncUZ7XbFoWIDaz27GDxDfApoiTQYF/WFiI3XH+/kv2ccs/D7NEitF Of2C8IgX0SuuA== Received: by mail-ed1-f72.google.com with SMTP id y18-20020a056402441200b0043564cdf765so13428237eda.11 for ; Thu, 07 Jul 2022 00:59:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BQhevcqmz1+yXJLQWSRDt6cgWhVoz/addnutK5bFgj8=; b=KTxXE1YPgJsPg1KSWXnlsZ/IBDiSBNAKl5Ggfv6n5QcM+H9FFIfYUwJERAzcBWFdqY nlvofvJw394HpnzQ7PqCvm3LOz6UC09qLcmTI8CSZBxSFR2onwDH4oWpRr2cgPxXVH21 kBtEP8WmGkJ+XyeLtjq4iXLb0xkoVe6ga7UFsowRC5ttq680AHy5jybxeTp3eD33kUk0 upBlL2QzaUqH5Mrw4zNtXk14JFsoCr/fGvEFEE/IvF9lHm2rmwhRYAbTG60akRELVEIb Fo/fxpBB5S9bIsqEmJ+lk+TZ9pnfIxrLdmFGHj5hBHiA1bxyBuNwR2Xzoi1W97tLLPyw DUMQ== X-Gm-Message-State: AJIora/gxjSM4su0ZsTSL/KsplVXffC+yN21TLX56Ag8Ktg+wCp59xO+ So4ZT7vi5ybo7sENqtLyYZfriB4+qHkDVCaZnJEGy0kMjN7gMwOn+s5PrryGifDnx44t9xSNdgU b5gPBD7H9Uk+SzD0RvisIo78E X-Received: by 2002:a17:907:7f8b:b0:721:9c02:37f1 with SMTP id qk11-20020a1709077f8b00b007219c0237f1mr42802090ejc.211.1657180744330; Thu, 07 Jul 2022 00:59:04 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vuOEQAJvT7YQbmhu5c1J/+vou+sBKFauqg5p16lFC6+64vStrnReyJL+wyDlw3R4R3o1+TQg== X-Received: by 2002:a17:907:7f8b:b0:721:9c02:37f1 with SMTP id qk11-20020a1709077f8b00b007219c0237f1mr42802076ejc.211.1657180744102; Thu, 07 Jul 2022 00:59:04 -0700 (PDT) Received: from Keschdeichel.fritz.box ([2a02:6d40:3a4f:7b00:c19b:938e:7c97:afe2]) by smtp.gmail.com with ESMTPSA id o13-20020a170906768d00b0072af6d20a9asm2217681ejm.75.2022.07.07.00.59.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jul 2022 00:59:03 -0700 (PDT) From: christian.ehrhardt@canonical.com To: Heinrich Schuchardt Cc: dpdk stable Subject: patch 'test/hash: fix out of bound access' has been queued to stable release 19.11.13 Date: Thu, 7 Jul 2022 09:55:07 +0200 Message-Id: <20220707075522.194223-72-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.37.0 In-Reply-To: <20220707075522.194223-1-christian.ehrhardt@canonical.com> References: <20220707075522.194223-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.13 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/09/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/8caef8fee30e977e7abae526281dd17cf3f99d89 Thanks. Christian Ehrhardt --- >From 8caef8fee30e977e7abae526281dd17cf3f99d89 Mon Sep 17 00:00:00 2001 From: Heinrich Schuchardt Date: Sat, 4 Jun 2022 10:37:11 +0200 Subject: [PATCH] test/hash: fix out of bound access [ upstream commit 8343fd749ff7c494c2f303f20a83b8873c6f0797 ] rwc_non_lf_results->multi_rw, rwc_lf_results->multi_rw, and rwc_perf_results->multi_rw are accessed at indexes [0..NUM_TEST-1][0..1][0..NUMTEST-1]. Currently the first index overflows the array size in struct rwc_perf. Fixes: c7eb0972e74b ("test/hash: add lock-free r/w concurrency") Signed-off-by: Heinrich Schuchardt --- app/test/test_hash_readwrite_lf_perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_hash_readwrite_lf_perf.c b/app/test/test_hash_readwrite_lf_perf.c index 7bfc067f4e..858c883f24 100644 --- a/app/test/test_hash_readwrite_lf_perf.c +++ b/app/test/test_hash_readwrite_lf_perf.c @@ -56,7 +56,7 @@ struct rwc_perf { uint32_t w_ks_r_hit_nsp[2][NUM_TEST]; uint32_t w_ks_r_hit_sp[2][NUM_TEST]; uint32_t w_ks_r_miss[2][NUM_TEST]; - uint32_t multi_rw[NUM_TEST - 1][2][NUM_TEST]; + uint32_t multi_rw[NUM_TEST][2][NUM_TEST]; uint32_t w_ks_r_hit_extbkt[2][NUM_TEST]; }; -- 2.37.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-07-07 09:54:14.131260115 +0200 +++ 0072-test-hash-fix-out-of-bound-access.patch 2022-07-07 09:54:10.993824790 +0200 @@ -1 +1 @@ -From 8343fd749ff7c494c2f303f20a83b8873c6f0797 Mon Sep 17 00:00:00 2001 +From 8caef8fee30e977e7abae526281dd17cf3f99d89 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8343fd749ff7c494c2f303f20a83b8873c6f0797 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 8120cf43be..32f9ec9250 100644 +index 7bfc067f4e..858c883f24 100644 @@ -23 +24 @@ -@@ -59,7 +59,7 @@ struct rwc_perf { +@@ -56,7 +56,7 @@ struct rwc_perf { @@ -30 +30,0 @@ - uint32_t writer_add_del[NUM_TEST]; @@ -31,0 +32 @@ +