From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A9E1A0543 for ; Thu, 7 Jul 2022 09:59:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 970E74282E; Thu, 7 Jul 2022 09:59:06 +0200 (CEST) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mails.dpdk.org (Postfix) with ESMTP id D35DE406B4 for ; Thu, 7 Jul 2022 09:59:05 +0200 (CEST) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id A4B273F1AA for ; Thu, 7 Jul 2022 07:59:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1657180745; bh=WwpDLQbBL8dVBKMErM0KUjQN2R2KebOcJgQ82yPZvX4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Piay0QiOfUOwejHzpyZXy9YZPwiduxudITdORtNN/sjqJeBj8jK0YbAslW3ZkcKqp jFPT1fxX7qVr+rIfaWLSHUNq2jNoTATruehAOAb97YP5tlvNFwCJ3Cvya82tpSY4q0 0dzQWYEP73wO6M7jNVBtRYMrs7IbGsA+EQRATA4gAhGX6VF0583g4Hkyh8R4ucdiEo eQ6mt/H92iDss/cod8oF4HETYa4l8ApOWGD7Vq39PFJWcCHLQM+rM3Mxk/JsGSLt6L 4IT8NBSaA6zmO1QIlDYSbedYxy0KAlv2wHaLb0CnreDnTrpf701w9a3StNv0wv2NdE ZdIWBJcsDMm2Q== Received: by mail-ed1-f70.google.com with SMTP id m10-20020a056402510a00b0043a93d807ffso1456951edd.12 for ; Thu, 07 Jul 2022 00:59:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WwpDLQbBL8dVBKMErM0KUjQN2R2KebOcJgQ82yPZvX4=; b=3MpD622JFlbBDyiqPnEJAtA5H3ALujDRcUTc6ZF5aUCFPmfd+81LR0g8UNie4hNAUU /mIt/u9WIgWRzk8jfDyExRpJx6ttBGLILOdjIlt9ibzqs6cTKE7tj7Z1x3B7+aPZooiC /xUkT8JFA9UpU7OLrzKoQE+KRwe2eB2tow6zkdHVneolbLFa8KvAU0GZ3HjrEIcM8gwS bATgf0Fd5Te5DDieey5ZKjXX0Z3OI74lsDjR60CPUX9Hqx6myt/4aYdLGFwlEduFg+Mf fPodUpvA1QXaXwws+sUg5Co3JDHlyw0/stoUjeQWzivg6k+XT6v+GgbDs5oxGLiUzmW9 x/dQ== X-Gm-Message-State: AJIora/3Pp0sH6qzpCXyXcJ1GiXvd9iKcjj/mnYntGlRqHkWpeFSBBcL OrkKzw7gejfurCTVnWABdakK0fNbaQ7x+baADyaUjiqUiVQToesXX++vxBp7/odoLH1MQC81gF0 KhryyYTk0t/IIdq2T0ugBexdb X-Received: by 2002:a17:906:db:b0:718:d986:d3d7 with SMTP id 27-20020a17090600db00b00718d986d3d7mr42977890eji.532.1657180745299; Thu, 07 Jul 2022 00:59:05 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tuwxfoF2J85q6o00I3kpYpcZBTER6ZCjGe8it4TIg0xSPgHiOicUC3n/alug7iQZoghV/4PA== X-Received: by 2002:a17:906:db:b0:718:d986:d3d7 with SMTP id 27-20020a17090600db00b00718d986d3d7mr42977881eji.532.1657180745145; Thu, 07 Jul 2022 00:59:05 -0700 (PDT) Received: from Keschdeichel.fritz.box ([2a02:6d40:3a4f:7b00:c19b:938e:7c97:afe2]) by smtp.gmail.com with ESMTPSA id o13-20020a170906768d00b0072af6d20a9asm2217681ejm.75.2022.07.07.00.59.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jul 2022 00:59:04 -0700 (PDT) From: christian.ehrhardt@canonical.com To: Hongbo Zheng Cc: Min Hu , dpdk stable Subject: patch 'test: check memory allocation for CRC' has been queued to stable release 19.11.13 Date: Thu, 7 Jul 2022 09:55:08 +0200 Message-Id: <20220707075522.194223-73-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.37.0 In-Reply-To: <20220707075522.194223-1-christian.ehrhardt@canonical.com> References: <20220707075522.194223-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.13 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/09/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/91e1eb689bdee7d4b330df1b556beb12eee86857 Thanks. Christian Ehrhardt --- >From 91e1eb689bdee7d4b330df1b556beb12eee86857 Mon Sep 17 00:00:00 2001 From: Hongbo Zheng Date: Mon, 19 Apr 2021 21:34:44 +0800 Subject: [PATCH] test: check memory allocation for CRC [ upstream commit 52aab95476d69abb522b4a588b664281e8464a7b ] The rte_zmalloc is called in test_crc_calc without null pointer check. This patch adds null pointer checks on return value of rte_zmalloc. Fixes: 9c77b848b1c1 ("test: add CRC computation") Signed-off-by: Hongbo Zheng Signed-off-by: Min Hu (Connor) --- app/test/test_crc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test/test_crc.c b/app/test/test_crc.c index f8a74e04ee..d8b513de32 100644 --- a/app/test/test_crc.c +++ b/app/test/test_crc.c @@ -80,6 +80,8 @@ test_crc_calc(void) /* 32-bit ethernet CRC: Test 2 */ test_data = rte_zmalloc(NULL, CRC32_VEC_LEN1, 0); + if (test_data == NULL) + return -7; for (i = 0; i < CRC32_VEC_LEN1; i += 12) rte_memcpy(&test_data[i], crc32_vec1, 12); -- 2.37.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-07-07 09:54:14.173843044 +0200 +++ 0073-test-check-memory-allocation-for-CRC.patch 2022-07-07 09:54:10.993824790 +0200 @@ -1 +1 @@ -From 52aab95476d69abb522b4a588b664281e8464a7b Mon Sep 17 00:00:00 2001 +From 91e1eb689bdee7d4b330df1b556beb12eee86857 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 52aab95476d69abb522b4a588b664281e8464a7b ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 0ed080e482..5edc8fb13b 100644 +index f8a74e04ee..d8b513de32 100644 @@ -23 +24 @@ -@@ -79,6 +79,8 @@ test_crc_calc(void) +@@ -80,6 +80,8 @@ test_crc_calc(void)