From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D85EFA0540 for ; Thu, 7 Jul 2022 09:59:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4410406B4; Thu, 7 Jul 2022 09:59:08 +0200 (CEST) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id EC7B8406B4 for ; Thu, 7 Jul 2022 09:59:07 +0200 (CEST) Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id A6DD33F1F1 for ; Thu, 7 Jul 2022 07:59:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1657180747; bh=AD1Fe6Uf4w7H4BUa1ZoaFGfF9PZwwz2s7uYFd0uYy7k=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qZGarYNbZTbbi09m8bLNTpL09jVYPPgwPDdM6geumTeN08f0nd6RqJ3tqeaZCIGje lSAd1Xl+tK4L2IxN+qjSAi40QMnV5dlZZkLA1LTFjW4H87i2gT+CeNVbUFR4C2ekSK BsXZf7n7lb1REMafIdb0072N6uoKE+zHo0HVK9NIyXTD3Lesii9E2W9i6mLKp4E7fP BiQXMQjGCBxhy7LmcOxRLVxzfY4yVLtf7xkUDKawtL4+o2jaG43hAg/U2VIv29bCzf 0rxzvJIXAjqd6lrs1HtS4QbF8gflx8W7dK8a2yN5IbLqwQa60LEBMLsyFGzz8stDXn BQ56FWkO2VLXg== Received: by mail-ej1-f70.google.com with SMTP id qb28-20020a1709077e9c00b0072af6ccc1aeso1291498ejc.6 for ; Thu, 07 Jul 2022 00:59:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AD1Fe6Uf4w7H4BUa1ZoaFGfF9PZwwz2s7uYFd0uYy7k=; b=K+BW3YSSBetL10aZPfipXGer1vsF/u9qmr7t42QYp+M7FoKwHfyL2y5eJsu3+pmToq YKVa4uESJWOa/CBuLtsksge08RayWwmMV59rh0a3XET1zQGBAM2aKOu5wWzvPu+FMauv FA8N921iyeicYcrnzyyYDXVhzzhu3jjtIXmVNLXGNlWF6bh9hTzds1CqIJK3HPddwrYG tsV7DpxNb9I/N8HVIrZ6gLT7l4JYRHQfylCXayFfxsQw9k2m3ARegrjwITUUubxXQTKW pqh8nCV6J5vKnyvXk9VpdR3ubfb1t9tRWvVHvDBV4Z13DYwDlPDoyKYYLYQ8Mkers65U Buig== X-Gm-Message-State: AJIora8qcJmMYTKa1R0GkLQ84UX+BkiwUNXl/HYqWtYz3oKxqW3em/f2 rmqAXyb95rqaPKbVX5ZEds7AMRNukJt5sxVdzkSoT6QeoRXGEofhG3OLdKWMiazigJxeg/q6VMP rNGaOlcPZAe3Jt+tmqQM9eoya X-Received: by 2002:a17:907:a077:b0:72b:dc1:c88a with SMTP id ia23-20020a170907a07700b0072b0dc1c88amr2071217ejc.130.1657180747370; Thu, 07 Jul 2022 00:59:07 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uxthXY7Dk5qHulCVOUtb+uyXQdSHc/3ysIqAMJyRHzrlq05x0zsa5HOiIk1+an4E3wlSxw9w== X-Received: by 2002:a17:907:a077:b0:72b:dc1:c88a with SMTP id ia23-20020a170907a07700b0072b0dc1c88amr2071199ejc.130.1657180747094; Thu, 07 Jul 2022 00:59:07 -0700 (PDT) Received: from Keschdeichel.fritz.box ([2a02:6d40:3a4f:7b00:c19b:938e:7c97:afe2]) by smtp.gmail.com with ESMTPSA id o13-20020a170906768d00b0072af6d20a9asm2217681ejm.75.2022.07.07.00.59.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jul 2022 00:59:06 -0700 (PDT) From: christian.ehrhardt@canonical.com To: Damodharam Ammepalli Cc: Ajit Khaparde , Somnath Kotur , dpdk stable Subject: patch 'net/bnxt: allow Tx only or Rx only' has been queued to stable release 19.11.13 Date: Thu, 7 Jul 2022 09:55:10 +0200 Message-Id: <20220707075522.194223-75-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.37.0 In-Reply-To: <20220707075522.194223-1-christian.ehrhardt@canonical.com> References: <20220707075522.194223-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.13 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/09/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/6986cbb030829a80429a862a6adc8b75e3997b83 Thanks. Christian Ehrhardt --- >From 6986cbb030829a80429a862a6adc8b75e3997b83 Mon Sep 17 00:00:00 2001 From: Damodharam Ammepalli Date: Wed, 15 Jun 2022 20:26:59 +0530 Subject: [PATCH] net/bnxt: allow Tx only or Rx only [ upstream commit 8b7e58a791ef7747266b77ed433f5d03a6abaad7 ] Currently, we fail the init/probe of PMD if eth_dev->data->nb_tx_queues or eth_dev->data->nb_rx_queues is 0. We are removing this check. Fixes: daef48efe5e5 ("net/bnxt: support set MTU") Signed-off-by: Damodharam Ammepalli Reviewed-by: Ajit Khaparde Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_ethdev.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 2acde85e96..9c1578e0e9 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -355,7 +355,7 @@ static int bnxt_alloc_prev_ring_stats(struct bnxt *bp) sizeof(struct bnxt_ring_stats) * bp->tx_cp_nr_rings, 0); - if (bp->prev_tx_ring_stats == NULL) + if (bp->tx_cp_nr_rings > 0 && bp->prev_tx_ring_stats == NULL) goto error; return 0; @@ -908,11 +908,6 @@ int bnxt_dev_start_op(struct rte_eth_dev *eth_dev) int vlan_mask = 0; int rc, retry_cnt = BNXT_IF_CHANGE_RETRY_COUNT; - if (!eth_dev->data->nb_tx_queues || !eth_dev->data->nb_rx_queues) { - PMD_DRV_LOG(ERR, "Queues are not configured yet!\n"); - return -EINVAL; - } - if (bp->rx_cp_nr_rings > RTE_ETHDEV_QUEUE_STAT_CNTRS) { PMD_DRV_LOG(ERR, "RxQ cnt %d > CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS %d\n", -- 2.37.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-07-07 09:54:14.250104853 +0200 +++ 0075-net-bnxt-allow-Tx-only-or-Rx-only.patch 2022-07-07 09:54:10.997824815 +0200 @@ -1 +1 @@ -From 8b7e58a791ef7747266b77ed433f5d03a6abaad7 Mon Sep 17 00:00:00 2001 +From 6986cbb030829a80429a862a6adc8b75e3997b83 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8b7e58a791ef7747266b77ed433f5d03a6abaad7 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 34f21496a4..8181e1f37a 100644 +index 2acde85e96..9c1578e0e9 100644 @@ -23 +24 @@ -@@ -723,7 +723,7 @@ static int bnxt_alloc_prev_ring_stats(struct bnxt *bp) +@@ -355,7 +355,7 @@ static int bnxt_alloc_prev_ring_stats(struct bnxt *bp) @@ -32 +33 @@ -@@ -1567,11 +1567,6 @@ int bnxt_dev_start_op(struct rte_eth_dev *eth_dev) +@@ -908,11 +908,6 @@ int bnxt_dev_start_op(struct rte_eth_dev *eth_dev) @@ -41 +42 @@ - if (bp->rx_cp_nr_rings > RTE_ETHDEV_QUEUE_STAT_CNTRS) + if (bp->rx_cp_nr_rings > RTE_ETHDEV_QUEUE_STAT_CNTRS) { @@ -43 +44 @@ - "RxQ cnt %d > RTE_ETHDEV_QUEUE_STAT_CNTRS %d\n", + "RxQ cnt %d > CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS %d\n",