From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6058A0540 for ; Thu, 7 Jul 2022 09:59:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DD569406B4; Thu, 7 Jul 2022 09:59:34 +0200 (CEST) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mails.dpdk.org (Postfix) with ESMTP id 5AD6D406B4 for ; Thu, 7 Jul 2022 09:59:34 +0200 (CEST) Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 8D47B3F04C for ; Thu, 7 Jul 2022 07:59:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1657180773; bh=V0gJpj68Gpi7V1aSYqonGCx/sjJU8A/Zq25zleeEJc8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FKHNNN1V7dzWpCo/8F4L4C+C4V0Qx1cZEvRN14lITyBX3jdCnpEq/DUiLzS1Ru+HQ duc8WmYp0Sa4cOGruef0FetzVwsrupIJsB9Y0Bz9KODXJDm+vciuTWrkMxffM4Zsan 8d3rq+vWFUgx9jgpw1ZEnB3xl7e/8Wuv2uPScJ+dj176zQeWoJqVcqNjWSdttR+KCD Z1pJVjihEHJIo/mrZJI0BaQR95bsnsjOnRVY55o8UIaDYgZwJYZvRrLnqK8qNzu1CH LfOGw+xApcVHjUWVh5zYZSQKeiEBxc4gG2tMOLBT/9zqDxjDyCkgo3CX6HWGH5QrOk c0ZsJU/2jvdkg== Received: by mail-ej1-f69.google.com with SMTP id qa41-20020a17090786a900b00722f313a60eso4407910ejc.13 for ; Thu, 07 Jul 2022 00:59:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=V0gJpj68Gpi7V1aSYqonGCx/sjJU8A/Zq25zleeEJc8=; b=h1NFEfjwHQtBmJk15JfPtRMLqdKrsBe0OzNiplZ8tdaOZPbMbmisJfj5jDbNN4jy4m EklhHo6R7zATJhOnrZYlrY4iWss+9uqMBSrtlWAyWyXuwe6eeyZpyNviVN9inLRKmfk+ VVGNLBnrxIyfYRRWe4ZL3q+ZmQde3eft2ByePfKSM9410+Z7nGjRqEXgmSOdAGYRrz47 KJYXTIrziOmhymz/BUdTtJED0D2nWybQX+GbHLc8LUWZGhmxmfvP8W9nCV+z0lOJKtnI Iidjdz2ojkXpP6HSvCuFJfgf6Udlr/m/x2UkhooQz3AnS3Mv79M9eUZ+ah+aDw14btPy Fu1g== X-Gm-Message-State: AJIora/WBXGU+4rQquwqosvt8xDIbT6M3wYdqa0X+2l8cV3MLg9Xg17q zKdysgmXV+PXt3Z9G5R428DGaySJ+YIhtoBQZADg0uWgGlBM97atlR9hOzffJW1jCJj/CHsCKHZ ki5m+ZmsnYb9ElJ4imaIuUHC5 X-Received: by 2002:a05:6402:2b8b:b0:43a:5475:f1ae with SMTP id fj11-20020a0564022b8b00b0043a5475f1aemr27597373edb.363.1657180773386; Thu, 07 Jul 2022 00:59:33 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sGER2oOYZv9uLeDwYHqOeO5sDvEVEIo5BzV3+HsKHte9Nkf+6vA0FkQLKuSsYDuBwo0fGYPg== X-Received: by 2002:a05:6402:2b8b:b0:43a:5475:f1ae with SMTP id fj11-20020a0564022b8b00b0043a5475f1aemr27597356edb.363.1657180773227; Thu, 07 Jul 2022 00:59:33 -0700 (PDT) Received: from Keschdeichel.fritz.box ([2a02:6d40:3a4f:7b00:c19b:938e:7c97:afe2]) by smtp.gmail.com with ESMTPSA id h17-20020a1709060f5100b00705cdfec71esm18405664ejj.7.2022.07.07.00.59.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jul 2022 00:59:32 -0700 (PDT) From: christian.ehrhardt@canonical.com To: Rebecca Troy Cc: Fan Zhang , dpdk stable Subject: patch 'crypto/qat: fix DOCSIS crash' has been queued to stable release 19.11.13 Date: Thu, 7 Jul 2022 09:55:16 +0200 Message-Id: <20220707075522.194223-81-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.37.0 In-Reply-To: <20220707075522.194223-1-christian.ehrhardt@canonical.com> References: <20220707075522.194223-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 19.11.13 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/09/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/cpaelzer/dpdk-stable-queue This queued commit can be viewed at: https://github.com/cpaelzer/dpdk-stable-queue/commit/02686ad4e9e94929c4c0605856c21b68c22f37c2 Thanks. Christian Ehrhardt --- >From 02686ad4e9e94929c4c0605856c21b68c22f37c2 Mon Sep 17 00:00:00 2001 From: Rebecca Troy Date: Wed, 29 Jun 2022 16:10:36 +0000 Subject: [PATCH] crypto/qat: fix DOCSIS crash [ upstream commit 03f0e3608d44d468b22ed17c30144d87edeb3ee9 ] Currently if AES or DES algorithms fail for DOCSIS test suite, a segmentation fault occurs when cryptodev_qat_autotest is ran. This is due to a duplicate call of EVP_CIPHER_CTX_free for the session context. Ctx is freed firstly in the bpi_cipher_ctx_init function and then again at the end of qat_sym_session_configure_cipher function. This commit fixes this bug by removing the first instance of EVP_CIPHER_CTX_free, leaving just the dedicated function in the upper level to free the ctx. Fixes: 98f060891615 ("crypto/qat: add symmetric session file") Signed-off-by: Rebecca Troy Acked-by: Fan Zhang --- drivers/crypto/qat/qat_sym_session.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_sym_session.c index 17647ea7b5..8c148c9cef 100644 --- a/drivers/crypto/qat/qat_sym_session.c +++ b/drivers/crypto/qat/qat_sym_session.c @@ -97,8 +97,10 @@ bpi_cipher_ctx_init(enum rte_crypto_cipher_algorithm cryptodev_algo, return 0; ctx_init_err: - if (*ctx != NULL) + if (*ctx != NULL) { EVP_CIPHER_CTX_free(*ctx); + *ctx = NULL; + } return ret; } -- 2.37.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-07-07 09:54:14.488468661 +0200 +++ 0081-crypto-qat-fix-DOCSIS-crash.patch 2022-07-07 09:54:11.021824964 +0200 @@ -1 +1 @@ -From 03f0e3608d44d468b22ed17c30144d87edeb3ee9 Mon Sep 17 00:00:00 2001 +From 02686ad4e9e94929c4c0605856c21b68c22f37c2 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 03f0e3608d44d468b22ed17c30144d87edeb3ee9 ] + @@ -19 +20,0 @@ -Cc: stable@dpdk.org @@ -28 +29 @@ -index e40c042ba9..b30396487e 100644 +index 17647ea7b5..8c148c9cef 100644 @@ -31 +32 @@ -@@ -136,8 +136,10 @@ bpi_cipher_ctx_init(enum rte_crypto_cipher_algorithm cryptodev_algo, +@@ -97,8 +97,10 @@ bpi_cipher_ctx_init(enum rte_crypto_cipher_algorithm cryptodev_algo,