From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A8C0A00C5 for ; Wed, 20 Jul 2022 10:23:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5332D40697; Wed, 20 Jul 2022 10:23:53 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2052.outbound.protection.outlook.com [40.107.101.52]) by mails.dpdk.org (Postfix) with ESMTP id 89E184003C for ; Wed, 20 Jul 2022 10:23:51 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UDLqFqCYHCAULUEiDorZiFJ2hkUS0THKR9RnIVPr8pzyqYNr3uI7kPNZOL32wKfA+07hOX50JDkjZqXqxL9Pn4hCuwMqxtuf5nVCCL4uoFOGvsBY8yoj7YtGSCMfSpIEjJF/bq43foMXv6irZ0RKXHbMpAvK9huoWrPzgKQUjuQTuOcmp073xxx0pMZCGMuIVBJGP/cGlsTZcfvioEaBBFsq6qiKwD7ra8X8/fvem32ALtFDqYSweNTnuBXJAuM1zwKXxtHyv8VbTtmrEIaMAy/I+T+JpwAT0kvifPWUBoRDaKEE1W7tnBc7fc1cM65xi/ouNr0uHL/hEUH4jqX0Og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0Ig7nynX2LNF4cA3XZzgZLk8wBnhX2Etgr28FBXwJtI=; b=H72dWY+91H0RA6f5hWrmtYANc2mLRsJMUxnon9GKrJP+VsRsxs8uo4QS97THgska5QpWNn4UfExsJ1xQnhtsF3ByrZJk1cyTJKIleOqNand79aWZpW8xlVh3mLsETLtEYaMVERpxsXnqNIkzdfq/5Hi7/GXetWw96dA1CP5IofMCE96gGoFBaYB3kqfe6ZaFJeQK08+GhaYJYQ+JJESKl/phzIY0YCt7/NWhBdKbAtPdDaeZr1cbxEUvM6QXTLSBB21/bI1gDyBSCDbtodch8DmIr73MJ8F1/+5D2cswVe11uPIGtyVLifhMownKyzKIqFSnyRukk+G+0DznYCv3Qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.235) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0Ig7nynX2LNF4cA3XZzgZLk8wBnhX2Etgr28FBXwJtI=; b=P+n2qQRRY78wQi78bpeNGEt+MsPrnBMEd6yHd6Vrn/ztmXYMbU7rIU8UXhekF6uEufAkX2XPhDiiva1KkQsLcbHT0dQKRVL9BM84iMT7xwQWaCYb80oTuXaH9wCZrVn5F3VNqrTC7HNjK9j2pyFeQRp69lfEKD4XnGLpP4cXLm94j21VQn6yO4jEO+p3NpaWZXT9myBMmdksjhwQZvtOJ4QM8rXZUmH+EjAud6aByzHVt1XxdtPveIhRgOmTKMZFwm1R9hWbM6ebuob3wGIbHTRQxLbY3b62uQUMRblbWd31DRlTqSWQqpnwjGhVaDCdy+k1/Tcse+3t34v31975Tw== Received: from MW4PR04CA0330.namprd04.prod.outlook.com (2603:10b6:303:82::35) by DM5PR12MB1546.namprd12.prod.outlook.com (2603:10b6:4:8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.21; Wed, 20 Jul 2022 08:23:49 +0000 Received: from CO1NAM11FT033.eop-nam11.prod.protection.outlook.com (2603:10b6:303:82:cafe::48) by MW4PR04CA0330.outlook.office365.com (2603:10b6:303:82::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26 via Frontend Transport; Wed, 20 Jul 2022 08:23:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.235) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.235 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.235; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (12.22.5.235) by CO1NAM11FT033.mail.protection.outlook.com (10.13.174.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5458.17 via Frontend Transport; Wed, 20 Jul 2022 08:23:49 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Wed, 20 Jul 2022 08:23:49 +0000 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Wed, 20 Jul 2022 01:23:47 -0700 From: Xueming Li To: Maxime Coquelin CC: , Chenbo Xia , Aman Singh , dpdk stable Subject: patch 'app/testpmd: revert MAC update in checksum forwarding' has been queued to stable release 20.11.6 Date: Wed, 20 Jul 2022 11:20:50 +0300 Message-ID: <20220720082132.3954126-21-xuemingl@nvidia.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220720082132.3954126-1-xuemingl@nvidia.com> References: <20220621080301.2315720-1-xuemingl@nvidia.com> <20220720082132.3954126-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cf6fb6eb-5d4c-49cc-c8aa-08da6a292c4b X-MS-TrafficTypeDiagnostic: DM5PR12MB1546:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?skkz76zfJioLUMwqweoWtYRj+v5oPe2YqRyKsaT1xqWzA7LZUi7C/tUyHSkp?= =?us-ascii?Q?sx+wsVw5/dGF4SIafAPSUxcAEyrNbQgxrFo5dBM1eOls2rSgPGpby264JFwH?= =?us-ascii?Q?fKpbzxlyoIWjwxnYSnuxEbmr4cP+vn3jpNizXXbMPFkL6OhcAypk02zgFKdD?= =?us-ascii?Q?KFbt7zw/NvCrnu/+bzbP2ptFCgxjXTYcwDKBoHopPkkyCinTmbQAOSts3fCG?= =?us-ascii?Q?fY5mLEpqOYFvJDTYQJ9v9ldN309uTrAQj5iOxLF7wDqB8Wudk08W6r5ikjqb?= =?us-ascii?Q?ONR8gZpdn2EwTlsIvOvWWmcPgjTjC73M9Y7310nXV6klHdtei0Ol9yHBafzs?= =?us-ascii?Q?W+hDOYA1vnBRHJV7/SLfvPkzvjkb6SPEsRQalkVBjtleevMDhHXWHNau11J9?= =?us-ascii?Q?WxxqO/vAk88zgBhiTDzTPETucfMphoXuL9v0xvLsrM6nrgpxRhQZLzL6Qg/k?= =?us-ascii?Q?/aqjb/GpcBUa7BlG4FXcEBBw/hOMCzxcLAUQbmieW0FkG2kR4lI7mJJ/cJXY?= =?us-ascii?Q?RpeI1U9if/iLUkiGEBy0Jypsq60I23SPgGIpzgl53B8CfNbgeIYSS/RtZALE?= =?us-ascii?Q?VEflhaFbG2tWqEGeAR12umTh1hIK+G610wpieouP4hQy3k9p9vZWv7UsHhUC?= =?us-ascii?Q?XIJLRZuSeZLzlYeXhzVraehRMnIDmxgIH1PUdYJKrwfYhCfywtscpc9mMovw?= =?us-ascii?Q?Ms39wnuw/fj7Zwo+JWP8m/x1n7JLxO2ONhrxh4g4b+FjRf6ieNhfx7YEfh3h?= =?us-ascii?Q?Yt+OSlBFNyndq1Cb1EcGNXTQxz1485+k9a+H9uhrw9zdz+LtO/JE6f/rep8K?= =?us-ascii?Q?LFS5uwxu2qe++v97q+pSELFDSpX/e9lVpR4u4ZLZ4wXvRrOwXaRGPOOeChiP?= =?us-ascii?Q?IlyRvVtI7eZaCqXMPpsnRKBCL/QPGm/hhuRaJr3PG9NkJrKpD1iknv0Fh9VV?= =?us-ascii?Q?cT68i4LOlhm8IRthMJWZFQ=3D=3D?= X-Forefront-Antispam-Report: CIP:12.22.5.235; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230016)(4636009)(376002)(346002)(39860400002)(396003)(136003)(46966006)(36840700001)(40470700004)(6286002)(40480700001)(8936002)(81166007)(70206006)(8676002)(4326008)(53546011)(82740400003)(70586007)(15650500001)(40460700003)(7696005)(36756003)(54906003)(2906002)(6916009)(356005)(41300700001)(26005)(316002)(55016003)(6666004)(1076003)(186003)(426003)(478600001)(2616005)(82310400005)(336012)(16526019)(36860700001)(5660300002)(966005)(83380400001)(86362001)(47076005)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2022 08:23:49.4620 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cf6fb6eb-5d4c-49cc-c8aa-08da6a292c4b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.235]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT033.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1546 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/22/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/bbba8ef0cd92ddf853dcd6035e64b62df464bbb8 Thanks. Xueming Li --- >From bbba8ef0cd92ddf853dcd6035e64b62df464bbb8 Mon Sep 17 00:00:00 2001 From: Maxime Coquelin Date: Wed, 8 Jun 2022 14:49:41 +0200 Subject: [PATCH] app/testpmd: revert MAC update in checksum forwarding Cc: Xueming Li [ upstream commit 9b4ea7ae77faa8f8aba8c7510c821f75d7863b16 ] This patch reverts commit 10f4620f02e1 ("app/testpmd: modify mac in csum forwarding"), as the checksum forwarding is expected to only perform checksum and not also overwrites the source and destination MAC addresses. Doing so, we can test checksum offloading with real traffic without breaking broadcast packets. Fixes: 10f4620f02e1 ("app/testpmd: modify mac in csum forwarding") Signed-off-by: Maxime Coquelin Acked-by: Chenbo Xia Acked-by: Aman Singh --- app/test-pmd/csumonly.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 8adac07cb6..ffec25f308 100644 --- a/app/test-pmd/csumonly.c +++ b/app/test-pmd/csumonly.c @@ -888,10 +888,6 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) * and inner headers */ eth_hdr = rte_pktmbuf_mtod(m, struct rte_ether_hdr *); - rte_ether_addr_copy(&peer_eth_addrs[fs->peer_addr], - ð_hdr->d_addr); - rte_ether_addr_copy(&ports[fs->tx_port].eth_addr, - ð_hdr->s_addr); parse_ethernet(eth_hdr, &info); l3_hdr = (char *)eth_hdr + info.l2_len; -- 2.35.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-07-20 15:00:59.756426957 +0800 +++ 0021-app-testpmd-revert-MAC-update-in-checksum-forwarding.patch 2022-07-20 15:00:58.707667169 +0800 @@ -1 +1 @@ -From 9b4ea7ae77faa8f8aba8c7510c821f75d7863b16 Mon Sep 17 00:00:00 2001 +From bbba8ef0cd92ddf853dcd6035e64b62df464bbb8 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 9b4ea7ae77faa8f8aba8c7510c821f75d7863b16 ] @@ -15 +17,0 @@ -Cc: stable@dpdk.org @@ -25 +27 @@ -index 7df201e047..1a3fd9ce8a 100644 +index 8adac07cb6..ffec25f308 100644 @@ -28 +30 @@ -@@ -916,10 +916,6 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) +@@ -888,10 +888,6 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) @@ -33 +35 @@ -- ð_hdr->dst_addr); +- ð_hdr->d_addr); @@ -35 +37 @@ -- ð_hdr->src_addr); +- ð_hdr->s_addr);