From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6B28A00C5 for ; Wed, 20 Jul 2022 10:26:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CEEFF40697; Wed, 20 Jul 2022 10:26:28 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2050.outbound.protection.outlook.com [40.107.223.50]) by mails.dpdk.org (Postfix) with ESMTP id B7B574003C for ; Wed, 20 Jul 2022 10:26:26 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uw68JwefeAJbw8qe3kTrTU4NWK3WddxDTV8K9TAaTk42LX7bpm07fWYMy1htlHJ5UH5mUNIF/2g/k0xAS4NVl7HGPXPmE0NJMwvAoqYil65noD0Y+6tutt5QwIOudUNLzitQl0k4oyi0O1zGTLFhEmS3zm0lOhb/DsnQ0JXRhewG6Ya03mUgjiN521DvLaS5M5QFMz6SDr+m4IwaedtaVwhYmOCzo8dCQe7gVGcvPxtAwLTRKBavlIUvht9HDD8COuHClFvFRIRETD7YN2PaXvvVWZtUTX0RGrDTFz0swx2woNlLm/qCxDF5eEHNsBTgXzGJ+5w8ToyUD3AtoeMRpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bFknDAeMz+k2FReaI+bZKeaueNgu0v0Z9Ks4nabZ9gA=; b=j2rNtW1OEy/XTKP/wv8KBypS7NUSTX3Rv9NEoLJBWRIeKAdRQ5hm74+P0GFKrbA3We4ZkfWDjBgfEXMkVjNch9unE1ZNqpMZb9f8HAi4FlCaGN59wArH9B9f40F6xX+u4wxH3jLo0VHWUxpb+2HTFyMHE82VjnqPkAMYYFNf2OCfJV8OZn2o7h8sw19GSuZLnPZA1UsqxZ0LJBpqvBluJ1IrNhAo2ip+FE5FFzFqnMRGdx7+5APosaSMpW5u/u8f+1KxLO/rRF9JV7RdsiWcLijiZZBHRFC8tf/BCbqRVaKo8EeSHA1X+dEy1ffJts0tdsglgE9+tnjz8s4nZWwmBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.236) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bFknDAeMz+k2FReaI+bZKeaueNgu0v0Z9Ks4nabZ9gA=; b=kFWlnWjBjqNAUYWLFO6Oom1Nl1gQkFmubK1HeLI/GnW9TfE37Bso61jmCQ3+A+PM79glYUGk1PV3hwNwfk5oA5pF6uEQRwYCmvRoHdeHgwZEUgWHhp+5SzuytTDFIF+nq3a7bvkIa25UNliJM9CY3x2NImgtvyIcfzqRheD+Qd5hfiZ50rcI05ts53cZtLT3Hu4i6EjzGo8XOCdVPuh50swj9cMRkvs2Gr3Sf4vCUS71T7um6fQjBrvJsqZWtCD8vL0WROH7i/fRLQfjXjskHmfnQs2r/HkCwgTjd5svzZMD6rxJIyrxUch4fpfq4M6YU7k2PLJ8Ddl7t+RsAJy/fA== Received: from MW4P222CA0013.NAMP222.PROD.OUTLOOK.COM (2603:10b6:303:114::18) by CH2PR12MB5516.namprd12.prod.outlook.com (2603:10b6:610:6b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.20; Wed, 20 Jul 2022 08:26:24 +0000 Received: from CO1NAM11FT035.eop-nam11.prod.protection.outlook.com (2603:10b6:303:114:cafe::43) by MW4P222CA0013.outlook.office365.com (2603:10b6:303:114::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.25 via Frontend Transport; Wed, 20 Jul 2022 08:26:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.236) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.236 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.236; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (12.22.5.236) by CO1NAM11FT035.mail.protection.outlook.com (10.13.175.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5458.17 via Frontend Transport; Wed, 20 Jul 2022 08:26:23 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL109.nvidia.com (10.27.9.19) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Wed, 20 Jul 2022 08:26:23 +0000 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Wed, 20 Jul 2022 01:26:21 -0700 From: Xueming Li To: Rebecca Troy CC: , Fan Zhang , dpdk stable Subject: patch 'crypto/qat: fix DOCSIS crash' has been queued to stable release 20.11.6 Date: Wed, 20 Jul 2022 11:21:20 +0300 Message-ID: <20220720082132.3954126-51-xuemingl@nvidia.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220720082132.3954126-1-xuemingl@nvidia.com> References: <20220621080301.2315720-1-xuemingl@nvidia.com> <20220720082132.3954126-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 910261e5-af34-40f6-e48c-08da6a298863 X-MS-TrafficTypeDiagnostic: CH2PR12MB5516:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?XouIrXQpICWSma6FD+CFQ192IELo/hbGH84Hjd9x0jP7QUxqmHxocK0NhVAY?= =?us-ascii?Q?Loz3ftYbshPCltciOjjJoxInZDGyZ8KOeQAPJy2wwDcjfLHdOg1kfWAk+biQ?= =?us-ascii?Q?3/A1D1ucDPGQv2o1X4KRrWPONSES+Ml7JP1F6B+0rWONLhjI/mHUenLzgjrI?= =?us-ascii?Q?lq/pMSKWW+p7J1MvMwIqvZW6JhnjarJKpOOrdi2m7JsJ/Fl6tihzUsRb4jAt?= =?us-ascii?Q?jpgogPlv3PxlxsXecbfLgyb75O232Y863dvG3cNqdunn3vivZs2b+qXVEw+C?= =?us-ascii?Q?bmLkEBbQ/xvOU4xY5kqU/NBEKSBcQUYYrMXyIKMAZKczF9PowAn4KoKykPyh?= =?us-ascii?Q?beuuw1vhJQLwCpzwffRjM8L+ky33QLYPMcZP+ckvWTfxywI3wJ39v7f2K+Q2?= =?us-ascii?Q?Aa0nzWnfMHnXm2PDKdTsCptPLjeEs4O565QKtYX03zAIgYBTipQ44GVk7heU?= =?us-ascii?Q?6f6TspZwFNMs9jDUlSaf7HhLT9up652w7X+aA9po1MeqCeSaHFz379vQXrBL?= =?us-ascii?Q?5GA0JKh4Q75c+UZk9plFluh6qRaVccfoO+nuq/AWqIWikZxR3rzo6QZLV5z+?= =?us-ascii?Q?7aiUqoyj9gra4TLxf+3ukd8rHikKKkkCPwWRMlvlt7ZsO939CTwCHjbP1cro?= =?us-ascii?Q?dIBCJIauyBg+S0h7DOQmbAXOp1WCtk+cILc/ybjJs5mNZ+ED663FuRq8ange?= =?us-ascii?Q?orTKtSYjnoQE0ZdSxKLRO0pXQTK8SRSWo8yIR88dxR+3Tw4VidkxHhLStr/F?= =?us-ascii?Q?MlnT5nuScqbdy1FT4djFVxq4j0lufVEiTlub1xtOEpZ6hcfdF0z4Gh2TPspW?= =?us-ascii?Q?5UJ1/YjcjHjP2slrUgsitRYfKOL3THS0lbhWVlkOLXE/bs5c6IRdTfw4Z7mp?= =?us-ascii?Q?60Jni9oyMxuvkSvypOMwhWZGx0eSrZPjhUuhKWCzPsb1QfgAPZ8O3D6I6YZ2?= =?us-ascii?Q?GbtSDArsdXMrg6Nq2VKK3Q=3D=3D?= X-Forefront-Antispam-Report: CIP:12.22.5.236; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(376002)(136003)(396003)(346002)(36840700001)(40470700004)(46966006)(316002)(86362001)(8936002)(8676002)(5660300002)(356005)(7696005)(55016003)(82740400003)(81166007)(53546011)(83380400001)(4326008)(70586007)(186003)(426003)(16526019)(2616005)(1076003)(82310400005)(26005)(40460700003)(6916009)(41300700001)(70206006)(40480700001)(336012)(478600001)(54906003)(47076005)(36860700001)(6286002)(36756003)(966005)(2906002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2022 08:26:23.9704 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 910261e5-af34-40f6-e48c-08da6a298863 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.236]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT035.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB5516 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/22/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/5a12a4c1fa0e030e9c4197dc01751d82087a68af Thanks. Xueming Li --- >From 5a12a4c1fa0e030e9c4197dc01751d82087a68af Mon Sep 17 00:00:00 2001 From: Rebecca Troy Date: Wed, 29 Jun 2022 16:10:36 +0000 Subject: [PATCH] crypto/qat: fix DOCSIS crash Cc: Xueming Li [ upstream commit 03f0e3608d44d468b22ed17c30144d87edeb3ee9 ] Currently if AES or DES algorithms fail for DOCSIS test suite, a segmentation fault occurs when cryptodev_qat_autotest is ran. This is due to a duplicate call of EVP_CIPHER_CTX_free for the session context. Ctx is freed firstly in the bpi_cipher_ctx_init function and then again at the end of qat_sym_session_configure_cipher function. This commit fixes this bug by removing the first instance of EVP_CIPHER_CTX_free, leaving just the dedicated function in the upper level to free the ctx. Fixes: 98f060891615 ("crypto/qat: add symmetric session file") Signed-off-by: Rebecca Troy Acked-by: Fan Zhang --- drivers/crypto/qat/qat_sym_session.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_sym_session.c index aa9ce1236b..2a9b2712f6 100644 --- a/drivers/crypto/qat/qat_sym_session.c +++ b/drivers/crypto/qat/qat_sym_session.c @@ -103,8 +103,10 @@ bpi_cipher_ctx_init(enum rte_crypto_cipher_algorithm cryptodev_algo, return 0; ctx_init_err: - if (*ctx != NULL) + if (*ctx != NULL) { EVP_CIPHER_CTX_free(*ctx); + *ctx = NULL; + } return ret; } -- 2.35.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-07-20 15:01:01.181766889 +0800 +++ 0051-crypto-qat-fix-DOCSIS-crash.patch 2022-07-20 15:00:58.791000367 +0800 @@ -1 +1 @@ -From 03f0e3608d44d468b22ed17c30144d87edeb3ee9 Mon Sep 17 00:00:00 2001 +From 5a12a4c1fa0e030e9c4197dc01751d82087a68af Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 03f0e3608d44d468b22ed17c30144d87edeb3ee9 ] @@ -19 +21,0 @@ -Cc: stable@dpdk.org @@ -28 +30 @@ -index e40c042ba9..b30396487e 100644 +index aa9ce1236b..2a9b2712f6 100644 @@ -31 +33 @@ -@@ -136,8 +136,10 @@ bpi_cipher_ctx_init(enum rte_crypto_cipher_algorithm cryptodev_algo, +@@ -103,8 +103,10 @@ bpi_cipher_ctx_init(enum rte_crypto_cipher_algorithm cryptodev_algo,