From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BA9FA00C5 for ; Wed, 20 Jul 2022 10:26:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3656D41614; Wed, 20 Jul 2022 10:26:32 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2077.outbound.protection.outlook.com [40.107.94.77]) by mails.dpdk.org (Postfix) with ESMTP id 53C3340FAE for ; Wed, 20 Jul 2022 10:26:30 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Irfx0oEDuy5PWL6cIXpu5+LNMPMDeyfRDR8cnQeYxXfCuEYk936PCRYAkA5VS3gj2eTQ+2N6UPsNleLEheDyNQNF/wVqtt7+MoOb9HgxRrwJEq9AV/Dh7BpszuN8VdMxjlOhbUoCWJUEcDsDEaNQUOpH0GJKaoPCuHEbXFBlMJ8zD+xhKqyxfPc22GaBHszia+ntM3vnKtlxfiovoGkw35y6FW1/eO0Of/lhkgwXid3C9hmfd8HzYWExAs7x2XVHYpwuRc6A5hYDsOH6hU0T3+UMBFAdwRL41EsaeWsQLkNHg0HJknltwh2BN8QeKGHAhBS6Z8jDonbR6wTez3GglA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rQwg4DgyhquggdP6mtlL2a3TMCdlq33gsXXPZFQ2lr8=; b=cGWZKA5VMQEpRhTUO7Ov2wNg+4HVGoJrABuyDNcQbfmlj2t4c7ySfPEagc0XX5641MmrLSJaIqc0WHcYez/AhZ1yz6aAsBzHoDXgD0YVaSGIA29VadUW8qkjllNMYuhPJcQazvHhgJC46IpTggkkE2p+bOQ9mxpdOYhj4MFztfuoz1mZvVlJu5Dq+YqKmtLQTmjRQY0bgsZB+gyVXo4jf18k0Awfa+vD+3nB4e1cuHkGfnDL8zC/ohASLjVXBfolgGNPauRT5oNMa6lor0MRP8jxuSZ6e6M56cpBy49H4FwKYJcED6N49ydfJzF4BdNbbkaaDNKWot7Feod/xjAYgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.235) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rQwg4DgyhquggdP6mtlL2a3TMCdlq33gsXXPZFQ2lr8=; b=khRgAoJyGBmUS30eFX3jnNou9CB9sXtEOkTVkTAQwP+gsl3cEQ7Na5SuCNzHhhcpQXGUKSNP+/XM6O6yiA6iQwdzy9Jamuu5O3U9ln3zTIvM6xMPiiEd8axA+ftpku9RcSGKqpbbToIQxdkYcy5cmFMQ1geZZyoxaqArPOLBceLK6JoVn1d90tYuAVwUTuBqH0apCEXL5i77VJ2ECEbiOxDVwsYreQDhoJzJKT2JanJrPg/TJigaUmzNWkiOpXL/xX0aIjOu6PZu4jKB8Gz0pZ7olLtQkph/cmFAYSvVFxLoKct0ESKKBrTHPR7cholGK/cbURifbGt0zUEs8JbIyg== Received: from MW3PR05CA0005.namprd05.prod.outlook.com (2603:10b6:303:2b::10) by CH2PR12MB3734.namprd12.prod.outlook.com (2603:10b6:610:2a::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.20; Wed, 20 Jul 2022 08:26:26 +0000 Received: from CO1NAM11FT027.eop-nam11.prod.protection.outlook.com (2603:10b6:303:2b:cafe::8c) by MW3PR05CA0005.outlook.office365.com (2603:10b6:303:2b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.7 via Frontend Transport; Wed, 20 Jul 2022 08:26:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.235) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.235 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.235; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (12.22.5.235) by CO1NAM11FT027.mail.protection.outlook.com (10.13.174.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5458.17 via Frontend Transport; Wed, 20 Jul 2022 08:26:26 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Wed, 20 Jul 2022 08:26:25 +0000 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Wed, 20 Jul 2022 01:26:23 -0700 From: Xueming Li To: Ciara Power CC: , Fan Zhang , dpdk stable Subject: patch 'doc: fix grammar and formatting in compressdev guide' has been queued to stable release 20.11.6 Date: Wed, 20 Jul 2022 11:21:21 +0300 Message-ID: <20220720082132.3954126-52-xuemingl@nvidia.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220720082132.3954126-1-xuemingl@nvidia.com> References: <20220621080301.2315720-1-xuemingl@nvidia.com> <20220720082132.3954126-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d3146c05-6574-4b14-79cb-08da6a2989d8 X-MS-TrafficTypeDiagnostic: CH2PR12MB3734:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WTB5Zko2Umpzei9PYUVuNDgyeEhENDRVNDV0M1A4dG54aFpqZFg1N1Awak9h?= =?utf-8?B?QVRtVzNLM1lnWGJ6RWxzc09zUGNKK2d2TkJwTE5tcWlDVFE4Q0plWkVKVjhx?= =?utf-8?B?NEVDNWcxcmNOclNpSExGR1N3TXlURHBncFFxeGtDRS9vem1VRmpLZUQvV2tJ?= =?utf-8?B?Z1pmMStrU1pzM1dLK3EyNmVWTE0xNFlxMElMVk5JSThjdUZOYlJRVzA2aWk0?= =?utf-8?B?RHR3T1lodVR1Zyt5VWgwR0R4NXNKbnJaNlZsMWpEMGpiTDZyVGowbGdocjlo?= =?utf-8?B?Qmx6aUk0ejkzQUlMUWNIUnpNOEUyOFVOQmJUVFpyVjduMG8xREVsMEJ6em9F?= =?utf-8?B?ZlJ0SFgwcmxnQTlxTnh0aEwzZm9rZEpFUVhHcUFwM3I3c2dLdzVvQnEySXUr?= =?utf-8?B?aWJKRFhoYlZjVGI3T2VwREVEa0tFZk1lTVdDU1lUNFA2djRUTDhsaUxhaUVK?= =?utf-8?B?OS9Hd0l1WEowMlIvU0tCNzdLNno0bE04UWJ6SW9YdVIxNDMwOEZDenVuMlpL?= =?utf-8?B?QWVSUjBST0NHVXhTdFkwWHBtSU5Zd1RFc3FmbitDeVozaElrK3REMVBWamJx?= =?utf-8?B?NGdYOVRPVi83UVJoZkxwYi9xUUJoa2hhL2F1Z1NxUUp2SUFrUnZvMTIyZXV3?= =?utf-8?B?U3VXU2U1MlpCcmNqbjFrVG1jV0s5QWJlbEdYeXBHc1hVTTVxYWVFQTFPK0Ny?= =?utf-8?B?RzE3R3FOWXdhdURFM0ZpUkRCdlV4U1NPcGVqV1VZa1NrOC9QeGxsZStLK2Q2?= =?utf-8?B?THF0OXMzMDNEZlppVUF0bUhSUXljZjU4bGlBWW1vNERoTldwZDgxMzNYelQx?= =?utf-8?B?VldTQmtjK0ROVVFGS3c5V1NPU2UrdHhoaENDRkNIaDZ3Z0VIc05jWVorV1Ri?= =?utf-8?B?Y1RKK1hzenozSU9KZ0Zudk51VlYxZGtWTGtSbWZZa3BBZ09UYk5UdkZVNEw1?= =?utf-8?B?WHIydHFITDVlalR2SWlEaVpCOUppaXU2ZDhMaEVsWlVmNHptditMNkcwTkdr?= =?utf-8?B?QVpoa3pscThQU1g0RWVBeWFQeWtra1VMQUZESVg5ZjRGRE1KK2NrS1dPOW9s?= =?utf-8?B?Q0M0ZE40NXdscjJEZkVnS2s2N0FCQVcvWUtPM2c4YXdjMUlBVWFjR0ZDYkhY?= =?utf-8?B?T2RpakJSVEpnTXc2ZXhvUHdYajhtRkxseFMreEtFRkNjTGErYWZQU1IzbjRN?= =?utf-8?B?aTMreTlRY0VQZ2tkSi9XRFhVZmd4WlRMTUpJNEhJcWRYQ0ZYczBaU2xidlg4?= =?utf-8?B?QUFtYnM1MmRYbEpYaURNZHVRMGY3TjNSNFBKY2FvNFhzUjM0ZkcwY3JWV1lq?= =?utf-8?Q?iA8+4AerD7ZI4=3D?= X-Forefront-Antispam-Report: CIP:12.22.5.235; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(136003)(396003)(376002)(346002)(40470700004)(46966006)(36840700001)(41300700001)(81166007)(86362001)(6286002)(83380400001)(82740400003)(53546011)(26005)(478600001)(36860700001)(7696005)(186003)(1076003)(426003)(336012)(356005)(5660300002)(70206006)(36756003)(70586007)(40480700001)(47076005)(55016003)(4326008)(8676002)(30864003)(82310400005)(316002)(16526019)(2906002)(6916009)(966005)(54906003)(8936002)(2616005)(40460700003)(21314003)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2022 08:26:26.3809 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d3146c05-6574-4b14-79cb-08da6a2989d8 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.235]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT027.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB3734 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/22/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/92962694e870727efa84358a3323c58ee1c2d8a0 Thanks. Xueming Li --- >From 92962694e870727efa84358a3323c58ee1c2d8a0 Mon Sep 17 00:00:00 2001 From: Ciara Power Date: Mon, 30 May 2022 16:03:42 +0000 Subject: [PATCH] doc: fix grammar and formatting in compressdev guide Cc: Xueming Li [ upstream commit 4c9484373fcd0aa4a240fdb2e797269eb2f26b9b ] Small improvements made to the compressdev programmer's guide. This includes rephrasing some sentences, fixing grammar, and aligning formatting. Fixes: a584d3bea902 ("doc: add compressdev library guide") Fixes: f7095d41bba6 ("doc: clarify data plane error handling in compressdev") Signed-off-by: Ciara Power Acked-by: Fan Zhang --- doc/guides/prog_guide/compressdev.rst | 283 ++++++++++++++------------ 1 file changed, 148 insertions(+), 135 deletions(-) diff --git a/doc/guides/prog_guide/compressdev.rst b/doc/guides/prog_guide/compressdev.rst index 07d1a62a63..2a59c434c1 100644 --- a/doc/guides/prog_guide/compressdev.rst +++ b/doc/guides/prog_guide/compressdev.rst @@ -2,7 +2,7 @@ Copyright(c) 2017-2018 Cavium Networks. Compression Device Library -=========================== +========================== The compression framework provides a generic set of APIs to perform compression services as well as to query and configure compression devices both physical(hardware) and virtual(software) @@ -32,10 +32,10 @@ From the command line using the --vdev EAL option .. Note:: - * If DPDK application requires multiple software compression PMD devices then required - number of ``--vdev`` with appropriate libraries are to be added. + * If a DPDK application requires multiple software compression PMD devices then the + required number of ``--vdev`` args with appropriate libraries are to be added. - * An Application with multiple compression device instances exposed by the same PMD must + * An application with multiple compression device instances exposed by the same PMD must specify a unique name for each device. Example: ``--vdev 'pmd0' --vdev 'pmd1'`` @@ -53,7 +53,7 @@ All virtual compression devices support the following initialization parameters: Device Identification ~~~~~~~~~~~~~~~~~~~~~ -Each device, whether virtual or physical is uniquely designated by two +Each device, whether virtual or physical, is uniquely designated by two identifiers: - A unique device index used to designate the compression device in all functions @@ -76,7 +76,7 @@ The ``rte_compressdev_configure`` API is used to configure a compression device. The ``rte_compressdev_config`` structure is used to pass the configuration parameters. -See *DPDK API Reference* for details. +See the `DPDK API Reference `_ for details. Configuration of Queue Pairs ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ @@ -85,87 +85,88 @@ Each compression device queue pair is individually configured through the ``rte_compressdev_queue_pair_setup`` API. The ``max_inflight_ops`` is used to pass maximum number of -rte_comp_op that could be present in a queue at-a-time. -PMD then can allocate resources accordingly on a specified socket. +``rte_comp_op`` that could be present in a queue at a time. +The PMD can then allocate resources accordingly on a specified socket. -See *DPDK API Reference* for details. +See the `DPDK API Reference `_ for details. -Logical Cores, Memory and Queues Pair Relationships -~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +Logical Cores, Memory and Queue Pair Relationships +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -Library supports NUMA similarly as described in Cryptodev library section. +The Compressdev library supports NUMA similarly as described in Cryptodev library section. -A queue pair cannot be shared and should be exclusively used by a single processing -context for enqueuing operations or dequeuing operations on the same compression device +A queue pair cannot be shared, and should be exclusively used by a single processing +context for enqueuing operations or dequeuing operations on the same compression device, since sharing would require global locks and hinder performance. It is however possible to use a different logical core to dequeue an operation on a queue pair from the logical -core on which it was enqueued. This means that a compression burst enqueue/dequeue +core on which it was enqueued. This means that for a compression burst, enqueue/dequeue APIs are a logical place to transition from one logical core to another in a data processing pipeline. Device Features and Capabilities ---------------------------------- +-------------------------------- Compression devices define their functionality through two mechanisms, global device -features and algorithm features. Global devices features identify device -wide level features which are applicable to the whole device such as supported hardware +features and algorithm features. Global device features identify device +wide level features which are applicable to the whole device, such as supported hardware acceleration and CPU features. List of compression device features can be seen in the RTE_COMPDEV_FF_XXX macros. -The algorithm features lists individual algo feature which device supports per-algorithm, -such as a stateful compression/decompression, checksums operation etc. List of algorithm -features can be seen in the RTE_COMP_FF_XXX macros. +The algorithm features are features which the device supports per-algorithm, +such as a stateful compression/decompression, checksums operation etc. +The list of algorithm features can be seen in the RTE_COMP_FF_XXX macros. Capabilities ~~~~~~~~~~~~ Each PMD has a list of capabilities, including algorithms listed in -enum ``rte_comp_algorithm`` and its associated feature flag and -sliding window range in log base 2 value. Sliding window tells -the minimum and maximum size of lookup window that algorithm uses +the enum ``rte_comp_algorithm``, its associated feature flag, and +sliding window range in log base 2 value. The sliding window range +defines the minimum and maximum size of a lookup window that an algorithm uses to find duplicates. -See *DPDK API Reference* for details. +See the `DPDK API Reference `_ for details. Each Compression poll mode driver defines its array of capabilities -for each algorithm it supports. See PMD implementation for capability +for each algorithm it supports. See the PMD implementation for capability initialization. Capabilities Discovery ~~~~~~~~~~~~~~~~~~~~~~ -PMD capability and features are discovered via ``rte_compressdev_info_get`` function. +PMD capability and features are discovered via the ``rte_compressdev_info_get`` function. The ``rte_compressdev_info`` structure contains all the relevant information for the device. -See *DPDK API Reference* for details. +See the `DPDK API Reference `_ for details. Compression Operation ----------------------- +--------------------- DPDK compression supports two types of compression methodologies: -- Stateless, data associated to a compression operation is compressed without any reference +- Stateless - data associated with a compression operation is compressed without any reference to another compression operation. -- Stateful, data in each compression operation is compressed with reference to previous compression +- Stateful - data in each compression operation is compressed with reference to previous compression operations in the same data stream i.e. history of data is maintained between the operations. -For more explanation, please refer RFC https://www.ietf.org/rfc/rfc1951.txt +For more explanation, please refer to the RFC https://www.ietf.org/rfc/rfc1951.txt Operation Representation ~~~~~~~~~~~~~~~~~~~~~~~~ -Compression operation is described via ``struct rte_comp_op``, which contains both input and +A compression operation is described via ``struct rte_comp_op``, which contains both input and output data. The operation structure includes the operation type (stateless or stateful), -the operation status and the priv_xform/stream handle, source, destination and checksum buffer +the operation status, the priv_xform/stream handle, source, destination and checksum buffer pointers. It also contains the source mempool from which the operation is allocated. -PMD updates consumed field with amount of data read from source buffer and produced -field with amount of data of written into destination buffer along with status of -operation. See section *Produced, Consumed And Operation Status* for more details. - -Compression operations mempool also has an ability to allocate private memory with the -operation for application's purposes. Application software is responsible for specifying -all the operation specific fields in the ``rte_comp_op`` structure which are then used +The PMD updates the consumed field with the amount of data read from the source buffer, +and the produced field with the amount of data written into the destination buffer, +along with status of operation. +See the section :ref:`compressdev_prod_cons_op_status`: for more details. + +The compression operations mempool also has the ability to allocate private memory with the +operation for the application's use. The application software is responsible for specifying +all the operation specific fields in the ``rte_comp_op`` structure, which are then used by the compression PMD to process the requested operation. @@ -181,27 +182,27 @@ A ``rte_comp_op`` contains a field indicating the pool it originated from. ``rte_comp_op_alloc()`` and ``rte_comp_op_bulk_alloc()`` are used to allocate compression operations from a given compression operation mempool. -The operation gets reset before being returned to a user so that operation +The operation gets reset before being returned to a user so that the operation is always in a good known state before use by the application. ``rte_comp_op_free()`` is called by the application to return an operation to its allocating pool. -See *DPDK API Reference* for details. +See the `DPDK API Reference `_ for details. Passing source data as mbuf-chain -~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ If input data is scattered across several different buffers, then -Application can either parse through all such buffers and make one +the application can either parse through all such buffers and make one mbuf-chain and enqueue it for processing or, alternatively, it can -make multiple sequential enqueue_burst() calls for each of them -processing them statefully. See *Compression API Stateful Operation* +make multiple sequential enqueue_burst() calls for each of them, +processing them statefully. See :ref:`compressdev_stateful_op`: for stateful processing of ops. Operation Status ~~~~~~~~~~~~~~~~ -Each operation carries a status information updated by PMD after it is processed. -Following are currently supported: +Each operation carries status information updated by the PMD after it is processed. +The following are currently supported: - RTE_COMP_OP_STATUS_SUCCESS, Operation is successfully completed @@ -225,22 +226,25 @@ Following are currently supported: - RTE_COMP_OP_STATUS_OUT_OF_SPACE_RECOVERABLE, Output buffer ran out of space before operation completed, but this is not an error case. Output data up to op.produced can be used and - next op in the stream should continue on from op.consumed+1. + the next op in the stream should continue on from op.consumed+1. Operation status after enqueue / dequeue ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Some of the above values may arise in the op after an -``rte_compressdev_enqueue_burst()``. If number ops enqueued < number ops requested then -the app should check the op.status of nb_enqd+1. If status is RTE_COMP_OP_STATUS_NOT_PROCESSED, -it likely indicates a full-queue case for a hardware device and a retry after dequeuing some ops is likely -to be successful. If the op holds any other status, e.g. RTE_COMP_OP_STATUS_INVALID_ARGS, a retry with +``rte_compressdev_enqueue_burst()``. If the number of ops enqueued < the number of ops requested +then the app should check the op.status of nb_enqd+1. +If the status is RTE_COMP_OP_STATUS_NOT_PROCESSED, it likely indicates a full-queue case for a +hardware device, and a retry after dequeuing some ops is likely to be successful. +If the op holds any other status, e.g. RTE_COMP_OP_STATUS_INVALID_ARGS, a retry with the same op is unlikely to be successful. +.. _compressdev_prod_cons_op_status: + Produced, Consumed And Operation Status ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -- If status is RTE_COMP_OP_STATUS_SUCCESS, +- If the status is RTE_COMP_OP_STATUS_SUCCESS, consumed = amount of data read from input buffer, and produced = amount of data written in destination buffer - If status is RTE_COMP_OP_STATUS_ERROR, @@ -253,37 +257,37 @@ Produced, Consumed And Operation Status - If status is RTE_COMP_OP_STATUS_OUT_OF_SPACE_RECOVERABLE, consumed = amount of data read, and produced = amount of data successfully produced until - out of space condition hit. PMD has ability to recover - from here, so application can submit next op from - consumed+1 and a destination buffer with available space. + out of space condition hit. The PMD has ability to recover + from here, so an application can submit the next op from + consumed+1, and a destination buffer with available space. Transforms ---------- Compression transforms (``rte_comp_xform``) are the mechanism to specify the details of the compression operation such as algorithm, -window size and checksum. +window size, and checksum. Compression API Hash support ---------------------------- -Compression API allows application to enable digest calculation +The compression API allows an application to enable digest calculation alongside compression and decompression of data. A PMD reflects its support for hash algorithms via capability algo feature flags. -If supported, PMD calculates digest always on plaintext i.e. +If supported, the PMD always calculates the digest on plaintext i.e. before compression and after decompression. Currently supported list of hash algos are SHA-1 and SHA2 family SHA256. -See *DPDK API Reference* for details. +See the `DPDK API Reference `_ for details. -If required, application should set valid hash algo in compress +If required, the application should set the valid hash algo in compress or decompress xforms during ``rte_compressdev_stream_create()`` -or ``rte_compressdev_private_xform_create()`` and pass a valid +or ``rte_compressdev_private_xform_create()``, and pass a valid output buffer in ``rte_comp_op`` hash field struct to store the -resulting digest. Buffer passed should be contiguous and large -enough to store digest which is 20 bytes for SHA-1 and +resulting digest. The buffer passed should be contiguous and large +enough to store digest, which is 20 bytes for SHA-1 and 32 bytes for SHA2-256. Compression API Stateless operation @@ -295,20 +299,21 @@ An op is processed stateless if it has (required only on compression side), - All required input in source buffer -When all of the above conditions are met, PMD initiates stateless processing +When all of the above conditions are met, the PMD initiates stateless processing and releases acquired resources after processing of current operation is -complete. Application can enqueue multiple stateless ops in a single burst +complete. The application can enqueue multiple stateless ops in a single burst and must attach priv_xform handle to such ops. priv_xform in Stateless operation ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -priv_xform is PMD internally managed private data that it maintains to do stateless processing. -priv_xforms are initialized provided a generic xform structure by an application via making call -to ``rte_compressdev_private_xform_create``, at an output PMD returns an opaque priv_xform reference. -If PMD support SHAREABLE priv_xform indicated via algorithm feature flag, then application can -attach same priv_xform with many stateless ops at-a-time. If not, then application needs to -create as many priv_xforms as it expects to have stateless operations in-flight. +A priv_xform is private data managed internally by the PMD to do stateless processing. +A priv_xform is initialized by an application providing a generic xform structure +to ``rte_compressdev_private_xform_create``, which returns an opaque priv_xform reference. +If the PMD supports SHAREABLE priv_xform, indicated via algorithm feature flag, +then the application can attach the same priv_xform with many stateless ops at a time. +If not, then the application needs to create as many priv_xforms as it expects to have +stateless operations in-flight. .. figure:: img/stateless-op.* @@ -320,8 +325,9 @@ create as many priv_xforms as it expects to have stateless operations in-flight. Stateless Ops using Shareable priv_xform -Application should call ``rte_compressdev_private_xform_create()`` and attach to stateless op before -enqueuing them for processing and free via ``rte_compressdev_private_xform_free()`` during termination. +The application should call ``rte_compressdev_private_xform_create()`` and attach it to a stateless +op before enqueuing them for processing and free via ``rte_compressdev_private_xform_free()`` +during termination. An example pseudocode to setup and process NUM_OPS stateless ops with each of length OP_LEN using priv_xform would look like: @@ -399,75 +405,80 @@ using priv_xform would look like: Stateless and OUT_OF_SPACE -~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +~~~~~~~~~~~~~~~~~~~~~~~~~~ -OUT_OF_SPACE is a condition when output buffer runs out of space and where PMD -still has more data to produce. If PMD runs into such condition, then PMD returns -RTE_COMP_OP_OUT_OF_SPACE_TERMINATED error. In such case, PMD resets itself and can set +OUT_OF_SPACE is a condition when the output buffer runs out of space and where the PMD +still has more data to produce. If the PMD runs into such condition, then the PMD returns +RTE_COMP_OP_OUT_OF_SPACE_TERMINATED error. In such case, the PMD resets itself and can set consumed=0 and produced=amount of output it could produce before hitting out_of_space. -Application would need to resubmit the whole input with a larger output buffer, if it +The application would need to resubmit the whole input with a larger output buffer, if it wants the operation to be completed. Hash in Stateless ~~~~~~~~~~~~~~~~~ -If hash is enabled, digest buffer will contain valid data after op is successfully +If hash is enabled, the digest buffer will contain valid data after an op is successfully processed i.e. dequeued with status = RTE_COMP_OP_STATUS_SUCCESS. Checksum in Stateless ~~~~~~~~~~~~~~~~~~~~~ -If checksum is enabled, checksum will only be available after op is successfully +If checksum is enabled, checksum will only be available after an op is successfully processed i.e. dequeued with status = RTE_COMP_OP_STATUS_SUCCESS. +.. _compressdev_stateful_op: + Compression API Stateful operation ----------------------------------- -Compression API provide RTE_COMP_FF_STATEFUL_COMPRESSION and -RTE_COMP_FF_STATEFUL_DECOMPRESSION feature flag for PMD to reflect +The compression API provides RTE_COMP_FF_STATEFUL_COMPRESSION and +RTE_COMP_FF_STATEFUL_DECOMPRESSION feature flag for the PMD to reflect its support for Stateful operations. -A Stateful operation in DPDK compression means application invokes enqueue -burst() multiple times to process related chunk of data because -application broke data into several ops. +A Stateful operation in DPDK compression means the application invokes enqueue +burst() multiple times to process a related chunk of data because the +application broke the data into several ops. -In such case +In such cases - ops are setup with op_type RTE_COMP_OP_STATEFUL, -- all ops except last set to flush value = RTE_COMP_FLUSH_NONE/SYNC -and last set to flush value RTE_COMP_FLUSH_FULL/FINAL. +- all ops except the last are set with flush value = RTE_COMP_FLUSH_NONE/SYNC +and the last is set with flush value RTE_COMP_FLUSH_FULL/FINAL. -In case of either one or all of the above conditions, PMD initiates -stateful processing and releases acquired resources after processing +In case of either one or all of the above conditions, the PMD initiates +stateful processing and releases acquired resources after processing the operation with flush value = RTE_COMP_FLUSH_FULL/FINAL is complete. -Unlike stateless, application can enqueue only one stateful op from -a particular stream at a time and must attach stream handle +Unlike stateless, the application can enqueue only one stateful op from +a particular stream at a time and must attach a stream handle to each op. Stream in Stateful operation ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -`stream` in DPDK compression is a logical entity which identifies related set of ops, say, a one large -file broken into multiple chunks then file is represented by a stream and each chunk of that file is -represented by compression op `rte_comp_op`. Whenever application wants a stateful processing of such -data, then it must get a stream handle via making call to ``rte_compressdev_stream_create()`` -with xform, at an output the target PMD will return an opaque stream handle to application which -it must attach to all of the ops carrying data of that stream. In stateful processing, every op -requires previous op data for compression/decompression. A PMD allocates and set up resources such -as history, states, etc. within a stream, which are maintained during the processing of the related ops. +A stream in DPDK compression is a logical entity which identifies a related set of ops. +For example, one large file broken into multiple chunks, then the file is represented by a stream, +and each chunk of that file is represented by a compression op ``rte_comp_op``. +Whenever an application wants stateful processing of such data, then it must get a stream handle +via making call to ``rte_compressdev_stream_create()`` with an xform, which will return an opaque +stream handle to attach to all of the ops carrying data of that stream. +In stateful processing, every op requires previous op data for compression/decompression. +A PMD allocates and sets up resources such as history, states, etc. within a stream, +which are maintained during the processing of related ops. -Unlike priv_xforms, stream is always a NON_SHAREABLE entity. One stream handle must be attached to only -one set of related ops and cannot be reused until all of them are processed with status Success or failure. +Unlike priv_xforms, a stream is always a NON_SHAREABLE entity. One stream handle must be attached +to only one set of related ops and cannot be reused until all of them are processed with a +success/failure status. .. figure:: img/stateful-op.* Stateful Ops -Application should call ``rte_compressdev_stream_create()`` and attach to op before +An application should call ``rte_compressdev_stream_create()`` and attach it to the op before enqueuing them for processing and free via ``rte_compressdev_stream_free()`` during -termination. All ops that are to be processed statefully should carry *same* stream. +termination. All ops that are to be processed statefully should carry the *same* stream. -See *DPDK API Reference* document for details. +See the `DPDK API Reference `_ for details. -An example pseudocode to set up and process a stream having NUM_CHUNKS with each chunk size of CHUNK_LEN would look like: +An example pseudocode to set up and process a stream having NUM_CHUNKS, +with each chunk size of CHUNK_LEN, would look like: .. code-block:: c @@ -549,64 +560,65 @@ An example pseudocode to set up and process a stream having NUM_CHUNKS with each Stateful and OUT_OF_SPACE -~~~~~~~~~~~~~~~~~~~~~~~~~~~ +~~~~~~~~~~~~~~~~~~~~~~~~~ -If PMD supports stateful operation, then OUT_OF_SPACE status is not an actual -error for the PMD. In such case, PMD returns with status +If a PMD supports stateful operation, then an OUT_OF_SPACE status is not an actual +error for the PMD. In such a case, the PMD returns with status RTE_COMP_OP_STATUS_OUT_OF_SPACE_RECOVERABLE with consumed = number of input bytes -read and produced = length of complete output buffer. -Application should enqueue next op with source starting at consumed+1 and an +read, and produced = length of complete output buffer. +The application should enqueue the next op with source starting at consumed+1, and an output buffer with available space. Hash in Stateful ~~~~~~~~~~~~~~~~ -If enabled, digest buffer will contain valid digest after last op in stream +If enabled, the digest buffer will contain valid digest after the last op in a stream (having flush = RTE_COMP_FLUSH_FINAL) is successfully processed i.e. dequeued with status = RTE_COMP_OP_STATUS_SUCCESS. Checksum in Stateful ~~~~~~~~~~~~~~~~~~~~ -If enabled, checksum will only be available after last op in stream +If enabled, the checksum will only be available after the last op in a stream (having flush = RTE_COMP_FLUSH_FINAL) is successfully processed i.e. dequeued with status = RTE_COMP_OP_STATUS_SUCCESS. Burst in compression API -------------------------- +------------------------ Scheduling of compression operations on DPDK's application data path is performed using a burst oriented asynchronous API set. A queue pair on a compression -device accepts a burst of compression operations using enqueue burst API. On physical -devices the enqueue burst API will place the operations to be processed +device accepts a burst of compression operations using the enqueue burst API. +On physical devices the enqueue burst API will place the operations to be processed on the device's hardware input queue, for virtual devices the processing of the operations is usually completed during the enqueue call to the compression device. The dequeue burst API will retrieve any processed operations available from the queue pair on the compression device, from physical devices this is usually -directly from the devices processed queue, and for virtual device's from a +directly from the devices processed queue, and for virtual device's from an ``rte_ring`` where processed operations are placed after being processed on the enqueue call. -A burst in DPDK compression can be a combination of stateless and stateful operations with a condition -that for stateful ops only one op at-a-time should be enqueued from a particular stream i.e. no-two ops -should belong to same stream in a single burst. However a burst may contain multiple stateful ops as long -as each op is attached to a different stream i.e. a burst can look like: +A burst in DPDK compression can be a combination of stateless and stateful operations with a +condition that for stateful ops only one op at a time should be enqueued from a particular stream +i.e. two ops should never belong to the same stream in a single burst. +However, a burst may contain multiple stateful ops, as long as each op is attached to a different +stream, i.e. a burst can look like: +---------------+--------------+--------------+-----------------+--------------+--------------+ | enqueue_burst | op1.no_flush | op2.no_flush | op3.flush_final | op4.no_flush | op5.no_flush | +---------------+--------------+--------------+-----------------+--------------+--------------+ -Where, op1 .. op5 all belong to different independent data units. op1, op2, op4, op5 must be stateful -as stateless ops can only use flush full or final and op3 can be of type stateless or stateful. -Every op with type set to RTE_COMP_OP_STATELESS must be attached to priv_xform and -Every op with type set to RTE_COMP_OP_STATEFUL *must* be attached to stream. +Where, op1 .. op5 all belong to different independent data units. op1, op2, op4, op5 must be +stateful as stateless ops can only use flush full or final and op3 can be of type stateless or +stateful. Every op with type set to RTE_COMP_OP_STATELESS must be attached to priv_xform and +every op with type set to RTE_COMP_OP_STATEFUL *must* be attached to stream. Since each operation in a burst is independent and thus can be completed -out-of-order, applications which need ordering, should setup per-op user data -area with reordering information so that it can determine enqueue order at +out of order, applications which need ordering should setup a per-op user data +area, with reordering information so that it can determine enqueue order at dequeue. -Also if multiple threads calls enqueue_burst() on same queue pair then it’s -application onus to use proper locking mechanism to ensure exclusive enqueuing -of operations. +Also, if multiple threads calls enqueue_burst() on the same queue pair then it's +the application's responsibility to use a proper locking mechanism to ensure +exclusive enqueuing of operations. Enqueue / Dequeue Burst APIs ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ @@ -629,9 +641,10 @@ Sample code ----------- There are unit test applications that show how to use the compressdev library inside -app/test/test_compressdev.c +``app/test/test_compressdev.c`` Compression Device API ~~~~~~~~~~~~~~~~~~~~~~ -The compressdev Library API is described in the *DPDK API Reference* document. +The compressdev Library API is described in the +`DPDK API Reference `_. -- 2.35.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-07-20 15:01:01.222998600 +0800 +++ 0052-doc-fix-grammar-and-formatting-in-compressdev-guide.patch 2022-07-20 15:00:58.791000367 +0800 @@ -1 +1 @@ -From 4c9484373fcd0aa4a240fdb2e797269eb2f26b9b Mon Sep 17 00:00:00 2001 +From 92962694e870727efa84358a3323c58ee1c2d8a0 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 4c9484373fcd0aa4a240fdb2e797269eb2f26b9b ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org