From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E526FA00C5 for ; Wed, 20 Jul 2022 10:26:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D907240A7A; Wed, 20 Jul 2022 10:26:56 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2082.outbound.protection.outlook.com [40.107.220.82]) by mails.dpdk.org (Postfix) with ESMTP id 10E6A40697 for ; Wed, 20 Jul 2022 10:26:55 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WUdBYzeqO2XdDdeqfTr1oL1PEWITSRvG4Y2Mqu6Hp3BJUT9cQaGHlweeLXQvcxaTok/lBAsru3GrJNPmdW3Zpv6u0UVxjf9k7xrP62uaOsQBpSkHZ9KmWc79Q2wUIY5bY80Prtu2JipM0rPYYLCk2H5+cVbqxgSfCmqzRWTYPkzFo/8tGyNmvxEyW79Sh2VMCGWXPZdDkcwJfExqGH67j4iBqNz1n6YZVgmcI0MT3S8b6vG1b8uhdnnSFRwhu2FHl/blh4UeKrUyS8tWi1Bl1q+SSyVFjrEvuxiQ/HLDJMcUYAUC3qCcDI4vX6H2JBtyFe56+V43TkpINWxZ2RQlnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RXp2Z9K9tZB0HOwgfLZxkIZl2mtLHuwTMggsHebWmdQ=; b=oNGF88rMnWBTTROh/ULpfZ2XSJs8iwjV0MKM1Ua5B++mZO8hvxAR4D0tJgztTo+4LIIXpoptDg8YkyoYht8VwVUIrjKfpPmn6f08uD8b3MBUvHXHJ3bT8cQ2XBoHbax9Lb0qQ7Bcs07S/mJhxEimh18Kg+n8CX098OUGlmI0TZQ57fP/RX1gE2RF48nCv3ckX5q++xaa6+3l9V0RRO7v+1VQGovWrSdhtA0GempydCjfStO9XPCXn//OODjNbrN+Hq9El4Ta8YYt5itnTnfsbHpTOwh60g/DW1OSRSs0nUONg+4+EBJYN8aHrLln7J0PsygDFuHysjWd4nzUJk/3oA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 12.22.5.234) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RXp2Z9K9tZB0HOwgfLZxkIZl2mtLHuwTMggsHebWmdQ=; b=p3N2enDHWVUaSuoAXT11JZDIgsKgPmHrXr/8dUmn1TqNX5O5MRdz76KsRi95XabHzmmBynMlgjNsCQXWrLjXeZC5XUruCYrR1Wk2zFq6/EMi9wpF+0Ow618bX4rFHU03inZxZ0JXcF4w2n9fO0O7JiJU/n2aOXywfIHiZuTCxsXOfEtGxmMI4miWJvCN2zOglx48udEyvyjwhGCL20lQaR2wSqUzClIXElrcuM6oGJiCXeQMRWNPtyeIKNFgKo9GKE/1e3Ia1mIK+T5TgkVh/X2ZlQuTPe/ljMbsgVTm9+p0QFPwrMFGxiz/OqnoVTmSz2XdY1Ek42kS0bH7NfZ2og== Received: from BN0PR02CA0016.namprd02.prod.outlook.com (2603:10b6:408:e4::21) by CY4PR12MB1797.namprd12.prod.outlook.com (2603:10b6:903:124::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.20; Wed, 20 Jul 2022 08:26:52 +0000 Received: from BN8NAM11FT033.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e4:cafe::32) by BN0PR02CA0016.outlook.office365.com (2603:10b6:408:e4::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20 via Frontend Transport; Wed, 20 Jul 2022 08:26:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 12.22.5.234) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 12.22.5.234 as permitted sender) receiver=protection.outlook.com; client-ip=12.22.5.234; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (12.22.5.234) by BN8NAM11FT033.mail.protection.outlook.com (10.13.177.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.5458.17 via Frontend Transport; Wed, 20 Jul 2022 08:26:51 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by DRHQMAIL101.nvidia.com (10.27.9.10) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Wed, 20 Jul 2022 08:26:50 +0000 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Wed, 20 Jul 2022 01:26:48 -0700 From: Xueming Li To: Herakliusz Lipiec CC: , Chenbo Xia , dpdk stable Subject: patch 'doc: fix readability in vhost guide' has been queued to stable release 20.11.6 Date: Wed, 20 Jul 2022 11:21:26 +0300 Message-ID: <20220720082132.3954126-57-xuemingl@nvidia.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220720082132.3954126-1-xuemingl@nvidia.com> References: <20220621080301.2315720-1-xuemingl@nvidia.com> <20220720082132.3954126-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 527f5b2d-3228-4185-2e0c-08da6a2998d4 X-MS-TrafficTypeDiagnostic: CY4PR12MB1797:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?17TUpR7bXVcHRZb+lnVqAP2l6pCsq4uAcBSJr6Si/aV6Vxt9kxoGVBhH/9h4?= =?us-ascii?Q?T1K8PdASd12UTR43MajpnC9ksE4GjGzEnejAEzTdeSI95rhk/osZ92Nqxm6I?= =?us-ascii?Q?Da7doTQ5yQkqpS9qmjk2C2qh2u6pl1CCLlQce8s2F3UZmC8s2fgVHqm+f/CN?= =?us-ascii?Q?203sybxrRMiB/GdIvojUQpqbiXC+xVu2GuxRFlAdpgt0DA+kPTaQjyxubB+v?= =?us-ascii?Q?B/n4uJcl75gdyW3EDjTCcU/Q0XFc/8H8KKmikibykNke+KZOa47ra7gplNrI?= =?us-ascii?Q?jLYeVDxm8acb4exeD/LZMMvotGPVod6glq+ohfEpeSqlopZlZKD4owV98IUw?= =?us-ascii?Q?IIAR9D1/CuGv6aQvnwSC802B5dP1KWucsGGddKD1hXr5c+6TyErfuvP3P1Oy?= =?us-ascii?Q?ZH5fFVBrTg1mAsmk8bAWTZ9oDQgU6pw4a1UnaaHwYQTgNuA475Jc2KT0XbIq?= =?us-ascii?Q?aJtCaXZrRON2QRydyZWPR12WvCVH4YHPnsZAP80gRH33EIC8TDZyBvsNYwDj?= =?us-ascii?Q?aRn/z+htkXdKDf+UJOobIXI1++dkWv+Sj4u5TCZ9dy8lxqGsNTl/+EfYvK/t?= =?us-ascii?Q?vDUkMey38DGUgqvn/pVdDteWcjc6xA7sETfz3l1sZDBS/u0etp7HO2JWAb2W?= =?us-ascii?Q?mX4Kb34kDxkTx0s+R99jg2BdW0WB7VcBx/lk5KkOsGRU39fYvdw8+FaVws03?= =?us-ascii?Q?V5b3EFPH42bjl2bzK9ixyPaHwlegaDT9uCsgSzfAHyMdAnnmDka0cwpHOrlY?= =?us-ascii?Q?clqJwbPVrBrqiK0RdOLqa0NmQGQU4v8r4ux0R1IchsWbRzWo+gUsDwyxgik4?= =?us-ascii?Q?8Hjr9KUdBwpxhSsIOj8Bi8I9BMOgbqj5h3677CxkSwSAnsGkOnUHj8Q+qvOY?= =?us-ascii?Q?3Lgxv81g3yUzuebeho8akH8ajd6YzsZQ1omyfTrlgIGETGRAI3OYiD51Yu9N?= =?us-ascii?Q?pCDx26RMkuv+Fk11nV2V6Q=3D=3D?= X-Forefront-Antispam-Report: CIP:12.22.5.234; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:InfoNoRecords; CAT:NONE; SFS:(13230016)(4636009)(376002)(396003)(39860400002)(346002)(136003)(40470700004)(46966006)(36840700001)(5660300002)(6286002)(36756003)(40480700001)(83380400001)(26005)(8936002)(356005)(86362001)(82740400003)(55016003)(82310400005)(2906002)(8676002)(336012)(53546011)(316002)(47076005)(70206006)(478600001)(70586007)(40460700003)(966005)(41300700001)(7696005)(1076003)(186003)(6666004)(36860700001)(2616005)(54906003)(16526019)(4326008)(81166007)(426003)(6916009)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2022 08:26:51.4717 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 527f5b2d-3228-4185-2e0c-08da6a2998d4 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[12.22.5.234]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT033.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1797 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/22/22. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/steevenlee/dpdk This queued commit can be viewed at: https://github.com/steevenlee/dpdk/commit/a31510afb79db12b14732b3327ed7c9b345ea54e Thanks. Xueming Li --- >From a31510afb79db12b14732b3327ed7c9b345ea54e Mon Sep 17 00:00:00 2001 From: Herakliusz Lipiec Date: Thu, 23 Jun 2022 14:57:21 +0100 Subject: [PATCH] doc: fix readability in vhost guide Cc: Xueming Li [ upstream commit c8a3ee49c94d72d03e2de5814bca01f7fd7d79d1 ] fix grammar issues and readbility in vhost library programmer guide Fixes: 768274ebbd5e ("vhost: avoid populate guest memory") Signed-off-by: Herakliusz Lipiec Reviewed-by: Chenbo Xia --- doc/guides/prog_guide/vhost_lib.rst | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/doc/guides/prog_guide/vhost_lib.rst b/doc/guides/prog_guide/vhost_lib.rst index 493818bcf9..8970db8e5c 100644 --- a/doc/guides/prog_guide/vhost_lib.rst +++ b/doc/guides/prog_guide/vhost_lib.rst @@ -299,7 +299,7 @@ vhost-user implementation has two options: * The vhost supported features must be exactly the same before and after the restart. For example, if TSO is disabled and then enabled, - nothing will work and issues undefined might happen. + nothing will work and undefined issues might happen. No matter which mode is used, once a connection is established, DPDK vhost-user will start receiving and processing vhost messages from QEMU. @@ -330,12 +330,12 @@ Guest memory requirement * Memory pre-allocation - For non-async data path, guest memory pre-allocation is not a - must. This can help save of memory. If users really want the guest memory - to be pre-allocated (e.g., for performance reason), we can add option - ``-mem-prealloc`` when starting QEMU. Or, we can lock all memory at vhost - side which will force memory to be allocated when mmap at vhost side; - option --mlockall in ovs-dpdk is an example in hand. + For non-async data path guest memory pre-allocation is not a + must but can help save memory. To do this we can add option + ``-mem-prealloc`` when starting QEMU, or we can lock all memory at vhost + side which will force memory to be allocated when it calls mmap + (option --mlockall in ovs-dpdk is an example in hand). + For async data path, we force the VM memory to be pre-allocated at vhost lib when mapping the guest memory; and also we need to lock the memory to @@ -343,8 +343,8 @@ Guest memory requirement * Memory sharing - Make sure ``share=on`` QEMU option is given. vhost-user will not work with - a QEMU version without shared memory mapping. + Make sure ``share=on`` QEMU option is given. The vhost-user will not work with + a QEMU instance without shared memory mapping. Vhost supported vSwitch reference --------------------------------- -- 2.35.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2022-07-20 15:01:01.430983845 +0800 +++ 0057-doc-fix-readability-in-vhost-guide.patch 2022-07-20 15:00:58.801000350 +0800 @@ -1 +1 @@ -From c8a3ee49c94d72d03e2de5814bca01f7fd7d79d1 Mon Sep 17 00:00:00 2001 +From a31510afb79db12b14732b3327ed7c9b345ea54e Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit c8a3ee49c94d72d03e2de5814bca01f7fd7d79d1 ] @@ -9 +11,0 @@ -Cc: stable@dpdk.org @@ -18 +20 @@ -index a4ffed9fa1..bad4d819e1 100644 +index 493818bcf9..8970db8e5c 100644 @@ -21 +23 @@ -@@ -351,7 +351,7 @@ vhost-user implementation has two options: +@@ -299,7 +299,7 @@ vhost-user implementation has two options: @@ -30 +32 @@ -@@ -382,12 +382,12 @@ Guest memory requirement +@@ -330,12 +330,12 @@ Guest memory requirement @@ -49 +51 @@ -@@ -395,8 +395,8 @@ Guest memory requirement +@@ -343,8 +343,8 @@ Guest memory requirement